* [PATCH] tpm: remove unused variables
@ 2018-01-02 10:38 Arnd Bergmann
2018-01-02 15:36 ` Jarkko Sakkinen
2018-01-07 23:40 ` James Morris
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2018-01-02 10:38 UTC (permalink / raw)
To: Peter Huewe, Jarkko Sakkinen
Cc: Arnd Bergmann, Jason Gunthorpe, Greg Kroah-Hartman, Azhar Shaikh,
James Morris, linux-integrity, linux-kernel
The CLKRUN fix caused a few harmless compile-time warnings:
drivers/char/tpm/tpm_tis.c: In function 'tpm_tis_pnp_remove':
drivers/char/tpm/tpm_tis.c:274:23: error: unused variable 'priv' [-Werror=unused-variable]
drivers/char/tpm/tpm_tis.c: In function 'tpm_tis_plat_remove':
drivers/char/tpm/tpm_tis.c:324:23: error: unused variable 'priv' [-Werror=unused-variable]
This removes the variables that have now become unused.
Fixes: 6d0866cbc2d3 ("tpm: Keep CLKRUN enabled throughout the duration of transmit_cmd()")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/char/tpm/tpm_tis.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
index c847fc69a2fc..1bcbf355141e 100644
--- a/drivers/char/tpm/tpm_tis.c
+++ b/drivers/char/tpm/tpm_tis.c
@@ -271,7 +271,6 @@ MODULE_DEVICE_TABLE(pnp, tpm_pnp_tbl);
static void tpm_tis_pnp_remove(struct pnp_dev *dev)
{
struct tpm_chip *chip = pnp_get_drvdata(dev);
- struct tpm_tis_data *priv = dev_get_drvdata(&chip->dev);
tpm_chip_unregister(chip);
tpm_tis_remove(chip);
@@ -321,7 +320,6 @@ static int tpm_tis_plat_probe(struct platform_device *pdev)
static int tpm_tis_plat_remove(struct platform_device *pdev)
{
struct tpm_chip *chip = dev_get_drvdata(&pdev->dev);
- struct tpm_tis_data *priv = dev_get_drvdata(&chip->dev);
tpm_chip_unregister(chip);
tpm_tis_remove(chip);
--
2.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tpm: remove unused variables
2018-01-02 10:38 [PATCH] tpm: remove unused variables Arnd Bergmann
@ 2018-01-02 15:36 ` Jarkko Sakkinen
2018-01-07 23:40 ` James Morris
1 sibling, 0 replies; 3+ messages in thread
From: Jarkko Sakkinen @ 2018-01-02 15:36 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Peter Huewe, Jason Gunthorpe, Greg Kroah-Hartman, Azhar Shaikh,
James Morris, linux-integrity, linux-kernel
On Tue, Jan 02, 2018 at 11:38:54AM +0100, Arnd Bergmann wrote:
> The CLKRUN fix caused a few harmless compile-time warnings:
>
> drivers/char/tpm/tpm_tis.c: In function 'tpm_tis_pnp_remove':
> drivers/char/tpm/tpm_tis.c:274:23: error: unused variable 'priv' [-Werror=unused-variable]
> drivers/char/tpm/tpm_tis.c: In function 'tpm_tis_plat_remove':
> drivers/char/tpm/tpm_tis.c:324:23: error: unused variable 'priv' [-Werror=unused-variable]
>
> This removes the variables that have now become unused.
>
> Fixes: 6d0866cbc2d3 ("tpm: Keep CLKRUN enabled throughout the duration of transmit_cmd()")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks.
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
/Jarkko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tpm: remove unused variables
2018-01-02 10:38 [PATCH] tpm: remove unused variables Arnd Bergmann
2018-01-02 15:36 ` Jarkko Sakkinen
@ 2018-01-07 23:40 ` James Morris
1 sibling, 0 replies; 3+ messages in thread
From: James Morris @ 2018-01-07 23:40 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Peter Huewe, Jarkko Sakkinen, Jason Gunthorpe, Greg Kroah-Hartman,
Azhar Shaikh, linux-integrity, linux-kernel
On Tue, 2 Jan 2018, Arnd Bergmann wrote:
> The CLKRUN fix caused a few harmless compile-time warnings:
>
> drivers/char/tpm/tpm_tis.c: In function 'tpm_tis_pnp_remove':
> drivers/char/tpm/tpm_tis.c:274:23: error: unused variable 'priv' [-Werror=unused-variable]
> drivers/char/tpm/tpm_tis.c: In function 'tpm_tis_plat_remove':
> drivers/char/tpm/tpm_tis.c:324:23: error: unused variable 'priv' [-Werror=unused-variable]
>
> This removes the variables that have now become unused.
>
> Fixes: 6d0866cbc2d3 ("tpm: Keep CLKRUN enabled throughout the duration of transmit_cmd()")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: James Morris <james.l.morris@oracle.com>
--
James Morris
<james.l.morris@oracle.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-07 23:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-02 10:38 [PATCH] tpm: remove unused variables Arnd Bergmann
2018-01-02 15:36 ` Jarkko Sakkinen
2018-01-07 23:40 ` James Morris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).