Re: [PATCH] char: tpm: Use SIMPLE_DEV_PM_OPS for ibmvtpm power management

[Jarkko Sakkinen <jarkko@kernel.org>]

On Wed, Aug 19, 2026 at 04:35:47PM +0800, Li Jun wrote:
> Replace the manually defined dev_pm_ops structure with the
> SIMPLE_DEV_PM_OPS macro to simplify the power management code.
> This macro automatically handles CONFIG_PM_SLEEP configuration,
> generating the same suspend/resume callbacks while reducing
> boilerplate code.Add the value of 'thaw,freeze,poweroff,restore'.
> 
> Signed-off-by: Li Jun <lijun01@kylinos.cn>
> ---
>  drivers/char/tpm/tpm_ibmvtpm.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c
> index 6fb4d30eb6f6..51c7e2add3d2 100644
> --- a/drivers/char/tpm/tpm_ibmvtpm.c
> +++ b/drivers/char/tpm/tpm_ibmvtpm.c
> @@ -462,10 +462,7 @@ static const struct tpm_class_ops tpm_ibmvtpm = {
>  	.req_canceled = tpm_ibmvtpm_req_canceled,
>  };
>  
> -static const struct dev_pm_ops tpm_ibmvtpm_pm_ops = {
> -	.suspend = tpm_ibmvtpm_suspend,
> -	.resume = tpm_ibmvtpm_resume,
> -};
> +static SIMPLE_DEV_PM_OPS(tpm_ibmvtpm_pm_ops, tpm_ibmvtpm_suspend, tpm_ibmvtpm_resume);
>  
>  /**
>   * ibmvtpm_crq_get_next - Get next responded crq
> -- 
> 2.25.1
> 

Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>

BR, Jarkko