Linux Integrity Measurement development
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko@kernel.org>
To: Sean Meadows <Hellfire@unspacy.com>,
	Mario Limonciello <mario.limonciello@amd.com>
Cc: linux-integrity@vger.kernel.org, peterhuewe@gmx.de, jgg@ziepe.ca,
	rafael@kernel.org, lenb@kernel.org, linux-acpi@vger.kernel.org,
	Adam Alves <adamoa@gmail.com>
Subject: Re: [BUG] tpm_crb/Intel PTT: Late S3/S5/Reboot ACPI power management deadlock
Date: Thu, 8 Oct 2026 20:47:37 +0300	[thread overview]
Message-ID: <asfXObGNaZ9Z8CwN@kernel.org> (raw)
In-Reply-To: <723ff551-7852-4d57-ab1e-787a1a195759@unspacy.com>

On Wed, Oct 07, 2026 at 12:27:01PM -0400, Sean Meadows wrote:
> On 9/29/26 18:25, Jarkko Sakkinen wrote:
> > There's a commit with title "tpm: Call cmd_ready/go_idle for each command
> > transmission", which is strongest contender to make a difference to this
> > long running issue.
> > 
> > I.e. I think it will improve firmware behavior given full release of
> > resources per TPM command.
> > 
> > I'm including it to v7.4 pull request.
> > 
> > Br, Jarkko
> 
> Hi Jarkko,
> 
> I have to break some bad news.
> 
> Testing Mr. Alves’s patch first led to a failure at the 60-hour mark.
> 
> Mario’s patch—"tpm: Call cmd_ready/go_idle for each command
> transmission"—failed at 55 hours.
> 
> To give additional details: with Alves’ patch, I ported it forward and
> tested it on kernel 7.2.7.
> 
> With Mario’s patch, I downloaded the 7.3-rc5 mainline tree from Linus,
> git-grabbed your tree to get the TPM patches, and then cherry-picked
> Mario’s commit. It was applied and built without issue. If being cherry-
> picked onto 7.3-rc5 left it deficient in some way, please let me know.
> 
> I then proceeded to run 7.2.8 with my new USB3 debug cable.
> 
> I initiated an S3 sleep after a fresh power-on to get a baseline. I have
> complete logs saved, but I’ll simplify here to keep the message short
> and succinct.
> 
> 1. systemd-logind[483]: Lid closed.
> 2. rtkit-daemon[648]: Successfully demoted thread 1001 of process 993.
> 3. systemd-logind[483]: The system will suspend now!
> 4. Kernel enters device suspend phase | driver callbacks | many lines of
> confirmation as drivers and hardware transitioned
> 
> 45 hours later, I tested the next S3 sleep and the following occurred:
> 
> 1. systemd-logind[483]: Lid closed.
> 2. rtkit-daemon[648]: Successfully demoted thread 1001 of process 993.
> 3. Deadlock | USB3 DbC link drops immediately
> 
> I don’t know what all can be captured through this debug cable, and this
> next thought might be nonsensical as a result. Would you benefit from me
> installing Windows and snooping on what the Microsoft TPM driver is
> doing to prevent this deadlock?
> 
> Thank you for your time and patience,

The patch I pointed out this in bugzilla but the patch I had in mind is:

"tpm: Call cmd_ready/go_idle for each command transmission"

Link: https://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git/commit/?id=9154aa6c4b789d23e59d599c330cab2c4e915401

The reason is that the commit message highlight a bit similar issues as
reported in the bug.

Note commit IDs do change in my master branch so best is to look it up from: 

https://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git/log/

Right another reason is that then the driver always the TPM in the state
as it is when the driver starts.

I'm not sure about Windows but neither disregard it as sometimes we do
pick behavior basing it on how Window does it. I'd still try Mario's
patch at first.

> 
> Sean

Br, Jarkko

  reply	other threads:[~2026-10-08 17:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-10  6:45 [BUG] tpm_crb/Intel PTT: Late S3/S5/Reboot ACPI power management deadlock Sean Meadows
2026-09-18  1:28 ` Jarkko Sakkinen
2026-09-22  8:42   ` Sean Meadows
2026-09-25 15:05     ` Jarkko Sakkinen
2026-09-29 17:44       ` Sean Meadows
2026-09-29 22:25         ` Jarkko Sakkinen
2026-10-07 16:27           ` Sean Meadows
2026-10-08 17:47             ` Jarkko Sakkinen [this message]
2026-10-08 20:00               ` Mario Limonciello
2026-10-08 21:56                 ` Sean Meadows

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=asfXObGNaZ9Z8CwN@kernel.org \
    --to=jarkko@kernel.org \
    --cc=Hellfire@unspacy.com \
    --cc=adamoa@gmail.com \
    --cc=jgg@ziepe.ca \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=peterhuewe@gmx.de \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox