Re: [PATCH v3 0/2] tpm: OP-TEE transport core for discrete and firmware TPMs

[Jarkko Sakkinen <jarkko@kernel.org>]

On Wed, Nov 11, 2026 at 11:02:57PM +0100, Jorge Ramirez wrote:
> On 11/11/26 22:59:33, Jorge Ramirez-Ortiz wrote:
> > This adds a driver for a discrete TPM that OP-TEE owns and the normal
> > world cannot reach directly, and factors the shared OP-TEE TEE transport
> > into a small core so the existing fTPM driver uses it too:
> > 
> >   - a transport core shared by the OP-TEE TPM front-ends;
> >   - a new discrete TPM front-end;
> >   - the fTPM driver converted onto the core, keeping its name, its
> >     platform/OF binding and its shutdown path.
> > 
> > Patch 1 is the feature; patch 2 is the fTPM conversion that justifies the
> > core. Both front-ends were exercised on the Qualcomm Lemans EVK over the
> > shared core: the discrete ST33 TPM (patch 1) and the MS-TPM-20 firmware
> > TPM TA (patch 2), each presenting a working /dev/tpm0 (tpm2_getrandom,
> > PCR read). The fTPM TA is the same MS-TPM-20 reference the existing
> > tpm_ftpm_tee platforms use.
> > 
> > This is the normal-world half. The secure-world OP-TEE support it binds
> > to -- the in-core TPM2 SPI (TIS) driver and the mediator pseudo TA that
> > relays commands to it -- is under review separately:
> > 
> >   OP-TEE support: https://github.com/OP-TEE/optee_os/pull/8155
> >   locality 4:     https://github.com/OP-TEE/optee_os/issues/8160
> >                   (design follow-up: the secure world policing
> >                   normal-world locality access to the shared chip)
> > 
> > Build and test it on the Qualcomm Lemans EVK (a discrete ST33 TPM on
> > SPI, owned by OP-TEE):
> > 
> >   https://qualcomm-linux.github.io/qcom-buildroot/lemans/quick-start.html
> 
> The above was the wrong link, please use this one:
> 
> https://qualcomm-linux.github.io/qcom-buildroot/lemans/devel_lemans_security_dtpm.html

Patches look good and further also have zero Sashiko detected
regressions:

https://sashiko.dev/#/patchset/20261111215940.3503287-1-jorge.ramirez%40oss.qualcomm.com

So I guess, we're good. Thank you for the effort and patience.

Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>

Br, Jarkko