Linux Integrity Measurement development
 help / color / mirror / Atom feed
From: Yeoreum Yun <yeoreum.yun@arm.com>
To: Siddharth Chintamaneni <sidchintamaneni@gmail.com>
Cc: Peter Huewe <peterhuewe@gmx.de>,
	Jarkko Sakkinen <jarkko@kernel.org>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	Sudeep Holla <sudeep.holla@kernel.org>,
	Yeoreum Yun <yeoreum.yun@arm.com>,
	Stuart Yoder <stuart.yoder@arm.com>,
	apais@microsoft.com, rachelmenge@linux.microsoft.com,
	hargar@linux.microsoft.com, linux-integrity@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/4] tpm: Cache TPM2 start method
Date: Tue, 17 Nov 2026 20:23:32 +0000	[thread overview]
Message-ID: <avy3xBltfKeCs85x@e129823.arm.com> (raw)
In-Reply-To: <20261115013456.212141-2-sidchintamaneni@gmail.com>

LGTM.

Reviewed-by: Yeoreum Yun <yeoreum.yun@arm.com>

On Sun, Nov 15, 2026 at 01:34:53AM +0000, Siddharth Chintamaneni wrote:
> From: Jarkko Sakkinen <jarkko@kernel.org>
> 
> Both tpm_tis and tpm_crb retrieve the start method from the ACPI TPM2
> table during device probe, and tpm_crb_ffa also needs it before chip
> allocation.
> 
> Cache the start method in tpm2_acpi_start_method during tpm_init(), log
> it when a TPM2 ACPI table is present, and export it for the leaf
> drivers, defaulting to ACPI_TPM2_NOT_ALLOWED when the table is absent or
> invalid.
> 
> Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
> Co-developed-by: Siddharth Chintamaneni <sidchintamaneni@gmail.com>
> Signed-off-by: Siddharth Chintamaneni <sidchintamaneni@gmail.com>
> ---
>  drivers/char/tpm/tpm-interface.c | 21 +++++++++++++++++++++
>  drivers/char/tpm/tpm.h           |  1 +
>  2 files changed, 22 insertions(+)
> 
> diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm-interface.c
> index e0385b16616b..c18b060d7da2 100644
> --- a/drivers/char/tpm/tpm-interface.c
> +++ b/drivers/char/tpm/tpm-interface.c
> @@ -534,8 +534,17 @@ int tpm_get_random(struct tpm_chip *chip, u8 *out, size_t max)
>  }
>  EXPORT_SYMBOL_GPL(tpm_get_random);
>  
> +#ifdef CONFIG_ACPI
> +u32 tpm2_acpi_start_method = ACPI_TPM2_NOT_ALLOWED;
> +EXPORT_SYMBOL_GPL(tpm2_acpi_start_method);
> +#endif
> +
>  static int __init tpm_init(void)
>  {
> +#ifdef CONFIG_ACPI
> +	struct acpi_table_tpm2 *tbl;
> +	acpi_status status;
> +#endif
>  	int rc;
>  
>  	rc = class_register(&tpm_class);
> @@ -562,6 +571,18 @@ static int __init tpm_init(void)
>  		goto out_unreg_chrdev;
>  	}
>  
> +#ifdef CONFIG_ACPI
> +	if (!acpi_disabled) {
> +		status = acpi_get_table(ACPI_SIG_TPM2, 1, (typeof(tbl->header) **)&tbl);
> +		if (ACPI_SUCCESS(status)) {
> +			if (tbl->header.length >= sizeof(*tbl))
> +				tpm2_acpi_start_method = tbl->start_method;
> +			acpi_put_table((struct acpi_table_header *)tbl);
> +			pr_info("tpm: TPM2 ACPI start method: 0x%02x\n", tpm2_acpi_start_method);
> +		}
> +	}
> +#endif
> +
>  	return 0;
>  
>  out_unreg_chrdev:
> diff --git a/drivers/char/tpm/tpm.h b/drivers/char/tpm/tpm.h
> index fa554c5ad80b..212ca2410c93 100644
> --- a/drivers/char/tpm/tpm.h
> +++ b/drivers/char/tpm/tpm.h
> @@ -100,6 +100,7 @@ void tpm_sysfs_add_device(struct tpm_chip *chip);
>  
>  
>  #ifdef CONFIG_ACPI
> +extern u32 tpm2_acpi_start_method;
>  extern void tpm_add_ppi(struct tpm_chip *chip);
>  #else
>  static inline void tpm_add_ppi(struct tpm_chip *chip)
> 
> base-commit: 7e52fc165aa50e70e8df3c879d04fc0ff1673d4a
> -- 
> 2.45.4
> 

-- 
Sincerely,
Yeoreum Yun

  reply	other threads:[~2026-11-17 20:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-15  1:34 [PATCH v3 0/4] tpm: Cache ACPI TPM2 start method and gate tpm_crb_ffa probe Siddharth Chintamaneni
2026-11-15  1:34 ` [PATCH v3 1/4] tpm: Cache TPM2 start method Siddharth Chintamaneni
2026-11-17 20:23   ` Yeoreum Yun [this message]
2026-11-17 20:54     ` Jarkko Sakkinen
2026-11-15  1:34 ` [PATCH v3 2/4] tpm: tpm_crb_ffa: Only probe when ACPI TPM2 uses FF-A Siddharth Chintamaneni
2026-11-17 20:23   ` Yeoreum Yun
2026-11-15  1:34 ` [PATCH v3 3/4] tpm: tpm_tis: Use cached tpm2_acpi_start_method Siddharth Chintamaneni
2026-11-15 13:32   ` Jarkko Sakkinen
2026-11-15  1:34 ` [PATCH v3 4/4] tpm: tpm_crb: " Siddharth Chintamaneni
2026-11-17 20:24   ` Yeoreum Yun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avy3xBltfKeCs85x@e129823.arm.com \
    --to=yeoreum.yun@arm.com \
    --cc=apais@microsoft.com \
    --cc=hargar@linux.microsoft.com \
    --cc=jarkko@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterhuewe@gmx.de \
    --cc=rachelmenge@linux.microsoft.com \
    --cc=sidchintamaneni@gmail.com \
    --cc=stuart.yoder@arm.com \
    --cc=sudeep.holla@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox