From: Jarkko Sakkinen <jarkko@kernel.org>
To: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>
Cc: Amirreza Zarrabi <amirreza.zarrabi@oss.qualcomm.com>,
Jens Wiklander <jenswi@kernel.org>,
Sumit Garg <sumit.garg@kernel.org>,
Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
linux-arm-msm@vger.kernel.org, op-tee@lists.trustedfirmware.org,
linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org
Subject: Re: [PATCH v5 0/3] Add TPM support via Qualcomm TEE TPM TA
Date: Fri, 20 Nov 2026 15:01:52 +0200 [thread overview]
Message-ID: <awBEwJf3CIjTvtid@kernel.org> (raw)
In-Reply-To: <20261120-tpm_qcom_driver-v5-0-3d9321ace107@oss.qualcomm.com>
On Fri, Nov 20, 2026 at 04:23:31PM +0530, Kuldeep Singh wrote:
> Qualcomm platforms with a discrete TPM (dTPM) talked to it directly over
> a non-secure SPI channel from the kernel. Arm's Base Boot Security
> Requirements (BBSR) v1.4 require that access to go through TrustZone
> instead, so on affected Qualcomm platforms the TPM 2.0 instance is now
> fronted by a Trusted Application (TA) running inside Qualcomm's Trusted
> Execution Environment (QTEE), which talks to the dTPM (or implements an
> fTPM) on the kernel's behalf.
>
> This series adds a kernel driver for that TA, built on the QCOMTEE
> object-IPC transport (drivers/tee/qcomtee/) already used to reach other
> QTEE services.
>
> This patch series functionally depends on below(first 5 changes specially)
> for qtee service discovery.
> - https://lore.kernel.org/lkml/20261105-qcom_uefisecapp_migrate_qcomtee-v6-0-c7d68ce05c51@oss.qualcomm.com/
>
> Tested on Glymur-crd target with tpm2-tools utility.
>
> Validations:
> - Get capabilities
> - Random number generator
> - RSA key creation, encryption and decryption.
>
> Signed-off-by: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>
> ---
> Changes in v5:
> - Rebase on next-20261119.
> - Fix qcom_send_command resp_len computation(Amir)
> - Use dev_err_probe in _probe and return appropriate failures.
> - Propagate dtpm transfer/end error to callers.
> - Fix drv_data after tpmm_chip_alloc call.
> - Link to v4: https://patch.msgid.link/20261019-tpm_qcom_driver-v4-0-6889b9804ba7@oss.qualcomm.com
>
> Changes in v4:
> - Add new line before goto label(Jarkko).
> - Link to v3: https://patch.msgid.link/20261015-tpm_qcom_driver-v3-0-247c8e50250e@qti.qualcomm.com
>
> Changes in v3:
> - Merge tpm_qcom.h into tpm_qcom.c(Amir comments)
> - Update return values of functions and drop certain error prints.
> - Define locality_arg as default value.
> - Add Jarkko's tag on all but drop from 2/3 as significant changes done.
> - Link to v2: https://patch.msgid.link/20260907-tpm_qcom_driver-v2-0-71a6b1752da8@oss.qualcomm.com
>
> Changes in v2:
> - Use QCOMTEE_TPM_UID as 81 for service discovery in patch 1.
> - Use FIELD_GET, zero initialised array and log improvement (Konrad)
> - Improve commit title and other fixes (Jarkko)
> - Split MAINTAINERS entry as separate patch.
> - Link to v1: https://patch.msgid.link/20260831-tpm_qcom_driver-v1-0-6f16fa6924fa@oss.qualcomm.com
>
> To: Amirreza Zarrabi <amirreza.zarrabi@oss.qualcomm.com>
> To: Jens Wiklander <jenswi@kernel.org>
> To: Sumit Garg <sumit.garg@kernel.org>
> To: Peter Huewe <peterhuewe@gmx.de>
> To: Jarkko Sakkinen <jarkko@kernel.org>
> To: Jason Gunthorpe <jgg@ziepe.ca>
> To: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>
> Cc: linux-arm-msm@vger.kernel.org
> Cc: op-tee@lists.trustedfirmware.org
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-integrity@vger.kernel.org
>
> ---
> Kuldeep Singh (3):
> tee: qcomtee: Register qcom.tz.tpm service for discovery
> tpm: Introduce Qualcomm TPM driver
> MAINTAINERS: Add Qualcomm TPM driver entry
>
> MAINTAINERS | 6 +
> drivers/char/tpm/Kconfig | 9 +
> drivers/char/tpm/Makefile | 1 +
> drivers/char/tpm/tpm_qcom.c | 410 ++++++++++++++++++++++++++++++++++++++
> drivers/tee/qcomtee/call.c | 4 +-
> drivers/tee/qcomtee/qcomtee_msg.h | 2 +
> 6 files changed, 431 insertions(+), 1 deletion(-)
> ---
> base-commit: adcad7f4e6332cff3d6d7165f41584899f598534
> change-id: 20260831-tpm_qcom_driver-d21c720e73b2
> prerequisite-change-id: 20260408-qcom_uefisecapp_migrate_qcomtee-13869d45e014:v6
> prerequisite-patch-id: faf4520d818abf0d7533f71d9c8b9a8aade34626
> prerequisite-patch-id: b487dfe2fbc076f4815dc6c73b9e68b0b78c961f
> prerequisite-patch-id: 9f2c4ee37ba173bdc860f253d44974379f2cf125
> prerequisite-patch-id: e86905ac6289821db30fd9a17f73e276e0a88363
> prerequisite-patch-id: 09a86ee4de34e0c9cd2e4664c54a6473d7998299
> prerequisite-patch-id: a940a0624f1e130d1fe5213952965aa469bf9547
> prerequisite-patch-id: 7be993abea2ca36057d9352381a5890f50996dda
>
> Best regards,
> --
> Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>
>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
Br, Jarkko
prev parent reply other threads:[~2026-11-20 13:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 10:53 [PATCH v5 0/3] Add TPM support via Qualcomm TEE TPM TA Kuldeep Singh
2026-11-20 10:53 ` [PATCH v5 1/3] tee: qcomtee: Register qcom.tz.tpm service for discovery Kuldeep Singh
2026-11-20 10:53 ` [PATCH v5 2/3] tpm: Introduce Qualcomm TPM driver Kuldeep Singh
2026-11-20 10:53 ` [PATCH v5 3/3] MAINTAINERS: Add Qualcomm TPM driver entry Kuldeep Singh
2026-11-20 13:01 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=awBEwJf3CIjTvtid@kernel.org \
--to=jarkko@kernel.org \
--cc=amirreza.zarrabi@oss.qualcomm.com \
--cc=jenswi@kernel.org \
--cc=jgg@ziepe.ca \
--cc=kuldeep.singh@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=op-tee@lists.trustedfirmware.org \
--cc=peterhuewe@gmx.de \
--cc=sumit.garg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox