From: Vasily Gorbik <gor@linux.ibm.com>
To: Mimi Zohar <zohar@linux.ibm.com>
Cc: linux-integrity@vger.kernel.org,
Heiko Carstens <hca@linux.ibm.com>,
Alexander Egorenkov <egorenar@linux.ibm.com>,
Ard Biesheuvel <ardb@kernel.org>,
Dave Hansen <dave.hansen@intel.com>, Coiby Xu <coxu@redhat.com>,
Roberto Sassu <roberto.sassu@huawei.com>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
"Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
Eric Snowberg <eric.snowberg@oracle.com>,
Paul Moore <paul@paul-moore.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
Jarkko Sakkinen <jarkko@kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"open list:LINUX FOR POWERPC (32-BIT AND 64-BIT)"
<linuxppc-dev@lists.ozlabs.org>,
"open list:S390 ARCHITECTURE" <linux-s390@vger.kernel.org>,
"open list:EXTENSIBLE FIRMWARE INTERFACE (EFI)"
<linux-efi@vger.kernel.org>,
"open list:SECURITY SUBSYSTEM"
<linux-security-module@vger.kernel.org>,
"open list:KEYS/KEYRINGS_INTEGRITY" <keyrings@vger.kernel.org>
Subject: Re: [PATCH v3 1/3] integrity: Make arch_ima_get_secureboot integrity-wide
Date: Thu, 5 Mar 2026 13:55:04 +0100 [thread overview]
Message-ID: <c00-01.ttbfdx5@ub.hpns> (raw)
In-Reply-To: <20260213012851.2532722-2-coxu@redhat.com>
On Fri, Feb 13, 2026 at 09:28:46AM +0800, Coiby Xu wrote:
> EVM and other LSMs need the ability to query the secure boot status of
> the system, without directly calling the IMA arch_ima_get_secureboot
> function. Refactor the secure boot status check into a general function
> named arch_get_secureboot.
>
> Reported-and-suggested-by: Mimi Zohar <zohar@linux.ibm.com>
> Suggested-by: Roberto Sassu <roberto.sassu@huawei.com>
> Signed-off-by: Coiby Xu <coxu@redhat.com>
> ---
> MAINTAINERS | 1 +
> arch/powerpc/kernel/ima_arch.c | 5 --
> arch/powerpc/kernel/secure_boot.c | 6 ++
> arch/s390/kernel/ima_arch.c | 6 --
> arch/s390/kernel/ipl.c | 5 ++
> arch/x86/include/asm/efi.h | 4 +-
> arch/x86/platform/efi/efi.c | 2 +-
> include/linux/ima.h | 7 +--
> include/linux/secure_boot.h | 19 +++++++
> security/integrity/Makefile | 3 +-
> security/integrity/efi_secureboot.c | 56 +++++++++++++++++++
> security/integrity/ima/ima_appraise.c | 2 +-
> security/integrity/ima/ima_efi.c | 47 +---------------
> security/integrity/ima/ima_main.c | 3 +-
> security/integrity/integrity.h | 1 +
> security/integrity/platform_certs/load_uefi.c | 2 +-
> security/integrity/secure_boot.c | 16 ++++++
> 17 files changed, 115 insertions(+), 70 deletions(-)
> create mode 100644 include/linux/secure_boot.h
> create mode 100644 security/integrity/efi_secureboot.c
> create mode 100644 security/integrity/secure_boot.c
This triggers a warning on s390:
arch/s390/kernel/ipl.c:2507:6: warning: no previous prototype for ‘arch_get_secureboot’ [-Wmissing-prototypes]
2507 | bool arch_get_secureboot(void)
| ^~~~~~~~~~~~~~~~~~~
@Mimi: could you please squash this fixup into the offending commit,
or pick it up separately?
Vasily Gorbik (1):
s390/ipl: Fix missing arch_get_secureboot() prototype warning
arch/s390/kernel/ipl.c | 1 +
1 file changed, 1 insertion(+)
--
2.53.0
next prev parent reply other threads:[~2026-03-05 12:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-13 1:28 [PATCH v3 0/3] Make detecting the secure boot status integrity-wide Coiby Xu
2026-02-13 1:28 ` [PATCH v3 1/3] integrity: Make arch_ima_get_secureboot integrity-wide Coiby Xu
2026-03-05 12:55 ` Vasily Gorbik [this message]
2026-03-05 12:55 ` [PATCH 1/1] s390/ipl: Fix missing arch_get_secureboot() prototype warning Vasily Gorbik
2026-03-06 21:16 ` kernel test robot
2026-03-05 17:25 ` [PATCH v3 1/3] integrity: Make arch_ima_get_secureboot integrity-wide Mimi Zohar
2026-02-13 1:28 ` [PATCH v3 2/3] evm: Don't enable fix mode when secure boot is enabled Coiby Xu
2026-02-13 1:28 ` [PATCH v3 3/3] s390: Drop unnecessary CONFIG_IMA_SECURE_AND_OR_TRUSTED_BOOT Coiby Xu
2026-02-23 18:38 ` Mimi Zohar
2026-02-24 5:52 ` Alexander Egorenkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c00-01.ttbfdx5@ub.hpns \
--to=gor@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=ardb@kernel.org \
--cc=borntraeger@linux.ibm.com \
--cc=bp@alien8.de \
--cc=chleroy@kernel.org \
--cc=coxu@redhat.com \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=dmitry.kasatkin@gmail.com \
--cc=egorenar@linux.ibm.com \
--cc=eric.snowberg@oracle.com \
--cc=hca@linux.ibm.com \
--cc=hpa@zytor.com \
--cc=jarkko@kernel.org \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=paul@paul-moore.com \
--cc=roberto.sassu@huawei.com \
--cc=serge@hallyn.com \
--cc=svens@linux.ibm.com \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox