* [integrity:next-integrity-testing 3/5] security/integrity/ima/ima_asymmetric_keys.c:70:6: sparse: sparse: symbol 'ima_queue_key' was not declared. Should it be static?
@ 2019-12-25 4:54 kbuild test robot
2019-12-25 4:54 ` [RFC PATCH integrity] IMA: ima_queue_key() can be static kbuild test robot
2019-12-26 14:27 ` [integrity:next-integrity-testing 3/5] security/integrity/ima/ima_asymmetric_keys.c:70:6: sparse: sparse: symbol 'ima_queue_key' was not declared. Should it be static? Mimi Zohar
0 siblings, 2 replies; 6+ messages in thread
From: kbuild test robot @ 2019-12-25 4:54 UTC (permalink / raw)
To: Lakshmi Ramasubramanian; +Cc: kbuild-all, linux-integrity, Mimi Zohar
tree: https://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux-integrity.git next-integrity-testing
head: 11b771ffff8fc0bfc176b829d986896a7d97a44c
commit: 466a4c055a9b9efc8704591bbfa9041c77f66c46 [3/5] IMA: Define workqueue for early boot "key" measurements
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-129-g341daf20-dirty
git checkout 466a4c055a9b9efc8704591bbfa9041c77f66c46
make ARCH=x86_64 allmodconfig
make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> security/integrity/ima/ima_asymmetric_keys.c:70:6: sparse: sparse: symbol 'ima_queue_key' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
^ permalink raw reply [flat|nested] 6+ messages in thread
* [RFC PATCH integrity] IMA: ima_queue_key() can be static
2019-12-25 4:54 [integrity:next-integrity-testing 3/5] security/integrity/ima/ima_asymmetric_keys.c:70:6: sparse: sparse: symbol 'ima_queue_key' was not declared. Should it be static? kbuild test robot
@ 2019-12-25 4:54 ` kbuild test robot
2019-12-25 6:43 ` Lakshmi Ramasubramanian
2019-12-26 14:27 ` [integrity:next-integrity-testing 3/5] security/integrity/ima/ima_asymmetric_keys.c:70:6: sparse: sparse: symbol 'ima_queue_key' was not declared. Should it be static? Mimi Zohar
1 sibling, 1 reply; 6+ messages in thread
From: kbuild test robot @ 2019-12-25 4:54 UTC (permalink / raw)
To: Lakshmi Ramasubramanian; +Cc: kbuild-all, linux-integrity, Mimi Zohar
Fixes: 466a4c055a9b ("IMA: Define workqueue for early boot "key" measurements")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
ima_asymmetric_keys.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/security/integrity/ima/ima_asymmetric_keys.c b/security/integrity/ima/ima_asymmetric_keys.c
index d520a67180d89..745bb90f1604f 100644
--- a/security/integrity/ima/ima_asymmetric_keys.c
+++ b/security/integrity/ima/ima_asymmetric_keys.c
@@ -67,8 +67,8 @@ static struct ima_key_entry *ima_alloc_key_entry(
return entry;
}
-bool ima_queue_key(struct key *keyring, const void *payload,
- size_t payload_len)
+static bool ima_queue_key(struct key *keyring, const void *payload,
+ size_t payload_len)
{
bool queued = false;
struct ima_key_entry *entry;
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [RFC PATCH integrity] IMA: ima_queue_key() can be static
2019-12-25 4:54 ` [RFC PATCH integrity] IMA: ima_queue_key() can be static kbuild test robot
@ 2019-12-25 6:43 ` Lakshmi Ramasubramanian
2019-12-26 14:27 ` Mimi Zohar
0 siblings, 1 reply; 6+ messages in thread
From: Lakshmi Ramasubramanian @ 2019-12-25 6:43 UTC (permalink / raw)
To: kbuild test robot; +Cc: kbuild-all, linux-integrity, Mimi Zohar
Hi Mimi,
On 12/24/2019 8:54 PM, kbuild test robot wrote:
>
> Fixes: 466a4c055a9b ("IMA: Define workqueue for early boot "key" measurements")
> Signed-off-by: kbuild test robot <lkp@intel.com>
> ---
> ima_asymmetric_keys.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> -bool ima_queue_key(struct key *keyring, const void *payload,
> - size_t payload_len)
> +static bool ima_queue_key(struct key *keyring, const void *payload,
> + size_t payload_len)
> {
> bool queued = false;
> struct ima_key_entry *entry;
>
I'd defined ima_queue_key() as non-static when it could have been
defined as static.
From this patch I understand this change is done. Is there anything I
need to do to address this issue?
thanks,
-lakshmi
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [integrity:next-integrity-testing 3/5] security/integrity/ima/ima_asymmetric_keys.c:70:6: sparse: sparse: symbol 'ima_queue_key' was not declared. Should it be static?
2019-12-25 4:54 [integrity:next-integrity-testing 3/5] security/integrity/ima/ima_asymmetric_keys.c:70:6: sparse: sparse: symbol 'ima_queue_key' was not declared. Should it be static? kbuild test robot
2019-12-25 4:54 ` [RFC PATCH integrity] IMA: ima_queue_key() can be static kbuild test robot
@ 2019-12-26 14:27 ` Mimi Zohar
1 sibling, 0 replies; 6+ messages in thread
From: Mimi Zohar @ 2019-12-26 14:27 UTC (permalink / raw)
To: kbuild test robot, Lakshmi Ramasubramanian; +Cc: kbuild-all, linux-integrity
On Wed, 2019-12-25 at 12:54 +0800, kbuild test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux-integrity.git next-integrity-testing
> head: 11b771ffff8fc0bfc176b829d986896a7d97a44c
> commit: 466a4c055a9b9efc8704591bbfa9041c77f66c46 [3/5] IMA: Define workqueue for early boot "key" measurements
> reproduce:
> # apt-get install sparse
> # sparse version: v0.6.1-129-g341daf20-dirty
> git checkout 466a4c055a9b9efc8704591bbfa9041c77f66c46
> make ARCH=x86_64 allmodconfig
> make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
>
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
>
>
> sparse warnings: (new ones prefixed by >>)
>
> >> security/integrity/ima/ima_asymmetric_keys.c:70:6: sparse: sparse: symbol 'ima_queue_key' was not declared. Should it be static?
>
> Please review and possibly fold the followup patch.
Thank you for following next-integrity-testing branch and providing a fix.
Mimi
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC PATCH integrity] IMA: ima_queue_key() can be static
2019-12-25 6:43 ` Lakshmi Ramasubramanian
@ 2019-12-26 14:27 ` Mimi Zohar
2019-12-26 18:33 ` Lakshmi Ramasubramanian
0 siblings, 1 reply; 6+ messages in thread
From: Mimi Zohar @ 2019-12-26 14:27 UTC (permalink / raw)
To: Lakshmi Ramasubramanian, kbuild test robot; +Cc: kbuild-all, linux-integrity
On Tue, 2019-12-24 at 22:43 -0800, Lakshmi Ramasubramanian wrote:
> Hi Mimi,
>
> On 12/24/2019 8:54 PM, kbuild test robot wrote:
> >
> > Fixes: 466a4c055a9b ("IMA: Define workqueue for early boot "key" measurements")
> > Signed-off-by: kbuild test robot <lkp@intel.com>
> > ---
> > ima_asymmetric_keys.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > -bool ima_queue_key(struct key *keyring, const void *payload,
> > - size_t payload_len)
> > +static bool ima_queue_key(struct key *keyring, const void *payload,
> > + size_t payload_len)
> > {
> > bool queued = false;
> > struct ima_key_entry *entry;
> >
>
> I'd defined ima_queue_key() as non-static when it could have been
> defined as static.
>
> From this patch I understand this change is done. Is there anything I
> need to do to address this issue?
No, I'll squash this patch with the original patch, adding the
requested tags.
Mimi
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC PATCH integrity] IMA: ima_queue_key() can be static
2019-12-26 14:27 ` Mimi Zohar
@ 2019-12-26 18:33 ` Lakshmi Ramasubramanian
0 siblings, 0 replies; 6+ messages in thread
From: Lakshmi Ramasubramanian @ 2019-12-26 18:33 UTC (permalink / raw)
To: Mimi Zohar; +Cc: linux-integrity
On 12/26/2019 6:27 AM, Mimi Zohar wrote:
>>
>> From this patch I understand this change is done. Is there anything I
>> need to do to address this issue?
>
> No, I'll squash this patch with the original patch, adding the
> requested tags.
>
> Mimi
Thanks a lot for your help Mimi.
-lakshmi
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-12-26 18:33 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-25 4:54 [integrity:next-integrity-testing 3/5] security/integrity/ima/ima_asymmetric_keys.c:70:6: sparse: sparse: symbol 'ima_queue_key' was not declared. Should it be static? kbuild test robot
2019-12-25 4:54 ` [RFC PATCH integrity] IMA: ima_queue_key() can be static kbuild test robot
2019-12-25 6:43 ` Lakshmi Ramasubramanian
2019-12-26 14:27 ` Mimi Zohar
2019-12-26 18:33 ` Lakshmi Ramasubramanian
2019-12-26 14:27 ` [integrity:next-integrity-testing 3/5] security/integrity/ima/ima_asymmetric_keys.c:70:6: sparse: sparse: symbol 'ima_queue_key' was not declared. Should it be static? Mimi Zohar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).