public inbox for linux-integrity@vger.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jarkko Sakkinen <jarkko@kernel.org>,
	"M. Haener" <michael.haener@siemens.com>,
	linux-integrity@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Peter Huewe <peterhuewe@gmx.de>,
	Jason Gunthorpe <jgg@ziepe.ca>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Lukas Wunner <lukas@wunner.de>,
	Alexander Sverdlin <alexander.sverdlin@siemens.com>
Subject: Re: [PATCH 2/2] dt-bindings: tpm: Add st,st33ktpm2xi2c to TCG TIS binding
Date: Sat, 13 Apr 2024 23:48:41 +0200	[thread overview]
Message-ID: <cf4ecd86-a216-448f-bb5a-2f02e5dd8e3b@linaro.org> (raw)
In-Reply-To: <D0JBQ0A9FXUS.NH8RBK4KXXX8@kernel.org>

On 13/04/2024 23:47, Jarkko Sakkinen wrote:
> On Sat Apr 13, 2024 at 10:15 AM EEST, M. Haener wrote:
>> From: Michael Haener <michael.haener@siemens.com>
>>
>> Add the ST chip st33ktpm2xi2c to the supported compatible strings of the
>> TPM TIS I2C schema. The Chip is compliant with the TCG PC Client TPM
>> Profile specification.
>>
>> For reference, a datasheet is available at:
>> https://www.st.com/resource/en/data_brief/st33ktpm2xi2c.pdf
>>
>> Reviewed-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>
>> Signed-off-by: Michael Haener <michael.haener@siemens.com>
>> ---
>>  Documentation/devicetree/bindings/tpm/tcg,tpm-tis-i2c.yaml | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/tpm/tcg,tpm-tis-i2c.yaml b/Documentation/devicetree/bindings/tpm/tcg,tpm-tis-i2c.yaml
>> index 3ab4434b7352..af7720dc4a12 100644
>> --- a/Documentation/devicetree/bindings/tpm/tcg,tpm-tis-i2c.yaml
>> +++ b/Documentation/devicetree/bindings/tpm/tcg,tpm-tis-i2c.yaml
>> @@ -32,6 +32,7 @@ properties:
>>            - enum:
>>                - infineon,slb9673
>>                - nuvoton,npct75x
>> +              - st,st33ktpm2xi2c
>>            - const: tcg,tpm-tis-i2c
>>  
>>        - description: TPM 1.2 and 2.0 chips with vendor-specific I²C interface
> 
> Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
> 
> I'm ready to pick these unless Rob has anything to complain (hold
> to next week).

I complained and NAKed second patch.

Best regards,
Krzysztof


  reply	other threads:[~2024-04-13 21:48 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-13  7:15 [PATCH 0/2] Add ST33KTPM2XI2C chip to the TPM TIS I2C driver M. Haener
2024-04-13  7:15 ` [PATCH 1/2] tpm: tis_i2c: Add compatible string st,st33ktpm2xi2c M. Haener
2024-04-13 21:45   ` Jarkko Sakkinen
2024-04-13  7:15 ` [PATCH 2/2] dt-bindings: tpm: Add st,st33ktpm2xi2c to TCG TIS binding M. Haener
2024-04-13  8:10   ` Krzysztof Kozlowski
2024-04-13 10:18     ` Lukas Wunner
2024-04-13 10:23       ` Krzysztof Kozlowski
2024-04-13 10:34         ` Lukas Wunner
2024-04-13 10:43           ` Krzysztof Kozlowski
2024-04-13 10:51             ` Lukas Wunner
2024-04-13 10:53               ` Krzysztof Kozlowski
2024-04-13 10:56                 ` Lukas Wunner
2024-04-13 11:01                   ` Krzysztof Kozlowski
2024-04-14  5:42                     ` Haener, Michael
2024-04-14  5:52                       ` Krzysztof Kozlowski
2024-04-13 21:49     ` Jarkko Sakkinen
2024-04-13  8:38   ` Krzysztof Kozlowski
2024-04-13 20:26     ` Haener, Michael
2024-04-13 21:13       ` Krzysztof Kozlowski
2024-04-13 21:47   ` Jarkko Sakkinen
2024-04-13 21:48     ` Krzysztof Kozlowski [this message]
2024-04-13 21:50     ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cf4ecd86-a216-448f-bb5a-2f02e5dd8e3b@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=alexander.sverdlin@siemens.com \
    --cc=conor+dt@kernel.org \
    --cc=jarkko@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=michael.haener@siemens.com \
    --cc=peterhuewe@gmx.de \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox