From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it1-f177.google.com ([209.85.166.177]:51493 "EHLO mail-it1-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729071AbeJLX0y (ORCPT ); Fri, 12 Oct 2018 19:26:54 -0400 Subject: Re: [PATCH] KEYS: trusted: fix -Wvarags warning To: James Bottomley , ndesaulniers@google.com, dhowells@redhat.com Cc: natechancellor@gmail.com, ebiggers@google.com, Mimi Zohar , James Morris , "Serge E. Hallyn" , linux-integrity@vger.kernel.org, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org References: <1539274203.2623.56.camel@linux.vnet.ibm.com> <20181011203126.15338-1-ndesaulniers@google.com> <1539356751.2656.5.camel@linux.ibm.com> <1539357759.2656.7.camel@linux.ibm.com> <16de2bb3-815a-f534-4618-af854c906017@gmail.com> <1539359181.2656.13.camel@linux.ibm.com> From: Denis Kenzior Message-ID: Date: Fri, 12 Oct 2018 10:53:43 -0500 MIME-Version: 1.0 In-Reply-To: <1539359181.2656.13.camel@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Sender: linux-integrity-owner@vger.kernel.org List-ID: Hi James, >> From the links provided in the patch it seems that one cannot pass >> char/float/short to va_start(). Fair enough. So if we make h3 an >> unsigned int, the issue goes away, no? > > For the current version of clang, yes. However, if we're fixing this > for good a char * pointer is the only guaranteed thing because it > mirrors current use in printf. > All right. I guess I wasn't aware that non-printf like variadic functions are now considered harmful or of the impending crusade against them :) But in the context of this patch, can we please use something less invasive than changing all the arguments around? Promoting h3 to a bool (if possible) or int/unsigned int would get my vote. Regards, -Denis