From: Hanjun Guo <guohanjun@huawei.com>
To: Jarkko Sakkinen <jarkko@kernel.org>
Cc: <linux-integrity@vger.kernel.org>, Peter Huewe <peterhuewe@gmx.de>
Subject: Re: [PATCH 1/3] tpm: acpi: Call acpi_put_table() to fix memory leak
Date: Thu, 17 Nov 2022 17:16:33 +0800 [thread overview]
Message-ID: <e201d863-be74-e457-e893-ad8b4a37cd06@huawei.com> (raw)
In-Reply-To: <Y3QmCUux2D+9ebmp@kernel.org>
On 2022/11/16 7:51, Jarkko Sakkinen wrote:
> On Wed, Nov 09, 2022 at 12:03:40PM +0800, Hanjun Guo wrote:
>> The start and length of the event log area are obtained from
>> TPM2 or TCPA table, so we call acpi_get_table() to get the
>> ACPI information, but the acpi_get_table() should be coupled with
>> acpi_put_table() to release the ACPI memory, add the acpi_put_table()
>> properly to fix the memory leak.
>>
>> While we are at it, remove the redundant empty line at the
>> end of the tpm_read_log_acpi().
>>
>
> Please add to the commit message:
>
> Cc: stable@vger.kernel.org
>
> And cc this patch also to linux-kernel@vger.kernel.org.
OK, will update this patch set as you suggested.
Thanks
Hanjun
next prev parent reply other threads:[~2022-11-17 9:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 4:03 [PATCH 0/3] ACPI table release for TPM drivers Hanjun Guo
2022-11-09 4:03 ` [PATCH 1/3] tpm: acpi: Call acpi_put_table() to fix memory leak Hanjun Guo
2022-11-15 23:51 ` Jarkko Sakkinen
2022-11-17 9:16 ` Hanjun Guo [this message]
2022-11-09 4:03 ` [PATCH 2/3] tpm: tpm_crb: Add the missed " Hanjun Guo
2022-11-15 23:52 ` Jarkko Sakkinen
2022-11-09 4:03 ` [PATCH 3/3] tpm: tpm_tis: " Hanjun Guo
2022-11-15 23:52 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e201d863-be74-e457-e893-ad8b4a37cd06@huawei.com \
--to=guohanjun@huawei.com \
--cc=jarkko@kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).