public inbox for linux-integrity@vger.kernel.org
 help / color / mirror / Atom feed
From: Mimi Zohar <zohar@linux.ibm.com>
To: Chi Wang <wangchi05@163.com>, trivial@kernel.org
Cc: Roberto Sassu <roberto.sassu@huawei.com>,
	Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
	linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
	Chi Wang <wangchi@kylinos.cn>
Subject: Re: [PATCH] integrity: digsig: Add blank line after declarations
Date: Fri, 27 Feb 2026 13:38:20 -0500	[thread overview]
Message-ID: <fc98d328cc9d06d62cf16ddc620aadcec9c3c6ab.camel@linux.ibm.com> (raw)
In-Reply-To: <20260227062311.140597-1-wangchi05@163.com>

On Fri, 2026-02-27 at 14:23 +0800, Chi Wang wrote:
> From: Chi Wang <wangchi@kylinos.cn>
> 
> Fixes checkpatch warning:
> WARNING: Missing a blank line after declarations
> +                       int err = PTR_ERR(keyring[id]);
> +                       pr_err("no %s keyring: %d\n", keyring_name[id], err);
> 
> Add a blank line after the variable declaration to comply with
> the kernel coding style.
> 
> Signed-off-by: Chi Wang <wangchi@kylinos.cn>

Agreed checkpatch complains today, but probably not back in 2011 when the patch
was upstreamed.  Cosmetic changes are normally upstreamed only with other
changes.

thanks,

Mimi

      reply	other threads:[~2026-02-27 18:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-27  6:23 [PATCH] integrity: digsig: Add blank line after declarations Chi Wang
2026-02-27 18:38 ` Mimi Zohar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fc98d328cc9d06d62cf16ddc620aadcec9c3c6ab.camel@linux.ibm.com \
    --to=zohar@linux.ibm.com \
    --cc=dmitry.kasatkin@gmail.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roberto.sassu@huawei.com \
    --cc=trivial@kernel.org \
    --cc=wangchi05@163.com \
    --cc=wangchi@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox