* [PATCH] integrity: digsig: Add blank line after declarations
@ 2026-02-27 6:23 Chi Wang
2026-02-27 18:38 ` Mimi Zohar
0 siblings, 1 reply; 2+ messages in thread
From: Chi Wang @ 2026-02-27 6:23 UTC (permalink / raw)
To: trivial
Cc: Mimi Zohar, Roberto Sassu, Dmitry Kasatkin, linux-integrity,
linux-kernel, Chi Wang
From: Chi Wang <wangchi@kylinos.cn>
Fixes checkpatch warning:
WARNING: Missing a blank line after declarations
+ int err = PTR_ERR(keyring[id]);
+ pr_err("no %s keyring: %d\n", keyring_name[id], err);
Add a blank line after the variable declaration to comply with
the kernel coding style.
Signed-off-by: Chi Wang <wangchi@kylinos.cn>
---
security/integrity/digsig.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/security/integrity/digsig.c b/security/integrity/digsig.c
index aec350abad86..5e7ba7d3cf99 100644
--- a/security/integrity/digsig.c
+++ b/security/integrity/digsig.c
@@ -49,6 +49,7 @@ static struct key *integrity_keyring_from_id(const unsigned int id)
request_key(&key_type_keyring, keyring_name[id], NULL);
if (IS_ERR(keyring[id])) {
int err = PTR_ERR(keyring[id]);
+
pr_err("no %s keyring: %d\n", keyring_name[id], err);
keyring[id] = NULL;
return ERR_PTR(err);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] integrity: digsig: Add blank line after declarations
2026-02-27 6:23 [PATCH] integrity: digsig: Add blank line after declarations Chi Wang
@ 2026-02-27 18:38 ` Mimi Zohar
0 siblings, 0 replies; 2+ messages in thread
From: Mimi Zohar @ 2026-02-27 18:38 UTC (permalink / raw)
To: Chi Wang, trivial
Cc: Roberto Sassu, Dmitry Kasatkin, linux-integrity, linux-kernel,
Chi Wang
On Fri, 2026-02-27 at 14:23 +0800, Chi Wang wrote:
> From: Chi Wang <wangchi@kylinos.cn>
>
> Fixes checkpatch warning:
> WARNING: Missing a blank line after declarations
> + int err = PTR_ERR(keyring[id]);
> + pr_err("no %s keyring: %d\n", keyring_name[id], err);
>
> Add a blank line after the variable declaration to comply with
> the kernel coding style.
>
> Signed-off-by: Chi Wang <wangchi@kylinos.cn>
Agreed checkpatch complains today, but probably not back in 2011 when the patch
was upstreamed. Cosmetic changes are normally upstreamed only with other
changes.
thanks,
Mimi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-02-27 18:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-27 6:23 [PATCH] integrity: digsig: Add blank line after declarations Chi Wang
2026-02-27 18:38 ` Mimi Zohar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox