From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5537FC77B7E for ; Mon, 29 May 2023 15:08:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229705AbjE2PI2 convert rfc822-to-8bit (ORCPT ); Mon, 29 May 2023 11:08:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229637AbjE2PI1 (ORCPT ); Mon, 29 May 2023 11:08:27 -0400 Received: from sender4-of-o54.zoho.com (sender4-of-o54.zoho.com [136.143.188.54]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD3B79F; Mon, 29 May 2023 08:08:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685372879; cv=none; d=zohomail.com; s=zohoarc; b=PsHWBH37boivgn6l9SUGcHMBUDCneiCPydEetLZAgB4ZzXa4W2ayvWo9L++tKZL6wtMWvV3VR1oa4eGELpQisEQhFlrKfx+t3xuxe/LAZzg5l3J9qmwcxCh+L+83LeeyWJue9GfZr5HQPEi3jahuDlqqFX8C2spw+Gwz+MgG/N4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1685372879; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=DYXckkWz6vk81Z+sSLyNx7SrZW5XbG3DNStLiANmp9g=; b=dqnjpdiwSy5UAWRTWYDfZJhKunusJQ+jZ/+Wembg8tmivCytRSidFD2Vk42teEGomUbsAiDa5XsQdbt2d0vJzqblH9RPne4xyAtIRpX6LUvacbn4GlkrOT8m2Fwcg/hy91l/sDzmtHe5jpwq/r6Ksy0+4gzJfFdUYQMI6I84TyU= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass smtp.mailfrom=linux@mniewoehner.de; dmarc=pass header.from= Received: from z3r0.lan (31.187.91.190 [31.187.91.190]) by mx.zohomail.com with SMTPS id 1685372878497518.3575553410253; Mon, 29 May 2023 08:07:58 -0700 (PDT) Message-ID: Subject: Re: [linus:master] [tpm, tpm_tis] e644b2f498: RIP:acpi_safe_halt From: Michael =?ISO-8859-1?Q?Niew=F6hner?= To: Jerry Snitselaar , Lino Sanfilippo Cc: Lukas Wunner , Jarkko Sakkinen , oe-lkp@lists.linux.dev, lkp@intel.com, linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org, Philipp Rosenberger , peterz@infradead.org In-Reply-To: <6nf5n6fdnkhx6taa2mecnsmyw7sdgaz6fbvkqy7jqkyd7jq2u7@ogsi6ije32in> References: <202305041325.ae8b0c43-yujie.liu@intel.com> <42ea93a1-3186-b8ff-c317-d51f3e13856e@kunbus.com> <20230511141607.GA32208@wunner.de> <1a8ecf90-80a4-9aac-95e1-9ce0c4e09ba5@kunbus.com> <6nf5n6fdnkhx6taa2mecnsmyw7sdgaz6fbvkqy7jqkyd7jq2u7@ogsi6ije32in> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Date: Mon, 29 May 2023 17:07:54 +0200 MIME-Version: 1.0 User-Agent: Evolution 3.44.4 X-ZohoMailClient: External Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org Hi Jerry, On Thu, 2023-05-11 at 07:59 -0700, Jerry Snitselaar wrote: > > IIRC trying to catch the irq storm didn't work in the L490 case for > some reason, so we might still need the dmi entry for that one. > > The info that the T490s had a pin wired up wrong came from Lenovo, but > this one even looks to be a different vendor so I wonder how often > this happens or if there is something else going on. Is it possible to > get info about the tpm used in the Inspur system? The datasheet online > doesn't mention it. Are you sure about T490s? To me the wiring looks right on both s and non-s: Pin 18 / PIRQ# goes to PIRQA# of the PCH/SoC. However on L490 Pin 18 / PIRQ# is wired wrongly to SERIRQ, which probably is the reason that catching the interrupt storm didn't work: I guess this completely messes up LPC communication and causes way more problems. In this case only a DMI quirk can help. BR Michael > > Regards, > Jerry > > > > Thanks, > > > > > > Lukas >