From: Lu Baolu <baolu.lu@linux.intel.com>
To: Yuri Volchkov <volchkov@amazon.de>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org
Cc: bhelgaas@google.com, dwmw2@infradead.org, neugebar@amazon.co.uk
Subject: Re: [PATCH 0/2] iommu/dmar: expose fault counters via sysfs
Date: Wed, 16 Oct 2019 08:45:55 +0800 [thread overview]
Message-ID: <005c9cae-be2a-80a7-6e78-ed535160350a@linux.intel.com> (raw)
In-Reply-To: <20191015151112.17225-1-volchkov@amazon.de>
Hi,
On 10/15/19 11:11 PM, Yuri Volchkov wrote:
> For health monitoring, it can be useful to know if iommu is behaving as
> expected. DMAR faults can be an indicator that a device:
> - has been misconfigured, or
> - has experienced a hardware hiccup and replacement should
> be considered, or
> - has been issuing faults due to malicious activity
>
> Currently the only way to check if there were any DMAR faults on the
> host is to scan the dmesg output. However this approach is not very
> elegant. The information we are looking for can be wrapped out of the
> buffer, or masked (since it is a rate-limited print) by another
> device.
>
> The series adds counters for DMAR faults and exposes them via sysfs.
>
We now have an iommu API named iommu_register_fault_handler() to
register callbacks for dmar faults. How about monitoring the dmar
fault through this api so that your code could be generic and vendor
agnostic?
Best regards,
Baolu
> Yuri Volchkov (2):
> iommu/dmar: collect fault statistics
> iommu/dmar: catch early fault occurrences
>
> drivers/iommu/dmar.c | 182 ++++++++++++++++++++++++++++++++----
> drivers/iommu/intel-iommu.c | 1 +
> drivers/pci/pci-sysfs.c | 20 ++++
> include/linux/intel-iommu.h | 4 +
> include/linux/pci.h | 11 +++
> 5 files changed, 201 insertions(+), 17 deletions(-)
>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
prev parent reply other threads:[~2019-10-16 0:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 15:11 [PATCH 0/2] iommu/dmar: expose fault counters via sysfs Yuri Volchkov via iommu
2019-10-15 15:11 ` [PATCH 1/2] iommu/dmar: collect fault statistics Yuri Volchkov via iommu
2019-10-16 17:16 ` Bjorn Helgaas
2019-10-15 15:11 ` [PATCH 2/2] iommu/dmar: catch early fault occurrences Yuri Volchkov via iommu
2019-10-16 0:45 ` Lu Baolu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=005c9cae-be2a-80a7-6e78-ed535160350a@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=neugebar@amazon.co.uk \
--cc=volchkov@amazon.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox