From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42FA71381; Mon, 14 Aug 2023 02:35:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691980558; x=1723516558; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=YYBhIRGoXj26+p4KmllL+U9dko7uaqAtFc2nK/rDhX4=; b=Jbqsbqq2fJ8NHvIg2/3mzwm0k3zlA94SQTdiERAyTw/u+3IUax2rVHJJ z7ZyUTWHk8D9pZh0l4ZIOh0SMuABBK5DKI89FD2pI7b3enHfI0UtklouR T6hD7KkwrDIbHrGHahw4suwJxysZVvphJXHMkWIpJ7Y6Vd4s3FGzRSEwJ jQ/GreWNNXcYiRrqD44ABQovhOl1Qidm9lp/9VamAozDMSChmmT+I6B8o b9ChxUX8Fby7IAo4VW+jljtUW9np9zg/Pfxznpw5/4YrT7RpkzLn+aztC tPxcNtIUCr8vOWd3xOpihPGp1M0sqAjcukGdpTPf9+ivP70WcilqFlPbD g==; X-IronPort-AV: E=McAfee;i="6600,9927,10801"; a="402932183" X-IronPort-AV: E=Sophos;i="6.01,171,1684825200"; d="scan'208";a="402932183" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Aug 2023 19:35:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10801"; a="823280871" X-IronPort-AV: E=Sophos;i="6.01,171,1684825200"; d="scan'208";a="823280871" Received: from blu2-mobl.ccr.corp.intel.com (HELO [10.255.29.49]) ([10.255.29.49]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Aug 2023 19:35:46 -0700 Message-ID: <00f84867-c66d-508c-00ac-7fe062905663@linux.intel.com> Date: Mon, 14 Aug 2023 10:35:43 +0800 Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Cc: baolu.lu@linux.intel.com, Dmitry Osipenko , Marek Szyprowski , Nicolin Chen , Niklas Schnelle , Steven Price , Thierry Reding Subject: Re: [PATCH v6 05/25] iommu/fsl_pamu: Implement a PLATFORM domain Content-Language: en-US To: Jason Gunthorpe , Andy Gross , Alim Akhtar , Bjorn Andersson , AngeloGioacchino Del Regno , Baolin Wang , Christophe Leroy , Gerald Schaefer , Heiko Stuebner , iommu@lists.linux.dev, Jernej Skrabec , Jonathan Hunter , Joerg Roedel , Kevin Tian , Konrad Dybcio , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-s390@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, Russell King , linuxppc-dev@lists.ozlabs.org, Matthias Brugger , Matthew Rosato , Michael Ellerman , Nicholas Piggin , Orson Zhai , Rob Clark , Robin Murphy , Samuel Holland , Thierry Reding , Krishna Reddy , Chen-Yu Tsai , Will Deacon , Yong Wu , Chunyan Zhang References: <5-v6-e8114faedade+425-iommu_all_defdom_jgg@nvidia.com> From: Baolu Lu In-Reply-To: <5-v6-e8114faedade+425-iommu_all_defdom_jgg@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2023/8/3 8:07, Jason Gunthorpe wrote: > This driver is nonsensical. To not block migrating the core API away from > NULL default_domains give it a hacky of a PLATFORM domain that keeps it > working exactly as it always did. > > Leave some comments around to warn away any future people looking at this. > > Signed-off-by: Jason Gunthorpe > --- > drivers/iommu/fsl_pamu_domain.c | 41 ++++++++++++++++++++++++++++++--- > 1 file changed, 38 insertions(+), 3 deletions(-) Reviewed-by: Lu Baolu Best regards, baolu