From: Tianyu Lan <ltykernel@gmail.com>
To: Dave Hansen <dave.hansen@intel.com>,
Peter Zijlstra <peterz@infradead.org>
Cc: parri.andrea@gmail.com, linux-hyperv@vger.kernel.org,
brijesh.singh@amd.com, david@redhat.com, ardb@kernel.org,
dave.hansen@linux.intel.com, hpa@zytor.com, kys@microsoft.com,
will@kernel.org, boris.ostrovsky@oracle.com,
linux-arch@vger.kernel.org, wei.liu@kernel.org,
sstabellini@kernel.org, sthemmin@microsoft.com,
xen-devel@lists.xenproject.org, linux-scsi@vger.kernel.org,
aneesh.kumar@linux.ibm.com, x86@kernel.org, decui@microsoft.com,
hch@lst.de, michael.h.kelley@microsoft.com, mingo@redhat.com,
pgonda@google.com, rientjes@google.com, kuba@kernel.org,
jejb@linux.ibm.com, martin.b.radev@gmail.com,
thomas.lendacky@amd.com, Tianyu.Lan@microsoft.com,
keescook@chromium.org, arnd@arndb.de, konrad.wilk@oracle.com,
haiyangz@microsoft.com, bp@alien8.de, luto@kernel.org,
krish.sadhukhan@oracle.com, tglx@linutronix.de,
vkuznets@redhat.com, jgross@suse.com, martin.petersen@oracle.com,
saravanand@fb.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
kirill.shutemov@linux.intel.com, tj@kernel.org,
akpm@linux-foundation.org, robin.murphy@arm.com,
davem@davemloft.net, rppt@kernel.org
Subject: Re: [PATCH V2 03/14] x86/set_memory: Add x86_set_memory_enc static call support
Date: Thu, 5 Aug 2021 23:51:43 +0800 [thread overview]
Message-ID: <01d2f33c-6e50-ae88-73ff-84042504c26e@gmail.com> (raw)
In-Reply-To: <fa63e6ad-9536-d5e9-d754-fa04fad69252@intel.com>
On 8/5/2021 10:29 PM, Dave Hansen wrote:
> On 8/5/21 7:23 AM, Peter Zijlstra wrote:
>> This is assuming any of this is actually performance critical, based off
>> of this using static_call() to begin with.
>
> This code is not performance critical.
>
> I think I sent folks off on a wild goose chase when I asked that we make
> an effort to optimize code that does:
>
> if (some_hyperv_check())
> foo();
>
> if (some_amd_feature_check())
> bar();
>
> with checks that will actually compile away when Hyper-V or
> some_amd_feature() is disabled. That's less about performance and just
> about good hygiene. I *wanted* to see
> cpu_feature_enabled(X86_FEATURE...) checks.
>
> Someone suggested using static calls, and off we went...
>
> Could we please just use cpu_feature_enabled()?
>
Yes, cpu_feature_enabled() works. The target is just to run platform
code after platform check. I will update this in the next version.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2021-08-05 15:52 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 18:44 [PATCH V2 00/14] x86/Hyper-V: Add Hyper-V Isolation VM support Tianyu Lan
2021-08-04 18:44 ` [PATCH V2 01/14] x86/HV: Initialize GHCB page in Isolation VM Tianyu Lan
2021-08-04 18:44 ` [PATCH V2 02/14] x86/HV: Initialize shared memory boundary in the " Tianyu Lan
2021-08-04 18:44 ` [PATCH V2 03/14] x86/set_memory: Add x86_set_memory_enc static call support Tianyu Lan
2021-08-04 19:27 ` Dave Hansen
2021-08-05 14:05 ` Tianyu Lan
2021-08-05 14:11 ` Peter Zijlstra
2021-08-05 14:23 ` Peter Zijlstra
2021-08-05 14:29 ` Dave Hansen
2021-08-05 15:51 ` Tianyu Lan [this message]
2021-08-04 18:45 ` [PATCH V2 04/14] x86/HV: Add new hvcall guest address host visibility support Tianyu Lan
2021-08-04 18:45 ` [PATCH V2 05/14] HV: Mark vmbus ring buffer visible to host in Isolation VM Tianyu Lan
2021-08-04 18:45 ` [PATCH V2 06/14] HV: Add Write/Read MSR registers via ghcb page Tianyu Lan
2021-08-04 18:45 ` [PATCH V2 07/14] HV: Add ghcb hvcall support for SNP VM Tianyu Lan
2021-08-04 18:45 ` [PATCH V2 08/14] HV/Vmbus: Add SNP support for VMbus channel initiate message Tianyu Lan
2021-08-04 18:45 ` [PATCH V2 09/14] HV/Vmbus: Initialize VMbus ring buffer for Isolation VM Tianyu Lan
2021-08-04 18:45 ` [PATCH V2 10/14] DMA: Add dma_map_decrypted/dma_unmap_encrypted() function Tianyu Lan
2021-08-05 15:56 ` Tianyu Lan
2021-08-04 18:45 ` [PATCH V2 11/14] x86/Swiotlb: Add Swiotlb bounce buffer remap function for HV IVM Tianyu Lan
2021-08-05 16:01 ` Tianyu Lan
2021-08-04 18:45 ` [PATCH V2 12/14] HV/IOMMU: Enable swiotlb bounce buffer for Isolation VM Tianyu Lan
2021-08-04 18:45 ` [PATCH V2 13/14] HV/Netvsc: Add Isolation VM support for netvsc driver Tianyu Lan
2021-08-04 18:45 ` [PATCH V2 14/14] HV/Storvsc: Add Isolation VM support for storvsc driver Tianyu Lan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01d2f33c-6e50-ae88-73ff-84042504c26e@gmail.com \
--to=ltykernel@gmail.com \
--cc=Tianyu.Lan@microsoft.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=brijesh.singh@amd.com \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=david@redhat.com \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=hch@lst.de \
--cc=hpa@zytor.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jejb@linux.ibm.com \
--cc=jgross@suse.com \
--cc=keescook@chromium.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=konrad.wilk@oracle.com \
--cc=krish.sadhukhan@oracle.com \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=luto@kernel.org \
--cc=martin.b.radev@gmail.com \
--cc=martin.petersen@oracle.com \
--cc=michael.h.kelley@microsoft.com \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=parri.andrea@gmail.com \
--cc=peterz@infradead.org \
--cc=pgonda@google.com \
--cc=rientjes@google.com \
--cc=robin.murphy@arm.com \
--cc=rppt@kernel.org \
--cc=saravanand@fb.com \
--cc=sstabellini@kernel.org \
--cc=sthemmin@microsoft.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=tj@kernel.org \
--cc=vkuznets@redhat.com \
--cc=wei.liu@kernel.org \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox