From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30CF5C4338F for ; Tue, 17 Aug 2021 12:49:23 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE5FD6023B for ; Tue, 17 Aug 2021 12:49:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CE5FD6023B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 9BF8980B87; Tue, 17 Aug 2021 12:49:22 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dHHz-gFlMlu3; Tue, 17 Aug 2021 12:49:18 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id 68C7680B0C; Tue, 17 Aug 2021 12:49:18 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 3DE2EC001A; Tue, 17 Aug 2021 12:49:18 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 6E64DC000E for ; Tue, 17 Aug 2021 12:49:17 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 4AE75607F2 for ; Tue, 17 Aug 2021 12:49:17 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bXA_G1kz_j4O for ; Tue, 17 Aug 2021 12:49:16 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by smtp3.osuosl.org (Postfix) with ESMTPS id C225E607E2 for ; Tue, 17 Aug 2021 12:49:16 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10078"; a="277099219" X-IronPort-AV: E=Sophos;i="5.84,328,1620716400"; d="scan'208";a="277099219" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Aug 2021 05:49:15 -0700 X-IronPort-AV: E=Sophos;i="5.84,328,1620716400"; d="scan'208";a="520459403" Received: from blu2-mobl3.ccr.corp.intel.com (HELO [10.254.211.252]) ([10.254.211.252]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Aug 2021 05:49:14 -0700 Subject: Re: [PATCH v1 3/3] iommu/vt-d: Fix Unexpected page request in Privilege Mode To: Liu Yi L , iommu@lists.linux-foundation.org References: <20210817042425.1784279-1-yi.l.liu@intel.com> <20210817042425.1784279-4-yi.l.liu@intel.com> From: Lu Baolu Message-ID: <03b53572-5e51-28f6-8cd6-8f516bbfc1a6@linux.intel.com> Date: Tue, 17 Aug 2021 20:49:12 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210817042425.1784279-4-yi.l.liu@intel.com> Content-Language: en-US Cc: yi.y.sun@intel.com, jun.j.tian@intel.com X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On 2021/8/17 12:24, Liu Yi L wrote: > This patch fixes the below error. This is due to improper iotlb invalidation > in intel_pasid_tear_down_entry(). > > [ 180.187556] Unexpected page request in Privilege Mode > [ 180.187565] Unexpected page request in Privilege Mode > [ 180.279933] Unexpected page request in Privilege Mode > [ 180.279937] Unexpected page request in Privilege Mode > > Per chapter 6.5.3.3 of VT-d spec 3.3, when tear down a pasid entry, software > should use Domain selective IOTLB flush if the PGTT of the pasid entry is > SL only or Nested, while for the pasid entries whose PGTT is FL only or PT > using PASID-based IOTLB flush is enough. > > Fixes: 1c4f88b7f1f9 ("iommu/vt-d: Shared virtual address in scalable mode") > Cc: Lu Baolu > Signed-off-by: Kumar Sanjay K > Signed-off-by: Liu Yi L > Tested-by: Yi Sun Good catch! Thanks! It has been queued for iommu/fix. Best regards, baolu _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu