From: Nadav Amit <nadav.amit@gmail.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: iommu@lists.linux-foundation.org, Will Deacon <will@kernel.org>,
Jiajun Cao <caojiajun@vmware.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] iommu/amd: Fix wrong parentheses on page-specific invalidations
Date: Mon, 31 May 2021 13:11:44 -0700 [thread overview]
Message-ID: <0CD8AE55-ACE2-4647-B88B-BD8CFB8EF710@gmail.com> (raw)
In-Reply-To: <YKOHmQcqW0bX59nV@8bytes.org>
[-- Attachment #1.1: Type: text/plain, Size: 1386 bytes --]
> On May 18, 2021, at 2:23 AM, Joerg Roedel <joro@8bytes.org> wrote:
>
> On Sat, May 01, 2021 at 11:59:56PM -0700, Nadav Amit wrote:
>> From: Nadav Amit <namit@vmware.com>
>>
>> The logic to determine the mask of page-specific invalidations was
>> tested in userspace. As the code was copied into the kernel, the
>> parentheses were mistakenly set in the wrong place, resulting in the
>> wrong mask.
>>
>> Fix it.
>>
>> Cc: Joerg Roedel <joro@8bytes.org>
>> Cc: Will Deacon <will@kernel.org>
>> Cc: Jiajun Cao <caojiajun@vmware.com>
>> Cc: iommu@lists.linux-foundation.org
>> Cc: linux-kernel@vger.kernel.org
>> Fixes: 268aa4548277 ("iommu/amd: Page-specific invalidations for more than one page")
>> Signed-off-by: Nadav Amit <namit@vmware.com>
>> ---
>> drivers/iommu/amd/iommu.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Applied this one for v5.13, thanks Nadav.
>
> Somehow the rest of the patch-set got screwed up during sending or so,
> at least I see some patches twice in my inbox and with different
> subjects.
>
> Can you please re-send patches 2-4 when -rc3 it out?
Joerg,
Thanks for your understanding. I sent a version based on -rc3 a week
ago.
I noticed that there was some confusion regarding rc numbers. Do you
need a new version based on rc4 or can you apply the version I sent?
Thanks,
Nadav
[-- Attachment #1.2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 156 bytes --]
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2021-05-31 20:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-02 6:59 [PATCH 0/4] iommu/amd: Enable page-selective flushes Nadav Amit
2021-05-02 6:59 ` [PATCH 1/4] iommu/amd: Fix wrong parentheses on page-specific invalidations Nadav Amit
2021-05-18 9:23 ` Joerg Roedel
2021-05-31 20:11 ` Nadav Amit [this message]
2021-05-02 6:59 ` [PATCH 2/4] iommu/amd: Do not sync on page size changes Nadav Amit
2021-05-02 6:59 ` [PATCH 2/4] iommu/amd: Selective flush on unmap Nadav Amit
2021-05-02 6:59 ` [PATCH 3/4] iommu/amd: Do not sync on page size changes Nadav Amit
2021-06-01 15:59 ` Robin Murphy
2021-06-01 16:39 ` Nadav Amit
2021-06-01 17:27 ` Robin Murphy
2021-06-01 18:56 ` Nadav Amit
2021-05-02 7:00 ` [PATCH 3/4] iommu/amd: Selective flush on unmap Nadav Amit
2021-05-02 7:00 ` [PATCH 4/4] iommu/amd: Do not use flush-queue when NpCache is on Nadav Amit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0CD8AE55-ACE2-4647-B88B-BD8CFB8EF710@gmail.com \
--to=nadav.amit@gmail.com \
--cc=caojiajun@vmware.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox