From: Jon Hunter via iommu <iommu@lists.linux-foundation.org>
To: Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-tegra@vger.kernel.org, iommu@lists.linux-foundation.org,
thierry.reding@gmail.com, vdumpa@nvidia.com,
Ashish Mhetre <amhetre@nvidia.com>,
joro@8bytes.org, robin.murphy@arm.com,
linux-kernel@vger.kernel.org
Cc: catalin.marinas@arm.com, Snikam@nvidia.com,
kernel-team@android.com,
Pritesh Raithatha <praithatha@nvidia.com>
Subject: Re: [Patch v2] iommu: arm-smmu: disable large page mappings for Nvidia arm-smmu
Date: Tue, 26 Apr 2022 08:30:25 +0100 [thread overview]
Message-ID: <0a33c287-3394-c3df-9bee-ef13fe3417e4@nvidia.com> (raw)
In-Reply-To: <165053012237.502660.4418683392126519698.b4-ty@kernel.org>
Hi Will,
On 22/04/2022 11:55, Will Deacon wrote:
> On Thu, 21 Apr 2022 13:45:04 +0530, Ashish Mhetre wrote:
>> Tegra194 and Tegra234 SoCs have the erratum that causes walk cache
>> entries to not be invalidated correctly. The problem is that the walk
>> cache index generated for IOVA is not same across translation and
>> invalidation requests. This is leading to page faults when PMD entry is
>> released during unmap and populated with new PTE table during subsequent
>> map request. Disabling large page mappings avoids the release of PMD
>> entry and avoid translations seeing stale PMD entry in walk cache.
>> Fix this by limiting the page mappings to PAGE_SIZE for Tegra194 and
>> Tegra234 devices. This is recommended fix from Tegra hardware design
>> team.
>>
>> [...]
>
> Applied to will (for-joerg/arm-smmu/fixes), thanks!
>
> [1/1] iommu: arm-smmu: disable large page mappings for Nvidia arm-smmu
> https://git.kernel.org/will/c/4a25f2ea0e03
>
Thanks for applying. Sorry to be late to the party, but feel free
to add my ...
Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
Also any chance we could tag for stable? Probably the most
appropriate fixes-tag would be ...
Fixes: aab5a1c88276 ("iommu/arm-smmu: add NVIDIA implementation for ARM MMU-500 usage")
Thanks!
Jon
--
nvpublic
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
prev parent reply other threads:[~2022-04-26 7:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 8:15 [Patch v2] iommu: arm-smmu: disable large page mappings for Nvidia arm-smmu Ashish Mhetre via iommu
2022-04-21 11:49 ` Robin Murphy
2022-04-21 16:34 ` Krishna Reddy via iommu
2022-04-22 10:55 ` Will Deacon
2022-04-26 7:30 ` Jon Hunter via iommu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a33c287-3394-c3df-9bee-ef13fe3417e4@nvidia.com \
--to=iommu@lists.linux-foundation.org \
--cc=Snikam@nvidia.com \
--cc=amhetre@nvidia.com \
--cc=catalin.marinas@arm.com \
--cc=jonathanh@nvidia.com \
--cc=joro@8bytes.org \
--cc=kernel-team@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=praithatha@nvidia.com \
--cc=robin.murphy@arm.com \
--cc=thierry.reding@gmail.com \
--cc=vdumpa@nvidia.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox