From: Vasant Hegde via iommu <iommu@lists.linux-foundation.org>
To: Dan Carpenter <dan.carpenter@oracle.com>, suravee.suthikulpanit@amd.com
Cc: iommu@lists.linux-foundation.org
Subject: Re: [bug report] iommu/amd: Improve error handling for amd_iommu_init_pci
Date: Wed, 9 Mar 2022 14:02:20 +0530 [thread overview]
Message-ID: <0ac7bc78-a6db-d301-cd95-88fb69cb33f4@amd.com> (raw)
In-Reply-To: <20220309071122.GA24681@kili>
On 3/9/2022 12:41 PM, Dan Carpenter wrote:
> Hello Suravee Suthikulpanit,
Dan,
Thanks for the bug report.
.../...
>
> 1979 pr_err("IOMMU: Failed to initialize IOMMU-API interface (error=%d)!\n",
> 1980 ret);
> 1981 goto out;
> 1982 }
> 1983
> 1984 init_device_table_dma();
> 1985
> 1986 for_each_iommu(iommu)
> 1987 iommu_flush_all_caches(iommu);
> 1988
> --> 1989 if (!ret)
>
> Where before we just checked for errors here. This condition is
> impossible now.
We missed to remove this check. We will send fix patch.
-Vasant
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
prev parent reply other threads:[~2022-03-09 8:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-09 7:11 [bug report] iommu/amd: Improve error handling for amd_iommu_init_pci Dan Carpenter
2022-03-09 8:32 ` Vasant Hegde via iommu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ac7bc78-a6db-d301-cd95-88fb69cb33f4@amd.com \
--to=iommu@lists.linux-foundation.org \
--cc=dan.carpenter@oracle.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=vasant.hegde@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox