From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Philippe Brucker Subject: Re: [PATCH v5 5/7] iommu: Add virtio-iommu driver Date: Tue, 27 Nov 2018 17:58:18 +0000 Message-ID: <0fed79f3-ca2e-b539-74f5-cd2a8091f65d@arm.com> References: <20181122193801.50510-1-jean-philippe.brucker@arm.com> <20181122193801.50510-6-jean-philippe.brucker@arm.com> <20181123164716-mutt-send-email-mst@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: In-Reply-To: <20181123164716-mutt-send-email-mst@kernel.org> Content-Language: en-US To: "Michael S. Tsirkin" Cc: "iommu@lists.linux-foundation.org" , "linux-pci@vger.kernel.org" , "devicetree@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , "virtio-dev@lists.oasis-open.org" , "joro@8bytes.org" , Mark Rutland , Lorenzo Pieralisi , "tnowicki@caviumnetworks.com" , Marc Zyngier , Robin Murphy , Will Deacon , "eric.auger@redhat.com" , "robh+dt@kernel.org" , "bhelgaas@google.com" , "kvmarm@lists.cs.columbia.edu" List-Id: iommu@lists.linux-foundation.org On 23/11/2018 21:48, Michael S. Tsirkin wrote: >> +struct virtio_iommu_config { >> + /* Supported page sizes */ >> + __u64 page_size_mask; >> + /* Supported IOVA range */ >> + struct virtio_iommu_range input_range; >> + /* Max domain ID size */ >> + __u8 domain_bits; >> + __u8 padding[3]; > > Not enough padding here it seems. Structure is 8 byte > aligned on 64 bit systems. The next field (probe_size) is 4 bytes, so the alignment ends up fine. That field is introduced in patch 6, maybe I should move it here? Thanks, Jean