From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D91C9748D for ; Mon, 14 Nov 2022 16:57:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668445072; x=1699981072; h=message-id:date:mime-version:subject:to:references:from: in-reply-to:content-transfer-encoding; bh=1yAuHjiGqTYi1byh38jC/erNusV9XXEVsRIKu4bAuk0=; b=UeK2rCe9pqIgWmsweLKE/jfq0jvGPlXRJcGut1NUbdmHEqJKv0rXXAuU XDgxuW8aWXZJhH6KSeYnf5h+V36aTSwcf3MeifslOW2QjUYu4WvQIBBZr c92zdtgj77sXdKAeHhFwUNaK7MkpzkfhI/5kwxSGzKYnaKtgmGcgmhDre 0ctktuHPeZd29Trf1cg9Y7mdQkW3jgTg6xr3I6hbvXhMaIeEM2rgLjo/Y 1ab3mAfEfMk26u14yMN9bIY6GdzUXeJhoBRf7er1Rk3K+XrCuZ/IqvgFR b2AGTdVTFSeNT865Dh9gV3Hyv1AOe1U5U/caryRpHUUeyEobonEVEwXHn g==; X-IronPort-AV: E=McAfee;i="6500,9779,10531"; a="374149377" X-IronPort-AV: E=Sophos;i="5.96,164,1665471600"; d="scan'208";a="374149377" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Nov 2022 08:57:52 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10531"; a="669729848" X-IronPort-AV: E=Sophos;i="5.96,164,1665471600"; d="scan'208";a="669729848" Received: from satyanay-mobl1.amr.corp.intel.com (HELO [10.209.114.162]) ([10.209.114.162]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Nov 2022 08:57:50 -0800 Message-ID: <10a4eb94-4764-717b-7c20-64a3d895b3d1@intel.com> Date: Mon, 14 Nov 2022 08:57:49 -0800 Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v2 01/12] x86/ioremap: Fix page aligned size calculation in __ioremap_caller() Content-Language: en-US To: "Michael Kelley (LINUX)" , "hpa@zytor.com" , KY Srinivasan , Haiyang Zhang , "wei.liu@kernel.org" , Dexuan Cui , "luto@kernel.org" , "peterz@infradead.org" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "lpieralisi@kernel.org" , "robh@kernel.org" , "kw@linux.com" , "bhelgaas@google.com" , "arnd@arndb.de" , "hch@infradead.org" , "m.szyprowski@samsung.com" , "robin.murphy@arm.com" , "thomas.lendacky@amd.com" , "brijesh.singh@amd.com" , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "dave.hansen@linux.intel.com" , Tianyu Lan , "kirill.shutemov@linux.intel.com" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "ak@linux.intel.com" , "isaku.yamahata@intel.com" , "Williams, Dan J" , "jane.chu@oracle.com" , "seanjc@google.com" , "tony.luck@intel.com" , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-pci@vger.kernel.org" , "linux-arch@vger.kernel.org" , "iommu@lists.linux.dev" References: <1668147701-4583-1-git-send-email-mikelley@microsoft.com> <1668147701-4583-2-git-send-email-mikelley@microsoft.com> From: Dave Hansen In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/14/22 08:53, Michael Kelley (LINUX) wrote: >> Because, first of all, that "Mappings have to be page-aligned" thing is >> (now) doing more than page-aligning things. Second, the moment you mask >> out the metadata bits, the 'size' calculation gets harder. Doing it in >> two phases (page alignment followed by metadata bit masking) breaks up >> the two logical operations. >> > Work for me. Will do this in v3. Kirill also made a good point about TDX: it isn't affected by this because it always passes *real* (no metadata bits set) physical addresses in here. Could you double check that you don't want to do the same for your code?