From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 868D5C433EF for ; Mon, 10 Jan 2022 11:43:54 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 2B3DD405DE; Mon, 10 Jan 2022 11:43:54 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id E4jvtfmpdr0Z; Mon, 10 Jan 2022 11:43:53 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp2.osuosl.org (Postfix) with ESMTPS id DD313401F2; Mon, 10 Jan 2022 11:43:52 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id A6B1AC002F; Mon, 10 Jan 2022 11:43:52 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 8C204C001E for ; Mon, 10 Jan 2022 11:43:51 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 77BDF40562 for ; Mon, 10 Jan 2022 11:43:51 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id V-hdvPZ3ZFNK for ; Mon, 10 Jan 2022 11:43:50 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by smtp2.osuosl.org (Postfix) with ESMTPS id AB6D1401F2 for ; Mon, 10 Jan 2022 11:43:50 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 820AD1F41050 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1641815029; bh=uuV0Epzk3gnedbGM5nYSmM92AIVHPp2psXKWjNKXehw=; h=Subject:To:References:From:Date:In-Reply-To:From; b=WREfHH3VNKZ3seg60JNQO3Fi3Dk/N7tcQ33MIfJeskUq2VJAqGKk7Udgz2sEjQp3i 2e80eQSixi7eeAV7Z3NXxPVYylvhsRvqbKuPqa0kUNUmu1EaUr6zhIr7+a781648fM aPvHxOL7meGaspCUQ6woaS8+t74/0YJ40zPraeA1IIhSwNsXO8IcFS9jery6X4QaLi uG1Vo3JZ8TysSP1YaDmpUyWSlcUYSS6V5K6u8v/Eqwt/B+gasmiKhbD3B7k/IX2GhP H2kj3+sN9R20jQnWhJ91HGAX9m/pUlEs7W2zp6XBkzfnjV7VtTkXwSgEZx795Ii7nT JDU+TlY+gNUXQ== Subject: Re: [PATCH v2 3/5] iommu/mediatek: Remove the power status checking in tlb flush all To: Dafna Hirschfeld , iommu@lists.linux-foundation.org, Yong Wu , Joerg Roedel , Will Deacon , Matthias Brugger , "moderated list:MEDIATEK IOMMU DRIVER" , "moderated list:ARM/Mediatek SoC support" , open list , kernel@collabora.com, linux-media@vger.kernel.org, sebastian.reichel@collabora.com References: <20211208120744.2415-1-dafna.hirschfeld@collabora.com> <20211208120744.2415-4-dafna.hirschfeld@collabora.com> From: AngeloGioacchino Del Regno Message-ID: <10ca4eae-2959-a697-6818-308e04f88e14@collabora.com> Date: Mon, 10 Jan 2022 12:43:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211208120744.2415-4-dafna.hirschfeld@collabora.com> Content-Language: en-US X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" Il 08/12/21 13:07, Dafna Hirschfeld ha scritto: > From: Yong Wu > > To simplify the code, Remove the power status checking in the > tlb_flush_all, remove this: > if (pm_runtime_get_if_in_use(data->dev) <= 0) > continue; > > The mtk_iommu_tlb_flush_all is called from > a) isr > b) tlb flush range fail case > c) iommu_create_device_direct_mappings > > In first two cases, the power and clock are always enabled. > In the third case tlb flush is unnecessary because in a later patch > in the series a full flush from the pm_runtime_resume callback is added. > > In addition, writing the tlb control register when the iommu is not resumed > is ok and the write is ignored. > > Signed-off-by: Yong Wu > [refactor commit log] > Signed-off-by: Dafna Hirschfeld Reviewed-by: AngeloGioacchino Del Regno _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu