Re: [PATCH v6 09/17] iommu: Introduce iommu_group_mutex_assert()

[Vasant Hegde <vasant.hegde@amd.com>]

On 2/1/2024 10:56 PM, Jason Gunthorpe wrote:
> On Thu, Jan 25, 2024 at 12:11:27PM +0000, Vasant Hegde wrote:
>> Add function to check iommu group mutex lock. So that device drivers can
>> rely on group mutex lock instead of adding another driver level lock
>> before modifying driver specific device data structure.
>>
>> Suggested-by: Jason Gunthorpe <jgg@nvidia.com>
>> Signed-off-by: Vasant Hegde <vasant.hegde@amd.com>
>> ---
>>  drivers/iommu/iommu.c | 19 +++++++++++++++++++
>>  include/linux/iommu.h |  8 ++++++++
>>  2 files changed, 27 insertions(+)
> 
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
> 
>> +#if IS_ENABLED(CONFIG_LOCKDEP) && IS_ENABLED(CONFIG_IOMMU_API)
>> +extern void iommu_group_mutex_assert(struct device *dev);
> 
> The extern is not necessary, there is a general shift away from using
> it, not a reason for a v7, but FYI

Right. Fixed in v7.

-Vasant