From: Ritesh Harjani <ritesh.harjani-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org,
m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org
Cc: mp.vikram-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
catalin.marinas-5wv7dgnIgG8@public.gmane.org,
Will.Deacon-5wv7dgnIgG8@public.gmane.org,
menon.vinayak-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
rmk-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org
Subject: [PATCH] arm: dma-mapping: Fix mapping size value
Date: Mon, 21 Apr 2014 12:17:27 +0530 [thread overview]
Message-ID: <1398062847-5770-2-git-send-email-ritesh.harjani@gmail.com> (raw)
In-Reply-To: <1398062847-5770-1-git-send-email-ritesh.harjani-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
68efd7d2fb("arm: dma-mapping: remove order parameter from
arm_iommu_create_mapping()") is causing kernel panic
because it wrongly sets the value of mapping->size:
Unable to handle kernel NULL pointer dereference at virtual
address 000000a0
pgd = e7a84000
[000000a0] *pgd=00000000
...
PC is at bitmap_clear+0x48/0xd0
LR is at __iommu_remove_mapping+0x130/0x164
Fix it by correcting mapping->size value.
Signed-off-by: Ritesh Harjani <ritesh.harjani-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Acked-by: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
---
arch/arm/mm/dma-mapping.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c
index f62aa06..6b00be1 100644
--- a/arch/arm/mm/dma-mapping.c
+++ b/arch/arm/mm/dma-mapping.c
@@ -1963,8 +1963,8 @@ arm_iommu_create_mapping(struct bus_type *bus, dma_addr_t base, size_t size)
mapping->nr_bitmaps = 1;
mapping->extensions = extensions;
mapping->base = base;
- mapping->size = bitmap_size << PAGE_SHIFT;
mapping->bits = BITS_PER_BYTE * bitmap_size;
+ mapping->size = mapping->bits << PAGE_SHIFT;
spin_lock_init(&mapping->lock);
--
1.8.1.3
next prev parent reply other threads:[~2014-04-21 6:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-21 6:47 [PATCH RESEND] arm: dma-mapping: Fix mapping size value Ritesh Harjani
[not found] ` <1398062847-5770-1-git-send-email-ritesh.harjani-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-04-21 6:47 ` Ritesh Harjani [this message]
[not found] ` <1398062847-5770-2-git-send-email-ritesh.harjani-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-04-22 8:53 ` [PATCH] " Will Deacon
[not found] ` <20140422085307.GB5747-5wv7dgnIgG8@public.gmane.org>
2014-04-23 8:53 ` Marek Szyprowski
[not found] ` <53577F84.1080101-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-04-23 9:30 ` Laurent Pinchart
2014-04-23 10:04 ` Ritesh Harjani
[not found] ` <CAD15agYETzLJZ26wh8c=+PCSoQ9dR9vLgg7VmZTnQquXxoW+2Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-04-23 13:17 ` Marek Szyprowski
[not found] ` <5357BD77.3060908-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-04-23 13:22 ` Ritesh Harjani
2014-04-22 9:09 ` Marek Szyprowski
-- strict thread matches above, loose matches on Subject: below --
2014-04-21 4:01 Ritesh Harjani
[not found] ` <CAD15agZwxTQOBZtJCmAkbBW6hXGfRgedSc_Fi_-nHOE5MeAjTw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-04-21 9:53 ` Laurent Pinchart
2014-04-21 12:25 ` Laurent Pinchart
2014-04-19 11:19 Ritesh Harjani
[not found] ` <CAD15aga8DTuzYrPfHF3X=ZvCuCQxfx1nOTk90DdwdxeZvV5tdA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-04-19 11:25 ` Ritesh Harjani
[not found] ` <CAD15agbgOhK2b4WaWM4g45iiT7yH8HPYu=GmsOs7BkCnVvjcsw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-04-20 22:36 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398062847-5770-2-git-send-email-ritesh.harjani@gmail.com \
--to=ritesh.harjani-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=Will.Deacon-5wv7dgnIgG8@public.gmane.org \
--cc=catalin.marinas-5wv7dgnIgG8@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=menon.vinayak-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=mp.vikram-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=rmk-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).