From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Williamson Subject: Re: [RFC PATCH v6 02/20] iommu: add capability IOMMU_CAP_NOEXEC Date: Thu, 05 Jun 2014 14:03:47 -0600 Message-ID: <1401998627.9207.227.camel@ul30vt.home> References: <1401987808-23596-1-git-send-email-a.motakis@virtualopensystems.com> <1401987808-23596-3-git-send-email-a.motakis@virtualopensystems.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1401987808-23596-3-git-send-email-a.motakis-lrHrjnjw1UfHK3s98zE1ajGjJy/sRE9J@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Antonios Motakis Cc: Shuah Khan , kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, eric.auger-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, Alexey Kardashevskiy , open list , will.deacon-5wv7dgnIgG8@public.gmane.org, a.rigo-lrHrjnjw1UfHK3s98zE1ajGjJy/sRE9J@public.gmane.org, stuart.yoder-KZfg59tc24xl57MIdRCFDg@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Varun Sethi , tech-lrHrjnjw1UfHK3s98zE1ajGjJy/sRE9J@public.gmane.org, kvmarm-FPEHb7Xf0XXUo1n7N8X6UoWGPAHP3yOg@public.gmane.org, christoffer.dall-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org List-Id: iommu@lists.linux-foundation.org On Thu, 2014-06-05 at 19:03 +0200, Antonios Motakis wrote: > Some IOMMUs accept an IOMMU_NOEXEC protection flag in addition to > IOMMU_READ and IOMMU_WRITE. Expose this as an IOMMU capability. > > Signed-off-by: Antonios Motakis > --- > include/linux/iommu.h | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/include/linux/iommu.h b/include/linux/iommu.h > index fc464d2..7e152fb 100644 > --- a/include/linux/iommu.h > +++ b/include/linux/iommu.h > @@ -57,8 +57,9 @@ struct iommu_domain { > struct iommu_domain_geometry geometry; > }; > > -#define IOMMU_CAP_CACHE_COHERENCY 0x1 > -#define IOMMU_CAP_INTR_REMAP 0x2 /* isolates device intrs */ > +#define IOMMU_CAP_CACHE_COHERENCY (1 << 0) > +#define IOMMU_CAP_INTR_REMAP (1 << 1) /* isolates device intrs */ > +#define IOMMU_CAP_NOEXEC (1 << 2) /* IOMMU_NOEXEC flag */ > > /* > * Following constraints are specifc to FSL_PAMUV1: Hmm, was this really intended to be a bitmap? Why? Thanks, Alex