iommu.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] iommu/ipmmu-vmsa: Return proper error if devm_request_irq fails
@ 2014-11-01  3:45 Axel Lin
  2014-11-01 22:42 ` Laurent Pinchart
  0 siblings, 1 reply; 3+ messages in thread
From: Axel Lin @ 2014-11-01  3:45 UTC (permalink / raw)
  To: Joerg Roedel
  Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA,
	Laurent Pinchart

Signed-off-by: Axel Lin <axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>
---
 drivers/iommu/ipmmu-vmsa.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iommu/ipmmu-vmsa.c b/drivers/iommu/ipmmu-vmsa.c
index 7dab5cb..d25fa12 100644
--- a/drivers/iommu/ipmmu-vmsa.c
+++ b/drivers/iommu/ipmmu-vmsa.c
@@ -1184,7 +1184,7 @@ static int ipmmu_probe(struct platform_device *pdev)
 			       dev_name(&pdev->dev), mmu);
 	if (ret < 0) {
 		dev_err(&pdev->dev, "failed to request IRQ %d\n", irq);
-		return irq;
+		return ret;
 	}
 
 	ipmmu_device_reset(mmu);
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] iommu/ipmmu-vmsa: Return proper error if devm_request_irq fails
  2014-11-01  3:45 [PATCH] iommu/ipmmu-vmsa: Return proper error if devm_request_irq fails Axel Lin
@ 2014-11-01 22:42 ` Laurent Pinchart
  2014-11-04 14:09   ` Joerg Roedel
  0 siblings, 1 reply; 3+ messages in thread
From: Laurent Pinchart @ 2014-11-01 22:42 UTC (permalink / raw)
  To: Axel Lin, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA

Hi Axel,

Thank you for the patch.

On Saturday 01 November 2014 11:45:32 Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>

Acked-by: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>

Joerg, could you please pick this patch up ?

> ---
>  drivers/iommu/ipmmu-vmsa.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iommu/ipmmu-vmsa.c b/drivers/iommu/ipmmu-vmsa.c
> index 7dab5cb..d25fa12 100644
> --- a/drivers/iommu/ipmmu-vmsa.c
> +++ b/drivers/iommu/ipmmu-vmsa.c
> @@ -1184,7 +1184,7 @@ static int ipmmu_probe(struct platform_device *pdev)
>  			       dev_name(&pdev->dev), mmu);
>  	if (ret < 0) {
>  		dev_err(&pdev->dev, "failed to request IRQ %d\n", irq);
> -		return irq;
> +		return ret;
>  	}
> 
>  	ipmmu_device_reset(mmu);

-- 
Regards,

Laurent Pinchart

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] iommu/ipmmu-vmsa: Return proper error if devm_request_irq fails
  2014-11-01 22:42 ` Laurent Pinchart
@ 2014-11-04 14:09   ` Joerg Roedel
  0 siblings, 0 replies; 3+ messages in thread
From: Joerg Roedel @ 2014-11-04 14:09 UTC (permalink / raw)
  To: Laurent Pinchart
  Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA, Axel Lin

On Sun, Nov 02, 2014 at 12:42:15AM +0200, Laurent Pinchart wrote:
> Hi Axel,
> 
> Thank you for the patch.
> 
> On Saturday 01 November 2014 11:45:32 Axel Lin wrote:
> > Signed-off-by: Axel Lin <axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>
> 
> Acked-by: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
> 
> Joerg, could you please pick this patch up ?

Applied to arm/renesas, thanks guys.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-11-04 14:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-01  3:45 [PATCH] iommu/ipmmu-vmsa: Return proper error if devm_request_irq fails Axel Lin
2014-11-01 22:42 ` Laurent Pinchart
2014-11-04 14:09   ` Joerg Roedel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).