From: Emil Medve <Emilian.Medve-eDlz3WWmN0ll57MIdRCFDg@public.gmane.org>
To: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org,
jroedel-l3A5Bk7waGM@public.gmane.org,
Varun.Sethi-eDlz3WWmN0ll57MIdRCFDg@public.gmane.org
Cc: Emil Medve <Emilian.Medve-eDlz3WWmN0ll57MIdRCFDg@public.gmane.org>
Subject: [PATCH 16/26] iommu/fsl: Use a device pointer to make lines shorter
Date: Wed, 28 Jan 2015 08:34:48 -0600 [thread overview]
Message-ID: <1422455698-3074-17-git-send-email-Emilian.Medve@Freescale.com> (raw)
In-Reply-To: <1422455698-3074-1-git-send-email-Emilian.Medve-eDlz3WWmN0ll57MIdRCFDg@public.gmane.org>
Signed-off-by: Emil Medve <Emilian.Medve-eDlz3WWmN0ll57MIdRCFDg@public.gmane.org>
---
drivers/iommu/fsl_pamu.c | 39 ++++++++++++++++++---------------------
1 file changed, 18 insertions(+), 21 deletions(-)
diff --git a/drivers/iommu/fsl_pamu.c b/drivers/iommu/fsl_pamu.c
index 18a604a..22b72e2 100644
--- a/drivers/iommu/fsl_pamu.c
+++ b/drivers/iommu/fsl_pamu.c
@@ -1002,6 +1002,7 @@ static const struct {
static int __init fsl_pamu_probe(struct platform_device *pdev)
{
+ struct device *dev = &pdev->dev;
void __iomem *pamu_regs = NULL;
struct ccsr_guts __iomem *guts_regs = NULL;
u32 pamubypenr, pamu_counter;
@@ -1026,16 +1027,16 @@ static int __init fsl_pamu_probe(struct platform_device *pdev)
* NOTE : All PAMUs share the same LIODN tables.
*/
- pamu_regs = of_iomap(pdev->dev.of_node, 0);
+ pamu_regs = of_iomap(dev->of_node, 0);
if (!pamu_regs) {
- dev_err(&pdev->dev, "ioremap of PAMU node failed\n");
+ dev_err(dev, "ioremap of PAMU node failed\n");
return -ENOMEM;
}
- of_get_address(pdev->dev.of_node, 0, &size, NULL);
+ of_get_address(dev->of_node, 0, &size, NULL);
- irq = irq_of_parse_and_map(pdev->dev.of_node, 0);
+ irq = irq_of_parse_and_map(dev->of_node, 0);
if (irq == NO_IRQ) {
- dev_warn(&pdev->dev, "no interrupts listed in PAMU node\n");
+ dev_warn(dev, "no interrupts listed in PAMU node\n");
goto error;
}
@@ -1050,15 +1051,14 @@ static int __init fsl_pamu_probe(struct platform_device *pdev)
/* The ISR needs access to the regs, so we won't iounmap them */
ret = request_irq(irq, pamu_av_isr, 0, "pamu", data);
if (ret < 0) {
- dev_err(&pdev->dev, "error %i installing ISR for irq %i\n",
- ret, irq);
+ dev_err(dev, "error %i installing ISR for irq %i\n", ret, irq);
goto error;
}
guts_node = of_find_matching_node(NULL, guts_device_ids);
if (!guts_node) {
- dev_err(&pdev->dev, "could not find GUTS node %s\n",
- pdev->dev.of_node->full_name);
+ dev_err(dev, "could not find GUTS node %s\n",
+ dev->of_node->full_name);
ret = -ENODEV;
goto error;
}
@@ -1066,7 +1066,7 @@ static int __init fsl_pamu_probe(struct platform_device *pdev)
guts_regs = of_iomap(guts_node, 0);
of_node_put(guts_node);
if (!guts_regs) {
- dev_err(&pdev->dev, "ioremap of GUTS node failed\n");
+ dev_err(dev, "ioremap of GUTS node failed\n");
ret = -ENODEV;
goto error;
}
@@ -1086,7 +1086,7 @@ static int __init fsl_pamu_probe(struct platform_device *pdev)
p = alloc_pages(GFP_KERNEL | __GFP_ZERO, order);
if (!p) {
- dev_err(&pdev->dev, "unable to allocate PAACT/SPAACT/OMT block\n");
+ dev_err(dev, "unable to allocate PAACT/SPAACT/OMT block\n");
ret = -ENOMEM;
goto error;
}
@@ -1096,7 +1096,7 @@ static int __init fsl_pamu_probe(struct platform_device *pdev)
/* Make sure the memory is naturally aligned */
if (ppaact_phys & ((PAGE_SIZE << order) - 1)) {
- dev_err(&pdev->dev, "PAACT/OMT block is unaligned\n");
+ dev_err(dev, "PAACT/OMT block is unaligned\n");
ret = -ENOMEM;
goto error;
}
@@ -1104,8 +1104,7 @@ static int __init fsl_pamu_probe(struct platform_device *pdev)
spaact = (void *)ppaact + (PAGE_SIZE << get_order(PAACT_SIZE));
omt = (void *)spaact + (PAGE_SIZE << get_order(SPAACT_SIZE));
- dev_dbg(&pdev->dev, "ppaact virt=%p phys=0x%pa\n", ppaact,
- &ppaact_phys);
+ dev_dbg(dev, "ppaact virt=%p phys=0x%pa\n", ppaact, &ppaact_phys);
/* Check to see if we need to implement the work-around on this SOC */
@@ -1113,21 +1112,19 @@ static int __init fsl_pamu_probe(struct platform_device *pdev)
for (i = 0; i < ARRAY_SIZE(port_id_map); i++) {
if (port_id_map[i].svr == (mfspr(SPRN_SVR) & ~SVR_SECURITY)) {
csd_port_id = port_id_map[i].port_id;
- dev_dbg(&pdev->dev, "found matching SVR %08x\n",
+ dev_dbg(dev, "found matching SVR %08x\n",
port_id_map[i].svr);
break;
}
}
if (csd_port_id) {
- dev_dbg(&pdev->dev, "creating coherency subdomain at address "
- "%pa, size %zu, port id 0x%08x", &ppaact_phys,
- mem_size, csd_port_id);
+ dev_dbg(dev, "creating coherency subdomain at address %pa, size %zu, port id 0x%08x",
+ &ppaact_phys, mem_size, csd_port_id);
ret = create_csd(ppaact_phys, mem_size, csd_port_id);
if (ret) {
- dev_err(&pdev->dev, "could not create coherence "
- "subdomain\n");
+ dev_err(dev, "could not create coherence subdomain\n");
return ret;
}
}
@@ -1138,7 +1135,7 @@ static int __init fsl_pamu_probe(struct platform_device *pdev)
spaace_pool = gen_pool_create(ilog2(sizeof(struct paace)), -1);
if (!spaace_pool) {
ret = -ENOMEM;
- dev_err(&pdev->dev, "PAMU : failed to allocate spaace gen pool\n");
+ dev_err(dev, "PAMU : failed to allocate spaace gen pool\n");
goto error;
}
--
2.2.2
next prev parent reply other threads:[~2015-01-28 14:34 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-28 14:34 [PATCH 00/26] iommu/fsl: Various cleanup Emil Medve
[not found] ` <1422455698-3074-1-git-send-email-Emilian.Medve-eDlz3WWmN0ll57MIdRCFDg@public.gmane.org>
2015-01-28 14:34 ` [PATCH v2 01/26] iommu/fsl: Sprinkle some __init* annotations Emil Medve
[not found] ` <1422455698-3074-2-git-send-email-Emilian.Medve-eDlz3WWmN0ll57MIdRCFDg@public.gmane.org>
2015-01-30 6:46 ` Varun Sethi
[not found] ` <BN3PR0301MB121998FEF4EE5C92DEEF7D61EA310-CEkquS/Gb81uuip9JPHoc5wN6zqB+hSMnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2015-01-30 6:55 ` Emil Medve
[not found] ` <54CB2AEC.9000800-eDlz3WWmN0ll57MIdRCFDg@public.gmane.org>
2015-01-30 9:20 ` Varun Sethi
[not found] ` <BN3PR0301MB1219965593D06F96A8A1ADB8EA310-CEkquS/Gb81uuip9JPHoc5wN6zqB+hSMnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2015-01-30 14:23 ` Emil Medve
[not found] ` <54CB93ED.80109-eDlz3WWmN0ll57MIdRCFDg@public.gmane.org>
2015-01-30 14:44 ` Varun Sethi
2015-02-09 21:46 ` Emil Medve
[not found] ` <54D92ABC.3030802-eDlz3WWmN0ll57MIdRCFDg@public.gmane.org>
2015-02-10 2:26 ` Varun Sethi
[not found] ` <BY1PR0301MB122186F802612D1B8048722AEA240-M1kb196zaoruTkAIFHd/+ZwN6zqB+hSMnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2015-02-11 11:07 ` Emil Medve
[not found] ` <54DB37DA.2040500-eDlz3WWmN0ll57MIdRCFDg@public.gmane.org>
2015-02-11 11:30 ` Varun Sethi
2015-02-11 13:47 ` Varun Sethi
2015-02-11 11:35 ` Joerg Roedel
2015-01-28 14:34 ` [PATCH 02/26] iommu/fsl: Use SVR_* instead of magic numbers Emil Medve
[not found] ` <1422455698-3074-3-git-send-email-Emilian.Medve-eDlz3WWmN0ll57MIdRCFDg@public.gmane.org>
2015-01-30 6:57 ` Varun Sethi
2015-01-28 14:34 ` [PATCH 03/26] iommu/fsl: Remove unused/extra includes Emil Medve
[not found] ` <1422455698-3074-4-git-send-email-Emilian.Medve-eDlz3WWmN0ll57MIdRCFDg@public.gmane.org>
2015-01-30 7:10 ` Varun Sethi
2015-01-28 14:34 ` [PATCH 04/26] iommu/fsl: Fix checkpatch type SPACE_BEFORE_TAB Emil Medve
[not found] ` <1422455698-3074-5-git-send-email-Emilian.Medve-eDlz3WWmN0ll57MIdRCFDg@public.gmane.org>
2015-01-30 7:12 ` Varun Sethi
2015-01-28 14:34 ` [PATCH 05/26] iommu/fsl: Fix checkpatch type LINE_SPACING Emil Medve
[not found] ` <1422455698-3074-6-git-send-email-Emilian.Medve-eDlz3WWmN0ll57MIdRCFDg@public.gmane.org>
2015-01-30 7:13 ` Varun Sethi
2015-01-28 14:34 ` [PATCH 06/26] iommu/fsl: Fix checkpatch type LEADING_SPACE Emil Medve
[not found] ` <1422455698-3074-7-git-send-email-Emilian.Medve-eDlz3WWmN0ll57MIdRCFDg@public.gmane.org>
2015-01-30 7:15 ` Varun Sethi
2015-01-28 14:34 ` [PATCH 07/26] iommu/fsl: Fix checkpath type BRACES Emil Medve
[not found] ` <1422455698-3074-8-git-send-email-Emilian.Medve-eDlz3WWmN0ll57MIdRCFDg@public.gmane.org>
2015-01-30 7:17 ` Varun Sethi
2015-01-28 14:34 ` [PATCH 08/26] iommu/fsl: Fix checkpatch type CODE_INDENT Emil Medve
[not found] ` <1422455698-3074-9-git-send-email-Emilian.Medve-eDlz3WWmN0ll57MIdRCFDg@public.gmane.org>
2015-01-30 7:19 ` Varun Sethi
2015-01-28 14:34 ` [PATCH 09/26] iommu/fsl: Fix checkpatch type ALLOC_SIZEOF_STRUCT Emil Medve
[not found] ` <1422455698-3074-10-git-send-email-Emilian.Medve-eDlz3WWmN0ll57MIdRCFDg@public.gmane.org>
2015-01-30 7:30 ` Varun Sethi
2015-01-28 14:34 ` [PATCH 10/26] iommu/fsl: Fix checkpatch type ALLOC_WITH_MULTIPLY Emil Medve
[not found] ` <1422455698-3074-11-git-send-email-Emilian.Medve-eDlz3WWmN0ll57MIdRCFDg@public.gmane.org>
2015-01-30 7:33 ` Varun Sethi
2015-01-28 14:34 ` [PATCH 11/26] iommu/fsl: Fix checkpatch type OOM_MESSAGE Emil Medve
[not found] ` <1422455698-3074-12-git-send-email-Emilian.Medve-eDlz3WWmN0ll57MIdRCFDg@public.gmane.org>
2015-01-30 9:43 ` Varun Sethi
[not found] ` <BN3PR0301MB1219BCCB01E99D150D0753F6EA310-CEkquS/Gb81uuip9JPHoc5wN6zqB+hSMnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2015-01-30 14:18 ` Emil Medve
[not found] ` <54CB92C0.5000304-eDlz3WWmN0ll57MIdRCFDg@public.gmane.org>
2015-01-30 14:47 ` Varun Sethi
2015-01-28 14:34 ` [PATCH 12/26] iommu/fsl: Fix checkpatch type TYPO_SPELLING Emil Medve
[not found] ` <1422455698-3074-13-git-send-email-Emilian.Medve-eDlz3WWmN0ll57MIdRCFDg@public.gmane.org>
2015-01-30 7:40 ` Varun Sethi
2015-01-28 14:34 ` [PATCH 13/26] iommu/fsl: Fix checkpatch type PREFER_PACKED Emil Medve
[not found] ` <1422455698-3074-14-git-send-email-Emilian.Medve-eDlz3WWmN0ll57MIdRCFDg@public.gmane.org>
2015-01-30 7:40 ` Varun Sethi
2015-01-28 14:34 ` [PATCH 14/26] iommu/fsl: Fix checkpatch type QUOTED_WHITESPACE_BEFORE_NEWLINE Emil Medve
[not found] ` <1422455698-3074-15-git-send-email-Emilian.Medve-eDlz3WWmN0ll57MIdRCFDg@public.gmane.org>
2015-01-30 7:42 ` Varun Sethi
2015-01-28 14:34 ` [PATCH 15/26] iommu/fsl: Fix checkpatch type SPACING Emil Medve
[not found] ` <1422455698-3074-16-git-send-email-Emilian.Medve-eDlz3WWmN0ll57MIdRCFDg@public.gmane.org>
2015-01-30 7:44 ` Varun Sethi
2015-01-28 14:34 ` Emil Medve [this message]
[not found] ` <1422455698-3074-17-git-send-email-Emilian.Medve-eDlz3WWmN0ll57MIdRCFDg@public.gmane.org>
2015-01-30 7:46 ` [PATCH 16/26] iommu/fsl: Use a device pointer to make lines shorter Varun Sethi
2015-01-28 14:34 ` [PATCH 17/26] iommu/fsl: Remove pr/dev_*() prefixes Emil Medve
[not found] ` <1422455698-3074-18-git-send-email-Emilian.Medve-eDlz3WWmN0ll57MIdRCFDg@public.gmane.org>
2015-01-30 7:47 ` Varun Sethi
2015-01-28 14:34 ` [PATCH 18/26] iommu/fsl: Fix checkpatch type PARENTHESIS_ALIGNMENT Emil Medve
[not found] ` <1422455698-3074-19-git-send-email-Emilian.Medve-eDlz3WWmN0ll57MIdRCFDg@public.gmane.org>
2015-01-30 9:29 ` Varun Sethi
2015-01-28 14:34 ` [PATCH 19/26] iommu/fsl: Fix some comments alignment Emil Medve
[not found] ` <1422455698-3074-20-git-send-email-Emilian.Medve-eDlz3WWmN0ll57MIdRCFDg@public.gmane.org>
2015-01-30 9:30 ` Varun Sethi
2015-01-28 14:34 ` [PATCH 20/26] iommu/fsl: Fix alignment of some stray lines Emil Medve
[not found] ` <1422455698-3074-21-git-send-email-Emilian.Medve-eDlz3WWmN0ll57MIdRCFDg@public.gmane.org>
2015-01-30 9:31 ` Varun Sethi
2015-01-28 14:34 ` [PATCH 21/26] iommu/fsl: Fix checkpatch type LONG_LINE Emil Medve
[not found] ` <1422455698-3074-22-git-send-email-Emilian.Medve-eDlz3WWmN0ll57MIdRCFDg@public.gmane.org>
2015-01-30 9:32 ` Varun Sethi
2015-01-28 14:34 ` [PATCH 22/26] iommu/fsl: Make local symbols static Emil Medve
[not found] ` <1422455698-3074-23-git-send-email-Emilian.Medve-eDlz3WWmN0ll57MIdRCFDg@public.gmane.org>
2015-01-30 9:33 ` Varun Sethi
2015-01-28 14:34 ` [PATCH 23/26] iommu/fsl: Use NULL instead of zero Emil Medve
[not found] ` <1422455698-3074-24-git-send-email-Emilian.Medve-eDlz3WWmN0ll57MIdRCFDg@public.gmane.org>
2015-01-30 9:33 ` Varun Sethi
2015-01-28 14:34 ` [PATCH 24/26] iommu/fsl: Remove unneeded semicolon Emil Medve
[not found] ` <1422455698-3074-25-git-send-email-Emilian.Medve-eDlz3WWmN0ll57MIdRCFDg@public.gmane.org>
2015-01-30 9:34 ` Varun Sethi
2015-01-28 14:34 ` [PATCH 25/26] iommu/fsl: Don't use integers values with bool type Emil Medve
[not found] ` <1422455698-3074-26-git-send-email-Emilian.Medve-eDlz3WWmN0ll57MIdRCFDg@public.gmane.org>
2015-01-30 9:35 ` Varun Sethi
2015-01-28 14:34 ` [PATCH 26/26] iommu/fsl: Remove extra paranthesis Emil Medve
[not found] ` <1422455698-3074-27-git-send-email-Emilian.Medve-eDlz3WWmN0ll57MIdRCFDg@public.gmane.org>
2015-01-30 9:40 ` Varun Sethi
2015-01-30 12:30 ` [PATCH 00/26] iommu/fsl: Various cleanup Joerg Roedel
[not found] ` <20150130123040.GE3702-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2015-01-30 14:50 ` Varun Sethi
[not found] ` <BN3PR0301MB12194ECBA7501AFE17F34F69EA310-CEkquS/Gb81uuip9JPHoc5wN6zqB+hSMnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2015-01-30 15:36 ` Joerg Roedel
[not found] ` <20150130153626.GH3702-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2015-01-31 17:37 ` Varun Sethi
2015-01-31 17:58 ` Timur Tabi
[not found] ` <CAOZdJXXk5L7AFwryKXiTemw=jw+VXXXBZXdapzgzs4APC0PLtQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-02-01 6:05 ` Emil Medve
[not found] ` <54CDC236.70004-eDlz3WWmN0ll57MIdRCFDg@public.gmane.org>
2015-02-01 17:07 ` Timur Tabi
2015-02-03 17:51 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422455698-3074-17-git-send-email-Emilian.Medve@Freescale.com \
--to=emilian.medve-edlz3wwmn0ll57midrcfdg@public.gmane.org \
--cc=Varun.Sethi-eDlz3WWmN0ll57MIdRCFDg@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org \
--cc=jroedel-l3A5Bk7waGM@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox