From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Cc: Alexandre Courbot
<gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Kukjin Kim <kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Thierry Reding
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
jroedel-l3A5Bk7waGM@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Yingjoe Chen
<yingjoe.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: [PATCH 01/16] iommu: Introduce domain_alloc and domain_free iommu_ops
Date: Thu, 26 Mar 2015 13:43:04 +0100 [thread overview]
Message-ID: <1427373799-18662-2-git-send-email-joro@8bytes.org> (raw)
In-Reply-To: <1427373799-18662-1-git-send-email-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
From: Joerg Roedel <jroedel-l3A5Bk7waGM@public.gmane.org>
These new call-backs defer the allocation and destruction of
'struct iommu_domain' to the iommu driver. This allows
drivers to embed this struct into their private domain
structures and to get rid of the domain_init and
domain_destroy call-backs when all drivers have been
converted.
Signed-off-by: Joerg Roedel <jroedel-l3A5Bk7waGM@public.gmane.org>
---
drivers/iommu/iommu.c | 29 +++++++++++++++++++++--------
include/linux/iommu.h | 5 +++++
2 files changed, 26 insertions(+), 8 deletions(-)
diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
index 72e683d..11de262 100644
--- a/drivers/iommu/iommu.c
+++ b/drivers/iommu/iommu.c
@@ -900,26 +900,34 @@ EXPORT_SYMBOL_GPL(iommu_set_fault_handler);
struct iommu_domain *iommu_domain_alloc(struct bus_type *bus)
{
+ const struct iommu_ops *ops;
struct iommu_domain *domain;
- int ret;
if (bus == NULL || bus->iommu_ops == NULL)
return NULL;
- domain = kzalloc(sizeof(*domain), GFP_KERNEL);
+ ops = bus->iommu_ops;
+
+ if (ops->domain_alloc)
+ domain = ops->domain_alloc();
+ else
+ domain = kzalloc(sizeof(*domain), GFP_KERNEL);
+
if (!domain)
return NULL;
domain->ops = bus->iommu_ops;
- ret = domain->ops->domain_init(domain);
- if (ret)
+ if (ops->domain_init && domain->ops->domain_init(domain))
goto out_free;
return domain;
out_free:
- kfree(domain);
+ if (ops->domain_free)
+ ops->domain_free(domain);
+ else
+ kfree(domain);
return NULL;
}
@@ -927,10 +935,15 @@ EXPORT_SYMBOL_GPL(iommu_domain_alloc);
void iommu_domain_free(struct iommu_domain *domain)
{
- if (likely(domain->ops->domain_destroy != NULL))
- domain->ops->domain_destroy(domain);
+ const struct iommu_ops *ops = domain->ops;
- kfree(domain);
+ if (likely(ops->domain_destroy != NULL))
+ ops->domain_destroy(domain);
+
+ if (ops->domain_free)
+ ops->domain_free(domain);
+ else
+ kfree(domain);
}
EXPORT_SYMBOL_GPL(iommu_domain_free);
diff --git a/include/linux/iommu.h b/include/linux/iommu.h
index 38daa45..69d1d12 100644
--- a/include/linux/iommu.h
+++ b/include/linux/iommu.h
@@ -115,6 +115,11 @@ struct iommu_ops {
bool (*capable)(enum iommu_cap);
int (*domain_init)(struct iommu_domain *domain);
void (*domain_destroy)(struct iommu_domain *domain);
+
+ /* Domain allocation and freeing by the iommu driver */
+ struct iommu_domain *(*domain_alloc)(void);
+ void (*domain_free)(struct iommu_domain *);
+
int (*attach_dev)(struct iommu_domain *domain, struct device *dev);
void (*detach_dev)(struct iommu_domain *domain, struct device *dev);
int (*map)(struct iommu_domain *domain, unsigned long iova,
--
1.9.1
next prev parent reply other threads:[~2015-03-26 12:43 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-26 12:43 [PATCH 00/16 v2] iommu: Move domain allocation into drivers Joerg Roedel
[not found] ` <1427373799-18662-1-git-send-email-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2015-03-26 12:43 ` Joerg Roedel [this message]
2015-03-26 12:43 ` [PATCH 02/16] iommu: Introduce iommu domain types Joerg Roedel
2015-03-26 12:52 ` Swapna Nannapaneni
2015-03-26 12:43 ` [PATCH 03/16] iommu: Only allow iommu_map/unmap for paging domains Joerg Roedel
2015-03-26 12:43 ` [PATCH 04/16] iommu/amd: Make use of domain_alloc and domain_free Joerg Roedel
2015-03-26 12:43 ` [PATCH 05/16] iommu/vt-d: " Joerg Roedel
2015-03-26 12:43 ` [PATCH 06/16] iommu/omap: " Joerg Roedel
2015-03-26 12:43 ` [PATCH 07/16] iommu/arm-smmu: " Joerg Roedel
2015-03-26 12:43 ` [PATCH 08/16] iommu/exynos: " Joerg Roedel
2015-03-26 12:43 ` [PATCH 09/16] iommu/tegra-smmu: " Joerg Roedel
[not found] ` <1427373799-18662-10-git-send-email-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2015-03-27 10:59 ` Thierry Reding
2015-03-26 12:43 ` [PATCH 10/16] iommu/tegra-gart: " Joerg Roedel
[not found] ` <1427373799-18662-11-git-send-email-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2015-03-27 11:00 ` Thierry Reding
2015-03-26 12:43 ` [PATCH 11/16] iommu/msm: " Joerg Roedel
2015-03-26 12:43 ` [PATCH 12/16] iommu/shmobile: " Joerg Roedel
2015-03-26 12:43 ` [PATCH 13/16] iommu/ipmmu-vmsa: " Joerg Roedel
2015-03-26 12:43 ` [PATCH 14/16] iommu/rockchip: " Joerg Roedel
2015-03-27 16:39 ` [PATCH 00/16 v2] iommu: Move domain allocation into drivers Heiko Stuebner
2015-03-28 4:24 ` Alex Williamson
[not found] ` <1427516662.3643.906.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-03-31 13:14 ` Joerg Roedel
2015-03-30 17:43 ` Will Deacon
2015-03-31 13:18 ` Joerg Roedel
2015-03-31 13:33 ` Joerg Roedel
2015-03-26 12:43 ` [PATCH 15/16] iommu/fsl: Make use of domain_alloc and domain_free Joerg Roedel
[not found] ` <1427373799-18662-16-git-send-email-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2015-04-12 14:25 ` Varun Sethi
2015-03-26 12:43 ` [PATCH 16/16] iommu: Remove domain_init and domain_free iommu_ops Joerg Roedel
2015-03-27 11:03 ` [PATCH 00/16 v2] iommu: Move domain allocation into drivers Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427373799-18662-2-git-send-email-joro@8bytes.org \
--to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=jroedel-l3A5Bk7waGM@public.gmane.org \
--cc=kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
--cc=yingjoe.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox