From: David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
To: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
Cc: "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org"
<iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
"thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org"
<laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>,
"Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org"
<Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [GIT PULL] iommu: Kill off pgsize_bitmap field from struct iommu_ops
Date: Wed, 01 Apr 2015 15:52:57 +0200 [thread overview]
Message-ID: <1427896377.22236.8.camel@infradead.org> (raw)
In-Reply-To: <20150401133908.GI1552-5wv7dgnIgG8@public.gmane.org>
[-- Attachment #1.1: Type: text/plain, Size: 777 bytes --]
On Wed, 2015-04-01 at 14:39 +0100, Will Deacon wrote:
> We'd also need to update any page-table code that relies on being called
> one page at a time (i.e. the new io-pgtable stuff we merged for 4.0) so
> that we iterate over the requested range.
Ick. I hadn't noticed we'd entrenched that mistake even harder. It
certainly *wasn't* that hard to fix it...
> That shouldn't be too difficult (i.e. just inline the iommu_map logic
> into each driver), but it would need some testing.
Good.
> In fact, that would also allow us to nuke the whole TLB on VFIO unmap of
> large ranges. We currently iterate over the range page-by-page, which takes
> ages (minutes) in simulation.
Which is one of the big reasons we lie about page sizes in VT-d.
--
dwmw2
[-- Attachment #1.2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5745 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2015-04-01 13:52 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-27 17:19 [GIT PULL] iommu: Kill off pgsize_bitmap field from struct iommu_ops Will Deacon
[not found] ` <20150327171946.GL1562-5wv7dgnIgG8@public.gmane.org>
2015-03-31 14:24 ` Joerg Roedel
[not found] ` <20150331142440.GD22683-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2015-03-31 14:49 ` Will Deacon
[not found] ` <20150331144956.GA24094-5wv7dgnIgG8@public.gmane.org>
2015-03-31 15:50 ` Alex Williamson
[not found] ` <1427817050.5567.148.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-04-01 11:53 ` Will Deacon
[not found] ` <20150401115340.GG1552-5wv7dgnIgG8@public.gmane.org>
2015-04-01 15:53 ` Joerg Roedel
2015-04-01 16:45 ` Alex Williamson
2015-04-01 15:38 ` Joerg Roedel
[not found] ` <20150401153854.GG4441-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2015-04-01 17:03 ` Will Deacon
[not found] ` <20150401170330.GO1552-5wv7dgnIgG8@public.gmane.org>
2015-04-01 21:24 ` Joerg Roedel
2015-03-31 16:07 ` Robin Murphy
2015-04-01 13:14 ` David Woodhouse
[not found] ` <1427894051.22236.6.camel-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-04-01 13:39 ` Will Deacon
[not found] ` <20150401133908.GI1552-5wv7dgnIgG8@public.gmane.org>
2015-04-01 13:52 ` David Woodhouse [this message]
[not found] ` <1427896377.22236.8.camel-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-04-01 14:05 ` Will Deacon
[not found] ` <20150401140512.GJ1552-5wv7dgnIgG8@public.gmane.org>
2015-04-01 14:28 ` David Woodhouse
[not found] ` <1427898490.22236.10.camel-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-04-01 14:39 ` Will Deacon
[not found] ` <20150401143904.GL1552-5wv7dgnIgG8@public.gmane.org>
2015-04-01 14:46 ` David Woodhouse
[not found] ` <1427899570.22236.14.camel-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-04-01 16:36 ` Will Deacon
[not found] ` <20150401163618.GN1552-5wv7dgnIgG8@public.gmane.org>
2015-04-01 21:28 ` joro-zLv9SwRftAIdnm+yROfE0A
[not found] ` <20150401212854.GK4441-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2015-04-02 8:58 ` Will Deacon
2015-04-01 16:51 ` Alex Williamson
[not found] ` <1427907064.5567.256.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-04-01 17:50 ` Will Deacon
[not found] ` <20150401175040.GQ1552-5wv7dgnIgG8@public.gmane.org>
2015-04-01 18:18 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427896377.22236.8.camel@infradead.org \
--to=dwmw2-wegcikhe2lqwvfeawa7xhq@public.gmane.org \
--cc=Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox