Linux IOMMU Development
 help / color / mirror / Atom feed
From: "Li, Zhen-Hua" <zhen-hual-VXdhtT5mjnY@public.gmane.org>
To: dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
	indou.takao-+CUm20s59erQFUHtdCDX3A@public.gmane.org,
	bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org,
	vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Cc: tom.vaden-VXdhtT5mjnY@public.gmane.org,
	rwright-VXdhtT5mjnY@public.gmane.org,
	linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	lisa.mitchell-VXdhtT5mjnY@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	zhen-hual-VXdhtT5mjnY@public.gmane.org,
	doug.hatch-VXdhtT5mjnY@public.gmane.org,
	ishii.hironobu-+CUm20s59erQFUHtdCDX3A@public.gmane.org,
	bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
	billsumnerlinux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	li.zhang6-VXdhtT5mjnY@public.gmane.org
Subject: [PATCH v11 10/10] iommu/vt-d: Use old irte in kdump kernel
Date: Mon, 11 May 2015 17:52:54 +0800	[thread overview]
Message-ID: <1431337974-545-11-git-send-email-zhen-hual@hp.com> (raw)
In-Reply-To: <1431337974-545-1-git-send-email-zhen-hual-VXdhtT5mjnY@public.gmane.org>

Fix the intr-remapping fault.

[1.594890] dmar: DRHD: handling fault status reg 2
[1.594894] dmar: INTR-REMAP: Request device [[41:00.0] fault index 4d
[1.594894] INTR-REMAP:[fault reason 34] Present field in the IRTE entry
is clear

Use old irte in second kernel, do not disable and re-enable interrupt
remapping.

Signed-off-by: Li, Zhen-Hua <zhen-hual-VXdhtT5mjnY@public.gmane.org>
---
 drivers/iommu/intel_irq_remapping.c | 28 ++++++++++++++++++++++++----
 1 file changed, 24 insertions(+), 4 deletions(-)

diff --git a/drivers/iommu/intel_irq_remapping.c b/drivers/iommu/intel_irq_remapping.c
index c2a4406..46d80ad 100644
--- a/drivers/iommu/intel_irq_remapping.c
+++ b/drivers/iommu/intel_irq_remapping.c
@@ -197,6 +197,10 @@ static int modify_irte(int irq, struct irte *irte_modified)
 
 	set_64bit(&irte->low, irte_modified->low);
 	set_64bit(&irte->high, irte_modified->high);
+
+	if (iommu->pre_enabled_ir)
+		__iommu_update_old_irte(iommu, index);
+
 	__iommu_flush_cache(iommu, irte, sizeof(*irte));
 
 	rc = qi_flush_iec(iommu, index, 0);
@@ -258,6 +262,9 @@ static int clear_entries(struct irq_2_iommu *irq_iommu)
 	bitmap_release_region(iommu->ir_table->bitmap, index,
 			      irq_iommu->irte_mask);
 
+	if (iommu->pre_enabled_ir)
+		__iommu_update_old_irte(iommu, -1);
+
 	return qi_flush_iec(iommu, index, irq_iommu->irte_mask);
 }
 
@@ -657,11 +664,13 @@ static int __init intel_enable_irq_remapping(void)
 		 */
 		dmar_fault(-1, iommu);
 
+		iommu_check_pre_ir_status(iommu);
+
 		/*
-		 * Disable intr remapping and queued invalidation, if already
-		 * enabled prior to OS handover.
+		 * Here we do not disable intr remapping,
+		 * if already enabled prior to OS handover.
 		 */
-		iommu_disable_irq_remapping(iommu);
+		/* iommu_disable_irq_remapping(iommu); */
 
 		dmar_disable_qi(iommu);
 	}
@@ -697,7 +706,18 @@ static int __init intel_enable_irq_remapping(void)
 	 * Setup Interrupt-remapping for all the DRHD's now.
 	 */
 	for_each_iommu(iommu, drhd) {
-		iommu_set_irq_remapping(iommu, eim);
+		if (iommu->pre_enabled_ir) {
+			unsigned long long q;
+
+			q = dmar_readq(iommu->reg + DMAR_IRTA_REG);
+			iommu->ir_table->base_old_phys = q & VTD_PAGE_MASK;
+			iommu->ir_table->base_old_virt = ioremap_cache(
+				iommu->ir_table->base_old_phys,
+				INTR_REMAP_TABLE_ENTRIES*sizeof(struct irte));
+			__iommu_load_old_irte(iommu);
+		} else
+			iommu_set_irq_remapping(iommu, eim);
+
 		setup = true;
 	}
 
-- 
2.0.0-rc0

  parent reply	other threads:[~2015-05-11  9:52 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-11  9:52 [PATCH v11 0/10] iommu/vt-d: Fix intel vt-d faults in kdump kernel Li, Zhen-Hua
     [not found] ` <1431337974-545-1-git-send-email-zhen-hual-VXdhtT5mjnY@public.gmane.org>
2015-05-11  9:52   ` [PATCH v11 01/10] iommu/vt-d: New function to attach domain with id Li, Zhen-Hua
2015-05-11  9:52   ` [PATCH v11 02/10] iommu/vt-d: Items required for kdump Li, Zhen-Hua
2015-05-12  8:17     ` Dave Young
2015-05-13  1:45       ` Li, ZhenHua
2015-05-13  6:31         ` Alexander Duyck
     [not found]         ` <5552ACB9.5050309-VXdhtT5mjnY@public.gmane.org>
2015-05-13  8:42           ` Dave Young
2015-05-11  9:52   ` [PATCH v11 03/10] iommu/vt-d: Function to get existing context entry Li, Zhen-Hua
2015-05-11  9:52   ` [PATCH v11 04/10] iommu/vt-d: functions to copy data from old mem Li, Zhen-Hua
     [not found]     ` <1431337974-545-5-git-send-email-zhen-hual-VXdhtT5mjnY@public.gmane.org>
2015-05-12  8:29       ` Dave Young
2015-05-13  9:00     ` Baoquan He
2015-05-13  9:13       ` Li, ZhenHua
2015-05-13  9:21         ` Baoquan He
2015-06-08 14:15     ` David Woodhouse
     [not found]       ` <1433772935.2952.47.camel-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-06-08 15:21         ` Joerg Roedel
2015-06-08 15:44           ` David Woodhouse
2015-05-11  9:52   ` [PATCH v11 05/10] iommu/vt-d: Add functions to load and save old re Li, Zhen-Hua
     [not found]     ` <1431337974-545-6-git-send-email-zhen-hual-VXdhtT5mjnY@public.gmane.org>
2015-05-12  8:37       ` Dave Young
     [not found]         ` <20150512083745.GE4561-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2015-05-13  1:47           ` Li, ZhenHua
2015-05-13  8:49             ` Dave Young
2015-05-11  9:52   ` [PATCH v11 06/10] iommu/vt-d: datatypes and functions used for kdump Li, Zhen-Hua
2015-05-12  8:48     ` Dave Young
     [not found]     ` <1431337974-545-7-git-send-email-zhen-hual-VXdhtT5mjnY@public.gmane.org>
2015-05-13  8:56       ` Baoquan He
     [not found]         ` <20150513085609.GD3736-0VdLhd/A9PlfpSRLqpFUpR/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2015-05-13  8:58           ` Li, ZhenHua
     [not found]             ` <55531231.6040506-VXdhtT5mjnY@public.gmane.org>
2015-05-13  9:10               ` Baoquan He
2015-05-11  9:52   ` [PATCH v11 07/10] iommu/vt-d: enable kdump support in iommu module Li, Zhen-Hua
     [not found]     ` <1431337974-545-8-git-send-email-zhen-hual-VXdhtT5mjnY@public.gmane.org>
2015-05-12  8:52       ` Dave Young
2015-05-13  2:10     ` Baoquan He
2015-05-13  2:28       ` Li, ZhenHua
2015-05-13  2:36         ` Baoquan He
2015-05-11  9:52   ` [PATCH v11 08/10] iommu/vt-d: assign new page table for dma_map Li, Zhen-Hua
2015-05-20 23:52     ` Baoquan He
2015-05-21  1:27       ` Li, ZhenHua
2015-05-21  6:54         ` Baoquan He
     [not found]           ` <20150521065451.GA23661-0VdLhd/A9PlfpSRLqpFUpR/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2015-05-21  8:40             ` Li, ZhenHua
2015-05-21 10:11               ` Baoquan He
2015-05-11  9:52   ` [PATCH v11 09/10] iommu/vt-d: Copy functions for irte Li, Zhen-Hua
2015-05-12  9:00     ` Dave Young
2015-05-11  9:52   ` Li, Zhen-Hua [this message]
2015-05-12  6:18   ` [PATCH v11 0/10] iommu/vt-d: Fix intel vt-d faults in kdump kernel Baoquan He
2015-05-12  9:04   ` Dave Young
2015-05-12  9:34   ` Li, Zhen-Hua
2015-06-08 14:26   ` David Woodhouse
     [not found]     ` <1433773583.2952.52.camel-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-06-08 15:29       ` Joerg Roedel
     [not found]         ` <20150608152957.GW20384-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2015-06-08 15:50           ` David Woodhouse
2015-06-08 16:13             ` Joerg Roedel
2015-06-09 12:55               ` David Woodhouse
2015-06-10  9:21                 ` Joerg Roedel
     [not found]                   ` <20150610092150.GZ20384-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2015-06-10  9:32                     ` Li, ZhenHua
     [not found]                       ` <5578042D.9050407-VXdhtT5mjnY@public.gmane.org>
2015-06-10 14:10                         ` David Woodhouse
2015-05-13  1:54 ` Li, ZhenHua
     [not found]   ` <5552AEE9.80408-VXdhtT5mjnY@public.gmane.org>
2015-05-18 10:05     ` Li, ZhenHua
2015-05-19  1:13       ` Dave Young
2015-05-19  7:43         ` Li, ZhenHua
2015-05-29 16:21 ` Joerg Roedel
     [not found]   ` <20150529162151.GB20384-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2015-05-30 11:23     ` Li, Zhen-Hua

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1431337974-545-11-git-send-email-zhen-hual@hp.com \
    --to=zhen-hual-vxdhtt5mjny@public.gmane.org \
    --cc=bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=billsumnerlinux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=doug.hatch-VXdhtT5mjnY@public.gmane.org \
    --cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    --cc=dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=indou.takao-+CUm20s59erQFUHtdCDX3A@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=ishii.hironobu-+CUm20s59erQFUHtdCDX3A@public.gmane.org \
    --cc=joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org \
    --cc=kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=li.zhang6-VXdhtT5mjnY@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=lisa.mitchell-VXdhtT5mjnY@public.gmane.org \
    --cc=rwright-VXdhtT5mjnY@public.gmane.org \
    --cc=tom.vaden-VXdhtT5mjnY@public.gmane.org \
    --cc=vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox