From: Baptiste Reynal <b.reynal@virtualopensystems.com>
To: kvmarm@lists.cs.columbia.edu, iommu@lists.linux-foundation.org
Cc: "open list:VFIO PLATFORM DRIVER" <kvm@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
alex.williamson@redhat.com, tech@virtualopensystems.com
Subject: [RFC PATCH v4 3/3] vfio: platform: return device properties as arrays of unsigned integers
Date: Wed, 9 Sep 2015 11:17:11 +0200 [thread overview]
Message-ID: <1441790231-22920-4-git-send-email-b.reynal@virtualopensystems.com> (raw)
In-Reply-To: <1441790231-22920-1-git-send-email-b.reynal@virtualopensystems.com>
From: Antonios Motakis <a.motakis@virtualopensystems.com>
Certain properties of a device are accessible as an array of unsigned
integers, either u64, u32, u16, or u8. Let the VFIO user query this
type of device properties.
Signed-off-by: Antonios Motakis <a.motakis@virtualopensystems.com>
Signed-off-by: Baptiste Reynal <b.reynal@virtualopensystems.com>
---
drivers/vfio/platform/properties.c | 62 +++++++++++++++++++++++++++++++++++++-
1 file changed, 61 insertions(+), 1 deletion(-)
diff --git a/drivers/vfio/platform/properties.c b/drivers/vfio/platform/properties.c
index 8bf9c8f..625e2d3 100644
--- a/drivers/vfio/platform/properties.c
+++ b/drivers/vfio/platform/properties.c
@@ -70,7 +70,67 @@ static int dev_property_get_uint(struct device *dev, uint32_t *flags,
char *name, uint32_t type, unsigned *lenp,
void __user *datap, unsigned long datasz)
{
- return -EINVAL;
+ int ret, n;
+ u8 *out;
+ size_t sz;
+ int (*func)(const struct device *, const char *, void *, size_t)
+ = NULL;
+
+ switch (type) {
+ case VFIO_DEV_PROPERTY_TYPE_U64:
+ sz = sizeof(u64);
+ func = (int (*)(const struct device *,
+ const char *, void *, size_t))
+ device_property_read_u64_array;
+ break;
+ case VFIO_DEV_PROPERTY_TYPE_U32:
+ sz = sizeof(u32);
+ func = (int (*)(const struct device *,
+ const char *, void *, size_t))
+ device_property_read_u32_array;
+ break;
+ case VFIO_DEV_PROPERTY_TYPE_U16:
+ sz = sizeof(u16);
+ func = (int (*)(const struct device *,
+ const char *, void *, size_t))
+ device_property_read_u16_array;
+ break;
+ case VFIO_DEV_PROPERTY_TYPE_U8:
+ sz = sizeof(u8);
+ func = (int (*)(const struct device *,
+ const char *, void *, size_t))
+ device_property_read_u8_array;
+ break;
+
+ default:
+ return -EINVAL;
+ }
+
+ /* get size of array */
+ n = func(dev, name, NULL, 0);
+ if (n < 0)
+ return n;
+
+ if (lenp)
+ *lenp = n * sz;
+
+ if (n * sz > datasz)
+ return -EOVERFLOW;
+
+ out = kcalloc(n, sz, GFP_KERNEL);
+ if (!out)
+ return -ENOMEM;
+
+ ret = func(dev, name, out, n);
+ if (ret)
+ goto out;
+
+ if (copy_to_user(datap, out, n * sz))
+ ret = -EFAULT;
+
+out:
+ kfree(out);
+ return ret;
}
int vfio_platform_dev_properties(struct device *dev, uint32_t *flags,
--
2.5.1
next prev parent reply other threads:[~2015-09-09 9:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-09 9:17 [RFC PATCH v4 0/3] vfio: platform: return device properties for a platform device Baptiste Reynal
2015-09-09 9:17 ` [RFC PATCH v4 1/3] vfio: platform: add device properties skeleton and user API Baptiste Reynal
[not found] ` <1441790231-22920-2-git-send-email-b.reynal-lrHrjnjw1UfHK3s98zE1ajGjJy/sRE9J@public.gmane.org>
2015-09-09 20:48 ` Alex Williamson
2015-09-10 6:35 ` Baptiste Reynal
2015-09-09 9:17 ` [RFC PATCH v4 2/3] vfio: platform: access device property as a list of strings Baptiste Reynal
2015-09-09 20:48 ` Alex Williamson
2015-09-10 6:37 ` Baptiste Reynal
2015-09-09 9:17 ` Baptiste Reynal [this message]
2015-09-09 20:48 ` [RFC PATCH v4 3/3] vfio: platform: return device properties as arrays of unsigned integers Alex Williamson
2015-09-10 6:39 ` Baptiste Reynal
[not found] ` <1441790231-22920-1-git-send-email-b.reynal-lrHrjnjw1UfHK3s98zE1ajGjJy/sRE9J@public.gmane.org>
2015-09-09 20:49 ` [RFC PATCH v4 0/3] vfio: platform: return device properties for a platform device Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441790231-22920-4-git-send-email-b.reynal@virtualopensystems.com \
--to=b.reynal@virtualopensystems.com \
--cc=alex.williamson@redhat.com \
--cc=iommu@lists.linux-foundation.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=tech@virtualopensystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox