From: Alex Williamson <alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Jeremy McNicoll
<jmcnicol-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Subject: Re: [PATCH] iommu/vt-d: Don't skip PCI devices when disabling IOTLB
Date: Wed, 20 Jan 2016 11:41:13 -0700 [thread overview]
Message-ID: <1453315273.32741.307.camel@redhat.com> (raw)
In-Reply-To: <1452835986-8731-1-git-send-email-jmcnicol-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
On Thu, 2016-01-14 at 21:33 -0800, Jeremy McNicoll wrote:
> Fix a simple typo when disabling IOTLB on PCI(e) devices.
>
> Fixes: b16d0cb9e2fc ("iommu/vt-d: Always enable PASID/PRI PCI
> capabilities before ATS")
> Signed-off-by: Jeremy McNicoll <jmcnicol@redhat.com>
> ---
> drivers/iommu/intel-iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-
> iommu.c
> index ac73876..986a53e 100644
> --- a/drivers/iommu/intel-iommu.c
> +++ b/drivers/iommu/intel-iommu.c
> @@ -1489,7 +1489,7 @@ static void iommu_disable_dev_iotlb(struct
> device_domain_info *info)
> {
> struct pci_dev *pdev;
>
> - if (dev_is_pci(info->dev))
> + if (!dev_is_pci(info->dev))
> return;
>
> pdev = to_pci_dev(info->dev);
Looks like a pretty obvious typo/thinko to me. I'd probably suggest it
for v4.4 stable too.
Reviewed-by: Alex Williamson <alex.williamson@redhat.com>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2016-01-20 18:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 5:33 [PATCH] iommu/vt-d: Don't skip PCI devices when disabling IOTLB Jeremy McNicoll
[not found] ` <1452835986-8731-1-git-send-email-jmcnicol-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-01-20 18:41 ` Alex Williamson [this message]
2016-01-29 11:18 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453315273.32741.307.camel@redhat.com \
--to=alex.williamson-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=jmcnicol-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).