iommu.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Eric Auger <eric.auger@linaro.org>
To: eric.auger@st.com, eric.auger@linaro.org, robin.murphy@arm.com,
	alex.williamson@redhat.com, will.deacon@arm.com, joro@8bytes.org,
	tglx@linutronix.de, jason@lakedaemon.net, marc.zyngier@arm.com,
	christoffer.dall@linaro.org,
	linux-arm-kernel@lists.infradead.org
Cc: patches@linaro.org, linux-kernel@vger.kernel.org,
	Bharat.Bhushan@freescale.com, pranav.sawargaonkar@gmail.com,
	p.fedin@samsung.com, iommu@lists.linux-foundation.org,
	Jean-Philippe.Brucker@arm.com, julien.grall@arm.com
Subject: [PATCH v7 07/10] iommu/dma-reserved-iommu: delete bindings in iommu_free_reserved_iova_domain
Date: Tue, 19 Apr 2016 16:56:31 +0000	[thread overview]
Message-ID: <1461084994-2355-8-git-send-email-eric.auger@linaro.org> (raw)
In-Reply-To: <1461084994-2355-1-git-send-email-eric.auger@linaro.org>

Now reserved bindings can exist, destroy them when destroying
the reserved iova domain. iommu_map is not supposed to be atomic,
hence the extra complexity in the locking.

Signed-off-by: Eric Auger <eric.auger@linaro.org>

---
v6 -> v7:
- remove [PATCH v6 7/7] dma-reserved-iommu: iommu_unmap_reserved and
  destroy the bindings in iommu_free_reserved_iova_domain

v5 -> v6:
- use spin_lock instead of mutex

v3 -> v4:
- previously "iommu/arm-smmu: relinquish reserved resources on
  domain deletion"
---
 drivers/iommu/dma-reserved-iommu.c | 34 ++++++++++++++++++++++++++++------
 1 file changed, 28 insertions(+), 6 deletions(-)

diff --git a/drivers/iommu/dma-reserved-iommu.c b/drivers/iommu/dma-reserved-iommu.c
index 426d339..2522235 100644
--- a/drivers/iommu/dma-reserved-iommu.c
+++ b/drivers/iommu/dma-reserved-iommu.c
@@ -157,14 +157,36 @@ void iommu_free_reserved_iova_domain(struct iommu_domain *domain)
 	unsigned long flags;
 	int ret = 0;
 
-	spin_lock_irqsave(&domain->reserved_lock, flags);
-
-	rid = (struct reserved_iova_domain *)domain->reserved_iova_cookie;
-	if (!rid) {
-		ret = -EINVAL;
-		goto unlock;
+	while (1) {
+		struct iommu_reserved_binding *b;
+		struct rb_node *node;
+		dma_addr_t iova;
+		size_t size;
+
+		spin_lock_irqsave(&domain->reserved_lock, flags);
+
+		rid = (struct reserved_iova_domain *)
+				domain->reserved_iova_cookie;
+		if (!rid) {
+			ret = -EINVAL;
+			goto unlock;
+		}
+
+		node = rb_first(&domain->reserved_binding_list);
+		if (!node)
+			break;
+		b = rb_entry(node, struct iommu_reserved_binding, node);
+
+		iova = b->iova;
+		size = b->size;
+
+		while (!kref_put(&b->kref, reserved_binding_release))
+			;
+		spin_unlock_irqrestore(&domain->reserved_lock, flags);
+		iommu_unmap(domain, iova, size);
 	}
 
+	domain->reserved_binding_list = RB_ROOT;
 	domain->reserved_iova_cookie = NULL;
 unlock:
 	spin_unlock_irqrestore(&domain->reserved_lock, flags);
-- 
1.9.1

  reply	other threads:[~2016-04-19 16:56 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-19 16:56 [PATCH v7 00/10] KVM PCIe/MSI passthrough on ARM/ARM64: kernel part 1/3: iommu changes Eric Auger
2016-04-19 16:56 ` Eric Auger [this message]
     [not found]   ` <1461084994-2355-8-git-send-email-eric.auger-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-04-20 17:05     ` [PATCH v7 07/10] iommu/dma-reserved-iommu: delete bindings in iommu_free_reserved_iova_domain Robin Murphy
     [not found]       ` <5717B6D7.4010307-5wv7dgnIgG8@public.gmane.org>
2016-04-21  8:40         ` Eric Auger
     [not found] ` <1461084994-2355-1-git-send-email-eric.auger-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-04-19 16:56   ` [PATCH v7 01/10] iommu: Add DOMAIN_ATTR_MSI_MAPPING attribute Eric Auger
     [not found]     ` <1461084994-2355-2-git-send-email-eric.auger-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-04-20 12:47       ` Robin Murphy
     [not found]         ` <57177A4E.4090804-5wv7dgnIgG8@public.gmane.org>
2016-04-20 15:58           ` Eric Auger
     [not found]             ` <5717A738.9090904-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-04-22 11:31               ` Robin Murphy
     [not found]                 ` <571A0B78.6070509-5wv7dgnIgG8@public.gmane.org>
2016-04-22 12:00                   ` Eric Auger
     [not found]                     ` <571A1273.9060808-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-04-22 14:49                       ` Robin Murphy
     [not found]                         ` <571A3A10.70601-5wv7dgnIgG8@public.gmane.org>
2016-04-22 15:33                           ` Eric Auger
2016-04-19 16:56   ` [PATCH v7 02/10] iommu/arm-smmu: advertise " Eric Auger
2016-04-19 16:56   ` [PATCH v7 03/10] iommu: introduce a reserved iova cookie Eric Auger
     [not found]     ` <1461084994-2355-4-git-send-email-eric.auger-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-04-20 12:55       ` Robin Murphy
     [not found]         ` <57177C31.9090004-5wv7dgnIgG8@public.gmane.org>
2016-04-20 16:14           ` Eric Auger
     [not found]             ` <5717AAC9.10505-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-04-22 12:36               ` Robin Murphy
     [not found]                 ` <571A1AC5.9030905-5wv7dgnIgG8@public.gmane.org>
2016-04-22 13:02                   ` Eric Auger
     [not found]                     ` <571A20C9.9010508-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-04-22 14:53                       ` Eric Auger
2016-04-19 16:56   ` [PATCH v7 04/10] iommu/dma-reserved-iommu: alloc/free_reserved_iova_domain Eric Auger
     [not found]     ` <1461084994-2355-5-git-send-email-eric.auger-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-04-20 13:03       ` Robin Murphy
     [not found]         ` <57177E2A.9090602-5wv7dgnIgG8@public.gmane.org>
2016-04-20 13:11           ` Eric Auger
2016-04-19 16:56   ` [PATCH v7 05/10] iommu/dma-reserved-iommu: reserved binding rb-tree and helpers Eric Auger
     [not found]     ` <1461084994-2355-6-git-send-email-eric.auger-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-04-20 13:12       ` Robin Murphy
     [not found]         ` <5717805A.3070602-5wv7dgnIgG8@public.gmane.org>
2016-04-20 16:18           ` Eric Auger
     [not found]             ` <5717ABF2.1030204-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-04-22 13:05               ` Robin Murphy
2016-04-19 16:56   ` [PATCH v7 06/10] iommu/dma-reserved-iommu: iommu_get/put_reserved_iova Eric Auger
     [not found]     ` <1461084994-2355-7-git-send-email-eric.auger-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-04-20 16:58       ` Robin Murphy
     [not found]         ` <5717B541.7090003-5wv7dgnIgG8@public.gmane.org>
2016-04-21  8:43           ` Eric Auger
2016-04-19 16:56   ` [PATCH v7 08/10] iommu/dma-reserved_iommu: iommu_msi_mapping_desc_to_domain Eric Auger
     [not found]     ` <1461084994-2355-9-git-send-email-eric.auger-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-04-20 17:19       ` Robin Murphy
     [not found]         ` <5717BA3E.8050901-5wv7dgnIgG8@public.gmane.org>
2016-04-21  8:40           ` Eric Auger
2016-04-19 16:56   ` [PATCH v7 09/10] iommu/dma-reserved-iommu: iommu_msi_mapping_translate_msg Eric Auger
2016-04-20  9:38     ` Marc Zyngier
     [not found]       ` <57174E16.1050004-5wv7dgnIgG8@public.gmane.org>
2016-04-20 12:50         ` Eric Auger
     [not found]     ` <1461084994-2355-10-git-send-email-eric.auger-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-04-20 17:28       ` Robin Murphy
     [not found]         ` <5717BC43.5070005-5wv7dgnIgG8@public.gmane.org>
2016-04-21  8:40           ` Eric Auger
2016-04-19 16:56   ` [PATCH v7 10/10] iommu/arm-smmu: call iommu_free_reserved_iova_domain on domain destruction Eric Auger
     [not found]     ` <1461084994-2355-11-git-send-email-eric.auger-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-04-20 17:35       ` Robin Murphy
     [not found]         ` <5717BDF1.7030400-5wv7dgnIgG8@public.gmane.org>
2016-04-21  8:39           ` Eric Auger
2016-04-21 12:18   ` [PATCH v7 00/10] KVM PCIe/MSI passthrough on ARM/ARM64: kernel part 1/3: iommu changes Eric Auger
     [not found]     ` <5718C501.20906-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-04-21 19:32       ` Alex Williamson
     [not found]         ` <20160421133222.76e45596-1yVPhWWZRC1BDLzU/O5InQ@public.gmane.org>
2016-04-22 12:31           ` Eric Auger
     [not found]             ` <571A1996.5010009-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-04-22 19:07               ` Alex Williamson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1461084994-2355-8-git-send-email-eric.auger@linaro.org \
    --to=eric.auger@linaro.org \
    --cc=Bharat.Bhushan@freescale.com \
    --cc=Jean-Philippe.Brucker@arm.com \
    --cc=alex.williamson@redhat.com \
    --cc=christoffer.dall@linaro.org \
    --cc=eric.auger@st.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jason@lakedaemon.net \
    --cc=joro@8bytes.org \
    --cc=julien.grall@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=p.fedin@samsung.com \
    --cc=patches@linaro.org \
    --cc=pranav.sawargaonkar@gmail.com \
    --cc=robin.murphy@arm.com \
    --cc=tglx@linutronix.de \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).