iommu.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Yongji Xie <xyjxie-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
To: kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Cc: alistair-Y4h6yKqj69EXC2x5gXVKYQ@public.gmane.org,
	nikunj-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org,
	zhong-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org,
	eric.auger-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	aik-sLpHqDYs0B2HXe+LvDLADg@public.gmane.org,
	mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org,
	ruscur-3Su/lFKaw5ejKv3TNrM5DQ@public.gmane.org,
	will.deacon-5wv7dgnIgG8@public.gmane.org,
	gwshan-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org,
	warrier-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org,
	David.Laight-ZS65k/vG3HxXrIkS9f7CXA@public.gmane.org,
	paulus-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org,
	benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org,
	bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
	Yongji Xie
	<xyjxie-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Subject: [PATCH 5/5] vfio-pci: Allow to mmap MSI-X table if interrupt remapping is supported
Date: Wed, 27 Apr 2016 20:43:30 +0800	[thread overview]
Message-ID: <1461761010-5452-6-git-send-email-xyjxie@linux.vnet.ibm.com> (raw)
In-Reply-To: <1461761010-5452-1-git-send-email-xyjxie-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>

This patch enables mmapping MSI-X tables if hardware supports
interrupt remapping which can ensure that a given pci device
can only shoot the MSIs assigned for it.

With MSI-X table mmapped, we also need to expose the
read/write interface which will be used to access MSI-X table.

Signed-off-by: Yongji Xie <xyjxie-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
---
 drivers/vfio/pci/vfio_pci.c      |    7 +++++--
 drivers/vfio/pci/vfio_pci_rdwr.c |    3 ++-
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c
index 98059df..7eba77d 100644
--- a/drivers/vfio/pci/vfio_pci.c
+++ b/drivers/vfio/pci/vfio_pci.c
@@ -591,7 +591,9 @@ static long vfio_pci_ioctl(void *device_data,
 			    pci_resource_flags(pdev, info.index) &
 			    IORESOURCE_MEM && info.size >= PAGE_SIZE) {
 				info.flags |= VFIO_REGION_INFO_FLAG_MMAP;
-				if (info.index == vdev->msix_bar) {
+				if (info.index == vdev->msix_bar &&
+					!(pdev->bus->bus_flags &
+					PCI_BUS_FLAGS_MSI_REMAP)) {
 					ret = msix_sparse_mmap_cap(vdev, &caps);
 					if (ret)
 						return ret;
@@ -1023,7 +1025,8 @@ static int vfio_pci_mmap(void *device_data, struct vm_area_struct *vma)
 	if (phys_len < PAGE_SIZE || req_start + req_len > phys_len)
 		return -EINVAL;
 
-	if (index == vdev->msix_bar) {
+	if (index == vdev->msix_bar &&
+		!(pdev->bus->bus_flags & PCI_BUS_FLAGS_MSI_REMAP)) {
 		/*
 		 * Disallow mmaps overlapping the MSI-X table; users don't
 		 * get to touch this directly.  We could find somewhere
diff --git a/drivers/vfio/pci/vfio_pci_rdwr.c b/drivers/vfio/pci/vfio_pci_rdwr.c
index 5ffd1d9..dbf9cd0 100644
--- a/drivers/vfio/pci/vfio_pci_rdwr.c
+++ b/drivers/vfio/pci/vfio_pci_rdwr.c
@@ -164,7 +164,8 @@ ssize_t vfio_pci_bar_rw(struct vfio_pci_device *vdev, char __user *buf,
 	} else
 		io = vdev->barmap[bar];
 
-	if (bar == vdev->msix_bar) {
+	if (bar == vdev->msix_bar &&
+		!(pdev->bus->bus_flags & PCI_BUS_FLAGS_MSI_REMAP)) {
 		x_start = vdev->msix_offset;
 		x_end = vdev->msix_offset + vdev->msix_size;
 	}
-- 
1.7.9.5

  parent reply	other threads:[~2016-04-27 12:43 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-27 12:43 [PATCH 0/5] vfio-pci: Add support for mmapping MSI-X table Yongji Xie
2016-04-27 12:43 ` [PATCH 1/5] PCI: Add a new PCI_BUS_FLAGS_MSI_REMAP flag Yongji Xie
2016-05-24 20:55   ` Bjorn Helgaas
2016-05-25  5:46     ` Yongji Xie
2016-05-25  5:46     ` Yongji Xie
2016-05-25  5:46     ` Yongji Xie
2016-05-25  5:46     ` Yongji Xie
2016-05-25  5:46     ` Yongji Xie
2016-04-27 12:43 ` [PATCH 2/5] iommu: Set PCI_BUS_FLAGS_MSI_REMAP if IOMMU have capability of IRQ remapping Yongji Xie
2016-05-24 21:11   ` Bjorn Helgaas
2016-05-25  5:54     ` Yongji Xie
2016-05-25  5:54     ` Yongji Xie
2016-05-25  5:54     ` Yongji Xie
2016-05-25  5:54     ` Yongji Xie
2016-05-25  5:54     ` Yongji Xie
     [not found]     ` <201605250554.u4P5sRqv014439@mx0a-001b2d01.pphosted.com>
     [not found]       ` <201605250554.u4P5sRqv014439-QbrlkLqkJHK1JOh/WJROsbgYzuMpulrC0E9HWUfgJXw@public.gmane.org>
2016-05-26  3:48         ` Bjorn Helgaas
2016-04-27 12:43 ` [PATCH 3/5] PCI: Set PCI_BUS_FLAGS_MSI_REMAP if MSI controller supports " Yongji Xie
     [not found]   ` <1461761010-5452-4-git-send-email-xyjxie-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-05-24 21:04     ` Bjorn Helgaas
2016-05-25  5:48       ` Yongji Xie
2016-05-25  5:48       ` Yongji Xie
2016-05-25  5:48       ` Yongji Xie
2016-05-25  5:48       ` Yongji Xie
2016-05-25  5:48       ` Yongji Xie
     [not found] ` <1461761010-5452-1-git-send-email-xyjxie-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-04-27 12:43   ` [PATCH 4/5] pci-ioda: Set PCI_BUS_FLAGS_MSI_REMAP for IODA host bridge Yongji Xie
     [not found]     ` <1461761010-5452-5-git-send-email-xyjxie-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-05-06  6:34       ` Alexey Kardashevskiy
2016-04-27 12:43   ` Yongji Xie [this message]
2016-05-03  5:34     ` [PATCH 5/5] vfio-pci: Allow to mmap MSI-X table if interrupt remapping is supported Tian, Kevin
     [not found]       ` <AADFC41AFE54684AB9EE6CBC0274A5D15F842512-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2016-05-03  6:08         ` Yongji Xie
2016-05-03  6:22           ` Tian, Kevin
     [not found]             ` <AADFC41AFE54684AB9EE6CBC0274A5D15F842653-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2016-05-03  7:34               ` Yongji Xie
     [not found]                 ` <e064a6a7-a8dc-f71f-1725-f31e03581b8d-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-05-05  9:36                   ` Tian, Kevin
     [not found]                     ` <AADFC41AFE54684AB9EE6CBC0274A5D15F847150-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2016-05-05  9:54                       ` David Laight
     [not found]                         ` <063D6719AE5E284EB5DD2968C1650D6D5F4B52B5-VkEWCZq2GCInGFn1LkZF6NBPR1lH4CV8@public.gmane.org>
2016-05-05 11:42                           ` Yongji Xie
2016-05-05 12:15                             ` Tian, Kevin
     [not found]                               ` <AADFC41AFE54684AB9EE6CBC0274A5D15F8474A4-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2016-05-05 13:28                                 ` Yongji Xie
2016-05-05 15:05                               ` Alex Williamson
     [not found]                                 ` <20160505090513.56886c12-1yVPhWWZRC1BDLzU/O5InQ@public.gmane.org>
2016-05-06  6:35                                   ` Alexey Kardashevskiy
     [not found]                                     ` <fa5555df-b8d2-70ea-e9af-81336c431a67-sLpHqDYs0B2HXe+LvDLADg@public.gmane.org>
2016-05-06 16:54                                       ` Alex Williamson
2016-05-11  6:29                                   ` Tian, Kevin
     [not found]                                     ` <AADFC41AFE54684AB9EE6CBC0274A5D15F84EEBA-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2016-05-11 15:53                                       ` Alex Williamson
     [not found]                                         ` <20160511095331.18436241-1yVPhWWZRC1BDLzU/O5InQ@public.gmane.org>
2016-05-12  1:19                                           ` Tian, Kevin
     [not found]                                             ` <AADFC41AFE54684AB9EE6CBC0274A5D15F850046-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2016-05-12  2:20                                               ` Alex Williamson
     [not found]                                                 ` <20160511202042.77593861-1yVPhWWZRC1BDLzU/O5InQ@public.gmane.org>
2016-05-12  4:53                                                   ` Tian, Kevin
2016-05-12 17:47                                                     ` Alex Williamson
2016-05-13  2:33                                                       ` Tian, Kevin
2016-05-13  5:32                                                         ` Alex Williamson
     [not found]                                                           ` <20160512233246.347b8b3c-1yVPhWWZRC1BDLzU/O5InQ@public.gmane.org>
2016-05-13  6:50                                                             ` Tian, Kevin
     [not found]                                                               ` <AADFC41AFE54684AB9EE6CBC0274A5D15F854287-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2016-05-13 16:42                                                                 ` Alex Williamson
2016-05-13  9:16                                                             ` David Laight
2016-05-13  2:36                                                       ` Tian, Kevin
2016-05-05 11:44                     ` Yongji Xie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1461761010-5452-6-git-send-email-xyjxie@linux.vnet.ibm.com \
    --to=xyjxie-23vcf4htsmix0ybbhkvfkdbpr1lh4cv8@public.gmane.org \
    --cc=David.Laight-ZS65k/vG3HxXrIkS9f7CXA@public.gmane.org \
    --cc=aik-sLpHqDYs0B2HXe+LvDLADg@public.gmane.org \
    --cc=alistair-Y4h6yKqj69EXC2x5gXVKYQ@public.gmane.org \
    --cc=benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org \
    --cc=bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=eric.auger-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=gwshan-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org \
    --cc=nikunj-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
    --cc=paulus-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org \
    --cc=ruscur-3Su/lFKaw5ejKv3TNrM5DQ@public.gmane.org \
    --cc=warrier-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
    --cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
    --cc=zhong-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).