From: Baoquan He <bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org
Cc: kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Vincent.Wan-5C7GfCeVMHo@public.gmane.org,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Subject: [PATCH v5 7/8] iommu/amd: Don't update domain info to dte entry at iommu init stage
Date: Thu, 15 Sep 2016 23:03:25 +0800 [thread overview]
Message-ID: <1473951806-25511-8-git-send-email-bhe@redhat.com> (raw)
In-Reply-To: <1473951806-25511-1-git-send-email-bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
AMD iommu creates protection domain and assign each device to it during
iommu driver initialization stage. This happened just after system pci
bus scanning stage, and much earlier than device driver init stage. So
at this time if in kdump kernel the domain info, especially pte_root,
can't be updated to dte entry. We should wait until device driver init
stage.
Signed-off-by: Baoquan He <bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
---
drivers/iommu/amd_iommu.c | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
index fcb69ff..6c37300 100644
--- a/drivers/iommu/amd_iommu.c
+++ b/drivers/iommu/amd_iommu.c
@@ -137,6 +137,7 @@ struct iommu_dev_data {
bool pri_tlp; /* PASID TLB required for
PPR completions */
u32 errata; /* Bitmap for errata to apply */
+ bool domain_updated;
};
/*
@@ -1708,6 +1709,15 @@ static void set_dte_entry(u16 devid, struct protection_domain *domain, bool ats)
{
u64 pte_root = 0;
u64 flags = 0;
+ struct iommu_dev_data *dev_data;
+ struct amd_iommu *iommu = amd_iommu_rlookup_table[devid];
+
+ dev_data = find_dev_data(devid);
+ if (!dev_data)
+ return;
+
+ if (translation_pre_enabled(iommu) && !dev_data->domain_updated)
+ return;
if (domain->mode != PAGE_MODE_NONE)
pte_root = virt_to_phys(domain->pt_root);
@@ -1756,6 +1766,14 @@ static void set_dte_entry(u16 devid, struct protection_domain *domain, bool ats)
static void clear_dte_entry(u16 devid)
{
+ struct iommu_dev_data *dev_data;
+ struct amd_iommu *iommu = amd_iommu_rlookup_table[devid];
+
+ dev_data = find_dev_data(devid);
+ if (!dev_data)
+ return;
+ if (translation_pre_enabled(iommu) && !dev_data->domain_updated)
+ return;
/* remove entry from the device table seen by the hardware */
amd_iommu_dev_table[devid].data[0] = DTE_FLAG_V | DTE_FLAG_TV;
amd_iommu_dev_table[devid].data[1] &= DTE_FLAG_MASK;
--
2.5.5
next prev parent reply other threads:[~2016-09-15 15:03 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-15 15:03 [PATCH v5 0/8] Fix kdump faults on system with amd iommu Baoquan He
[not found] ` <1473951806-25511-1-git-send-email-bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-09-15 15:03 ` [PATCH v5 1/8] iommu/amd: Detect pre enabled translation Baoquan He
2016-09-15 15:03 ` [PATCH v5 2/8] iommu/amd: add early_enable_iommu() wrapper function Baoquan He
2016-09-15 15:03 ` [PATCH v5 3/8] iommu/amd: Define bit fields for DTE particularly Baoquan He
2016-09-15 15:03 ` [PATCH v5 4/8] iommu/amd: Add function copy_dev_tables Baoquan He
2016-09-20 11:58 ` Joerg Roedel
[not found] ` <20160920115804.GC3541-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2016-09-21 10:17 ` Baoquan He
2016-09-15 15:03 ` [PATCH v5 5/8] iommu/amd: copy old trans table from old kernel Baoquan He
[not found] ` <1473951806-25511-6-git-send-email-bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-09-20 12:40 ` Joerg Roedel
[not found] ` <20160920124031.GD3541-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2016-09-21 10:18 ` Baoquan He
2016-09-28 1:37 ` Baoquan He
[not found] ` <20160928013702.GH14155-ejN7fcUYdH/by3iVrkZq2A@public.gmane.org>
2016-09-28 13:01 ` Baoquan He
2016-09-15 15:03 ` [PATCH v5 6/8] iommu/amd: Do not re-enable dev table entries in kdump Baoquan He
[not found] ` <1473951806-25511-7-git-send-email-bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-09-20 12:42 ` Joerg Roedel
[not found] ` <20160920124241.GE3541-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2016-09-21 10:20 ` Baoquan He
2016-09-15 15:03 ` Baoquan He [this message]
[not found] ` <1473951806-25511-8-git-send-email-bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-09-20 12:50 ` [PATCH v5 7/8] iommu/amd: Don't update domain info to dte entry at iommu init stage Joerg Roedel
2016-09-21 10:26 ` Baoquan He
[not found] ` <20160921102613.GD13350-ejN7fcUYdH/by3iVrkZq2A@public.gmane.org>
2016-09-21 13:21 ` Baoquan He
2016-09-15 15:03 ` [PATCH v5 8/8] iommu/amd: Update domain into to dte entry during device driver init Baoquan He
2016-09-20 12:53 ` Joerg Roedel
[not found] ` <20160920125330.GG3541-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2016-09-21 10:31 ` Baoquan He
2016-09-27 1:51 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473951806-25511-8-git-send-email-bhe@redhat.com \
--to=bhe-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=Vincent.Wan-5C7GfCeVMHo@public.gmane.org \
--cc=dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org \
--cc=kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).