iommu.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Eric Auger <eric.auger@redhat.com>
To: eric.auger@redhat.com, eric.auger.pro@gmail.com,
	christoffer.dall@linaro.org, marc.zyngier@arm.com,
	robin.murphy@arm.com, alex.williamson@redhat.com,
	will.deacon@arm.com, joro@8bytes.org, tglx@linutronix.de,
	jason@lakedaemon.net, linux-arm-kernel@lists.infradead.org
Cc: kvm@vger.kernel.org, drjones@redhat.com,
	linux-kernel@vger.kernel.org, pranav.sawargaonkar@gmail.com,
	iommu@lists.linux-foundation.org, punit.agrawal@arm.com,
	diana.craciun@nxp.com
Subject: [RFC 6/8] iommu: Handle the list of reserved regions
Date: Thu,  3 Nov 2016 21:39:36 +0000	[thread overview]
Message-ID: <1478209178-3009-7-git-send-email-eric.auger@redhat.com> (raw)
In-Reply-To: <1478209178-3009-1-git-send-email-eric.auger@redhat.com>

A new callback is introduced, add_reserved_regions. This function
aims at populating the iommu domain reserved region list with
regions associated with the device. The function is called on
device attachment. The list is freed on iommu_domain_free().

Signed-off-by: Eric Auger <eric.auger@redhat.com>
---
 drivers/iommu/iommu.c | 23 +++++++++++++++++++++++
 include/linux/iommu.h |  6 ++++++
 2 files changed, 29 insertions(+)

diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
index 0af07492..300af44 100644
--- a/drivers/iommu/iommu.c
+++ b/drivers/iommu/iommu.c
@@ -1077,6 +1077,10 @@ struct iommu_domain *iommu_domain_alloc(struct bus_type *bus)
 
 void iommu_domain_free(struct iommu_domain *domain)
 {
+	struct iommu_reserved_region *entry, *next;
+
+	list_for_each_entry_safe(entry, next, &domain->reserved_regions, list)
+		kfree(entry);
 	domain->ops->domain_free(domain);
 }
 EXPORT_SYMBOL_GPL(iommu_domain_free);
@@ -1089,6 +1093,15 @@ static int __iommu_attach_device(struct iommu_domain *domain,
 		return -ENODEV;
 
 	ret = domain->ops->attach_dev(domain, dev);
+	if (ret)
+		return ret;
+
+	if (domain->type == IOMMU_DOMAIN_UNMANAGED) {
+		mutex_lock(&domain->resv_mutex);
+		ret = iommu_add_reserved_regions(domain, dev);
+		mutex_unlock(&domain->resv_mutex);
+	}
+
 	if (!ret)
 		trace_attach_device_to_domain(dev);
 	return ret;
@@ -1548,6 +1561,16 @@ int iommu_domain_set_attr(struct iommu_domain *domain,
 }
 EXPORT_SYMBOL_GPL(iommu_domain_set_attr);
 
+int iommu_add_reserved_regions(struct iommu_domain *domain, struct device *dev)
+{
+	const struct iommu_ops *ops = dev->bus->iommu_ops;
+
+	if (ops && ops->add_reserved_regions)
+		return ops->add_reserved_regions(domain, dev);
+	else
+		return 0;
+}
+
 void iommu_get_dm_regions(struct device *dev, struct list_head *list)
 {
 	const struct iommu_ops *ops = dev->bus->iommu_ops;
diff --git a/include/linux/iommu.h b/include/linux/iommu.h
index 0f2eb64..7748a1b 100644
--- a/include/linux/iommu.h
+++ b/include/linux/iommu.h
@@ -170,6 +170,7 @@ struct iommu_reserved_region {
  * @get_dm_regions: Request list of direct mapping requirements for a device
  * @put_dm_regions: Free list of direct mapping requirements for a device
  * @apply_dm_region: Temporary helper call-back for iova reserved ranges
+ * @add_reserved_regions: Populate reserved regions for a device
  * @domain_window_enable: Configure and enable a particular window for a domain
  * @domain_window_disable: Disable a particular window for a domain
  * @domain_set_windows: Set the number of windows for a domain
@@ -207,6 +208,10 @@ struct iommu_ops {
 	void (*apply_dm_region)(struct device *dev, struct iommu_domain *domain,
 				struct iommu_dm_region *region);
 
+	/* Add reserved regions for a device */
+	int (*add_reserved_regions)(struct iommu_domain *domain,
+				     struct device *device);
+
 	/* Window handling functions */
 	int (*domain_window_enable)(struct iommu_domain *domain, u32 wnd_nr,
 				    phys_addr_t paddr, u64 size, int prot);
@@ -289,6 +294,7 @@ struct device *iommu_device_create(struct device *parent, void *drvdata,
 void iommu_device_destroy(struct device *dev);
 int iommu_device_link(struct device *dev, struct device *link);
 void iommu_device_unlink(struct device *dev, struct device *link);
+int iommu_add_reserved_regions(struct iommu_domain *domain, struct device *dev);
 
 /* Window handling function prototypes */
 extern int iommu_domain_window_enable(struct iommu_domain *domain, u32 wnd_nr,
-- 
1.9.1

  parent reply	other threads:[~2016-11-03 21:39 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-03 21:39 [RFC 0/8] KVM PCIe/MSI passthrough on ARM/ARM64 (Alt II) Eric Auger
     [not found] ` <1478209178-3009-1-git-send-email-eric.auger-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-11-03 21:39   ` [RFC 1/8] vfio: fix vfio_info_cap_add/shift Eric Auger
2016-11-03 21:39   ` [RFC 2/8] iommu/iova: fix __alloc_and_insert_iova_range Eric Auger
2016-11-03 21:39   ` [RFC 3/8] iommu/dma: Allow MSI-only cookies Eric Auger
2016-11-03 21:39   ` [RFC 5/8] vfio/type1: Introduce RESV_IOVA_RANGE capability Eric Auger
2016-11-03 21:39   ` [RFC 8/8] iommu/arm-smmu: implement add_reserved_regions callback Eric Auger
2016-11-04  4:02   ` [RFC 0/8] KVM PCIe/MSI passthrough on ARM/ARM64 (Alt II) Alex Williamson
2016-11-08  2:45     ` Summary of LPC guest MSI discussion in Santa Fe (was: Re: [RFC 0/8] KVM PCIe/MSI passthrough on ARM/ARM64 (Alt II)) Will Deacon
2016-11-08 14:27       ` Summary of LPC guest MSI discussion in Santa Fe Auger Eric
     [not found]         ` <dae12190-1eb6-20a9-5740-9e5be8bb65fc-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-11-08 17:54           ` Will Deacon
     [not found]             ` <20161108175457.GK20591-5wv7dgnIgG8@public.gmane.org>
2016-11-08 19:02               ` Don Dutile
2016-11-08 19:10                 ` Will Deacon
     [not found]                 ` <5822214F.2070500-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-11-09  7:43                   ` Auger Eric
2016-11-08 16:02       ` Don Dutile
     [not found]       ` <20161108024559.GA20591-5wv7dgnIgG8@public.gmane.org>
2016-11-08 20:29         ` Summary of LPC guest MSI discussion in Santa Fe (was: Re: [RFC 0/8] KVM PCIe/MSI passthrough on ARM/ARM64 (Alt II)) Christoffer Dall
2016-11-08 23:35           ` Alex Williamson
     [not found]             ` <20161108163508.1bcae0c2-1yVPhWWZRC1BDLzU/O5InQ@public.gmane.org>
2016-11-09  2:52               ` Summary of LPC guest MSI discussion in Santa Fe Don Dutile
     [not found]                 ` <58228F71.6020108-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-11-09 17:03                   ` Will Deacon
2016-11-09 18:59                     ` Don Dutile
     [not found]                       ` <582371FB.2040808-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-11-09 19:23                         ` Christoffer Dall
2016-11-09 20:01                           ` Alex Williamson
2016-11-10 14:40                             ` Joerg Roedel
     [not found]                               ` <20161110144007.GC2078-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2016-11-10 17:07                                 ` Alex Williamson
2016-11-09 20:31                           ` Will Deacon
     [not found]                             ` <20161109203145.GO17771-5wv7dgnIgG8@public.gmane.org>
2016-11-09 22:17                               ` Alex Williamson
     [not found]                                 ` <20161109151709.74927f83-1yVPhWWZRC1BDLzU/O5InQ@public.gmane.org>
2016-11-09 22:25                                   ` Will Deacon
     [not found]                                     ` <20161109222522.GS17771-5wv7dgnIgG8@public.gmane.org>
2016-11-09 23:24                                       ` Alex Williamson
2016-11-09 23:38                                         ` Will Deacon
     [not found]                                           ` <20161109233847.GT17771-5wv7dgnIgG8@public.gmane.org>
2016-11-09 23:59                                             ` Alex Williamson
2016-11-10  0:14                                               ` Auger Eric
     [not found]                                                 ` <83b6440a-31eb-c1b4-642c-a4c311f37ef2-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-11-10  0:55                                                   ` Alex Williamson
2016-11-10  2:01                                                     ` Will Deacon
     [not found]                                                       ` <20161110020130.GA19108-5wv7dgnIgG8@public.gmane.org>
2016-11-10 11:14                                                         ` Auger Eric
     [not found]                                                           ` <ddd8af9d-ad8f-78d8-3048-3d640b74470e-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-11-10 17:46                                                             ` Alex Williamson
2016-11-11 11:19                                                               ` Joerg Roedel
     [not found]                                                                 ` <20161111111944.GO2078-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2016-11-11 15:50                                                                   ` Alex Williamson
     [not found]                                                                     ` <20161111085056.4cf8989d-1yVPhWWZRC1BDLzU/O5InQ@public.gmane.org>
2016-11-11 16:05                                                                       ` Alex Williamson
2016-11-14 15:19                                                                         ` Joerg Roedel
2016-11-11 16:25                                                                       ` Don Dutile
2016-11-11 16:00                                                                   ` Don Dutile
2016-11-10 14:52                                                 ` Joerg Roedel
2016-11-09 20:11                       ` Robin Murphy
     [not found]                         ` <e59e9a17-e943-a227-5ea4-d028232155a8-5wv7dgnIgG8@public.gmane.org>
2016-11-10 15:18                           ` Joerg Roedel
2016-11-21  5:13       ` Jon Masters
     [not found]         ` <83d7bf8e-1aa9-b61b-4e83-ba9da1926d19-Zp4isUonpHBD60Wz+7aTrA@public.gmane.org>
2016-11-23 20:12           ` Don Dutile
2016-11-03 21:39 ` [RFC 4/8] iommu: Add a list of iommu_reserved_region in iommu_domain Eric Auger
2016-11-03 21:39 ` Eric Auger [this message]
2016-11-03 21:39 ` [RFC 7/8] iommu/vt-d: Implement add_reserved_regions callback Eric Auger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1478209178-3009-7-git-send-email-eric.auger@redhat.com \
    --to=eric.auger@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=christoffer.dall@linaro.org \
    --cc=diana.craciun@nxp.com \
    --cc=drjones@redhat.com \
    --cc=eric.auger.pro@gmail.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jason@lakedaemon.net \
    --cc=joro@8bytes.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=pranav.sawargaonkar@gmail.com \
    --cc=punit.agrawal@arm.com \
    --cc=robin.murphy@arm.com \
    --cc=tglx@linutronix.de \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).