From: Baoquan He <bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH v7 RESEND 10/12] iommu/amd: Allocate memory below 4G for dev table if translation pre-enabled
Date: Mon, 2 Jan 2017 15:39:56 +0800 [thread overview]
Message-ID: <1483342798-6542-11-git-send-email-bhe@redhat.com> (raw)
In-Reply-To: <1483342798-6542-1-git-send-email-bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
AMD pointed out it's unsafe to update the device-table while iommu
is enabled. It turns out that device-table pointer update is split
up into two 32bit writes in the IOMMU hardware. So updating it while
the IOMMU is enabled could have some nasty side effects.
The only way to work around this is to allocate the device-table below
4GB if translation is pre-enabled in kdump kernel. If allocation failed,
still use the old one.
Suggested-by: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
Signed-off-by: Baoquan He <bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
---
drivers/iommu/amd_iommu_init.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/iommu/amd_iommu_init.c b/drivers/iommu/amd_iommu_init.c
index 9186f8b..73b74ba 100644
--- a/drivers/iommu/amd_iommu_init.c
+++ b/drivers/iommu/amd_iommu_init.c
@@ -2139,11 +2139,23 @@ static void early_enable_iommu(struct amd_iommu *iommu)
*/
static void early_enable_iommus(void)
{
+ struct dev_table_entry *dev_tbl;
struct amd_iommu *iommu;
bool is_pre_enabled = false;
for_each_iommu(iommu) {
if (translation_pre_enabled(iommu)) {
+ gfp_t gfp_flag = GFP_KERNEL | __GFP_ZERO | GFP_DMA32;;
+
+ dev_tbl = (void *)__get_free_pages(gfp_flag,
+ get_order(dev_table_size));
+ if (dev_tbl != NULL) {
+ memcpy(dev_tbl, amd_iommu_dev_table, dev_table_size);
+ free_pages((unsigned long)amd_iommu_dev_table,
+ get_order(dev_table_size));
+ amd_iommu_dev_table = dev_tbl;
+ }
+
is_pre_enabled = true;
break;
}
--
2.5.5
next prev parent reply other threads:[~2017-01-02 7:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-02 7:39 [PATCH v7 RESEND 00/12] Fix kdump faults on system with amd iommu Baoquan He
[not found] ` <1483342798-6542-1-git-send-email-bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-01-02 7:39 ` [PATCH v7 RESEND 01/12] iommu/amd: Detect pre enabled translation Baoquan He
2017-01-02 7:39 ` [PATCH v7 RESEND 02/12] iommu/amd: add several helper function Baoquan He
2017-01-02 7:39 ` [PATCH v7 RESEND 03/12] iommu/amd: Define bit fields for DTE particularly Baoquan He
2017-01-02 7:39 ` [PATCH v7 RESEND 04/12] iommu/amd: Add function copy_dev_tables Baoquan He
2017-01-02 7:39 ` [PATCH v7 RESEND 05/12] iommu/amd: copy old trans table from old kernel Baoquan He
2017-01-02 7:39 ` [PATCH v7 RESEND 06/12] iommu: Add is_attach_deferred call-back to iommu-ops Baoquan He
2017-01-02 7:39 ` [PATCH v7 RESEND 07/12] iommu/amd: Use is_attach_deferred call-back Baoquan He
2017-01-02 7:39 ` [PATCH v7 RESEND 08/12] iommu/amd: Add sanity check of irq remap information of old dev table entry Baoquan He
2017-01-02 7:39 ` [PATCH v7 RESEND 09/12] iommu: Assign the direct mapped domain to group->domain Baoquan He
2017-01-02 7:39 ` Baoquan He [this message]
2017-01-02 7:39 ` [PATCH v7 RESEND 11/12] iommu/amd: Don't copy GCR3 table root pointer Baoquan He
2017-01-02 7:39 ` [PATCH v7 RESEND 12/12] iommu/amd: Clear out the GV flag when handle deferred domain attach Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1483342798-6542-11-git-send-email-bhe@redhat.com \
--to=bhe-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox