From: Anup Patel <anup.patel@broadcom.com>
To: Will Deacon <will.deacon@arm.com>,
Robin Murphy <robin.murphy@arm.com>,
Joerg Roedel <joro@8bytes.org>,
Baptiste Reynal <b.reynal@virtualopensystems.com>,
Alex Williamson <alex.williamson@redhat.com>
Cc: Scott Branden <sbranden@broadcom.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
iommu@lists.linux-foundation.org, kvm@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
Anup Patel <anup.patel@broadcom.com>
Subject: [PATCH 4/5] vfio: Allow No-IOMMU mode for IOMMUs with bypass capability
Date: Wed, 19 Jul 2017 15:03:57 +0530 [thread overview]
Message-ID: <1500456838-18405-5-git-send-email-anup.patel@broadcom.com> (raw)
In-Reply-To: <1500456838-18405-1-git-send-email-anup.patel@broadcom.com>
Not allowing No-IOMMU mode for devices already having
iommu_ops on their bus is little conservative.
We now have IOMMU (such as ARM SMMU) which can bypass
transcations for which IOMMU domain is not configured
hence No-IOMMU mode should not be allowed when iommu_ops
are available and IOMMU_CAP_BYPASS is not available.
Signed-off-by: Anup Patel <anup.patel@broadcom.com>
---
drivers/vfio/vfio.c | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/drivers/vfio/vfio.c b/drivers/vfio/vfio.c
index 330d505..61f3807 100644
--- a/drivers/vfio/vfio.c
+++ b/drivers/vfio/vfio.c
@@ -124,11 +124,18 @@ struct iommu_group *vfio_iommu_group_get(struct device *dev)
#ifdef CONFIG_VFIO_NOIOMMU
/*
* With noiommu enabled, an IOMMU group will be created for a device
- * that doesn't already have one and doesn't have an iommu_ops on their
- * bus. We set iommudata simply to be able to identify these groups
+ * that:
+ * 1. Doesn't already have IOMMU group
+ * 2. Doesn't have an iommu_ops on their bus
+ * 3. Doesn't have transaction bypass capability if iommu_ops
+ * is available on their bus
+ *
+ * We set iommudata simply to be able to identify these groups
* as special use and for reclamation later.
*/
- if (group || !noiommu || iommu_present(dev->bus))
+ if (group || !noiommu ||
+ (iommu_present(dev->bus) &&
+ !iommu_capable(dev->bus, IOMMU_CAP_BYPASS)))
return group;
group = iommu_group_alloc();
--
2.7.4
next prev parent reply other threads:[~2017-07-19 9:33 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-19 9:33 [PATCH 0/5] FlexRM support in VFIO platform Anup Patel via iommu
2017-07-19 9:33 ` [PATCH 1/5] iommu: Add capability IOMMU_CAP_BYPASS Anup Patel
[not found] ` <1500456838-18405-2-git-send-email-anup.patel-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2017-07-19 10:58 ` Robin Murphy
2017-07-19 11:19 ` Anup Patel
[not found] ` <CAALAos_o25mtphxcVE0rr9dE8YAm-os2C_HD9oDnt41ZMDP8pA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-07-19 11:23 ` Will Deacon
2017-07-19 11:26 ` Anup Patel
[not found] ` <CAALAos8nf-d5i74J7-sAJb2o9eFj2PVDeLLVd=wun+gW1ihXSA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-07-19 11:29 ` Robin Murphy
2017-07-19 11:30 ` Will Deacon
[not found] ` <20170719113017.GH13642-5wv7dgnIgG8@public.gmane.org>
2017-07-19 11:33 ` Anup Patel via iommu
2017-07-19 9:33 ` [PATCH 2/5] iommu/arm-smmu: add IOMMU_CAP_BYPASS to the ARM SMMU driver Anup Patel
[not found] ` <1500456838-18405-3-git-send-email-anup.patel-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2017-07-19 10:59 ` Robin Murphy
2017-07-19 9:33 ` Anup Patel [this message]
[not found] ` <1500456838-18405-1-git-send-email-anup.patel-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2017-07-19 9:33 ` [PATCH 3/5] iommu/arm-smmu-v3: add IOMMU_CAP_BYPASS to the ARM SMMUv3 driver Anup Patel via iommu
2017-07-19 11:00 ` Robin Murphy
[not found] ` <ace28bd1-2dd3-482c-d11b-539c055ee9b7-5wv7dgnIgG8@public.gmane.org>
2017-07-19 11:23 ` Anup Patel via iommu
[not found] ` <CAALAos8y0kLGrbwgz3u=ZVyteSicuPyQZ3Yp=LPZohXzVaE5NQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-07-19 11:25 ` Will Deacon
[not found] ` <20170719112524.GF13642-5wv7dgnIgG8@public.gmane.org>
2017-07-19 11:31 ` Anup Patel via iommu
[not found] ` <CAALAos_xGCt7U1Oz5uCf9Q4hP6fdn4fcymFNQP5xO_UBduSY3g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-07-19 11:33 ` Will Deacon
2017-07-19 11:39 ` Anup Patel
[not found] ` <CAALAos99HWLoW=0P-dvFA+oNsF03TRNzNbfppyQNtqmcRELXXQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-07-19 11:53 ` Will Deacon
[not found] ` <20170719115333.GJ13642-5wv7dgnIgG8@public.gmane.org>
2017-07-20 4:02 ` Anup Patel via iommu
[not found] ` <CAALAos-YbVbgvPmDYXeWaF4y8MQ9i7CG3tgGuf-QLR6hmXo18Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-07-20 9:10 ` Will Deacon
[not found] ` <20170720091003.GA17837-5wv7dgnIgG8@public.gmane.org>
2017-07-20 11:08 ` Anup Patel via iommu
[not found] ` <CAALAos8571-UVp7Ky81qFESVcNcWx_H2VOemFt_++NFCxcMg3w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-07-20 11:17 ` Will Deacon
2017-07-20 11:17 ` Robin Murphy
[not found] ` <8e82d8f5-e5e2-dd09-c774-29f9eda2ecdd-5wv7dgnIgG8@public.gmane.org>
2017-07-24 17:16 ` Alex Williamson
[not found] ` <20170724111621.7f1c3a85-DGNDKt5SQtizQB+pC5nmwQ@public.gmane.org>
2017-07-24 17:23 ` Robin Murphy
[not found] ` <6468f359-1682-b9b0-5a4d-72738939cb84-5wv7dgnIgG8@public.gmane.org>
2017-07-24 19:06 ` Alex Williamson
2017-07-25 8:59 ` Anup Patel
2017-07-19 9:33 ` [PATCH 5/5] vfio: platform: reset: Add Broadcom FlexRM reset module Anup Patel via iommu
[not found] ` <1500456838-18405-6-git-send-email-anup.patel-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2017-07-19 16:50 ` Scott Branden via iommu
[not found] ` <27236534-a9fb-53bc-f0c6-eb674833a94e-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2017-07-20 4:05 ` Anup Patel via iommu
2017-07-19 10:57 ` [PATCH 0/5] FlexRM support in VFIO platform Robin Murphy
[not found] ` <0dc860ed-a40c-1bfd-f584-225807edb25b-5wv7dgnIgG8@public.gmane.org>
2017-07-19 11:17 ` Anup Patel via iommu
2017-07-19 11:25 ` Robin Murphy
[not found] ` <d4ef45d5-43cc-c632-082d-a92b8681faee-5wv7dgnIgG8@public.gmane.org>
2017-07-19 11:28 ` Anup Patel via iommu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1500456838-18405-5-git-send-email-anup.patel@broadcom.com \
--to=anup.patel@broadcom.com \
--cc=alex.williamson@redhat.com \
--cc=b.reynal@virtualopensystems.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=sbranden@broadcom.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).