iommu.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Baoquan He <bhe@redhat.com>
To: jroedel@suse.de
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
	Baoquan He <bhe@redhat.com>
Subject: [PATCH v9 13/13] iommu/amd: Disable iommu only if amd_iommu=off is specified
Date: Tue,  1 Aug 2017 19:37:29 +0800	[thread overview]
Message-ID: <1501587449-9817-14-git-send-email-bhe@redhat.com> (raw)
In-Reply-To: <1501587449-9817-1-git-send-email-bhe@redhat.com>

It's ok to disable iommu in normal kernel. While there's no need
to disable it in kdump kernel after the on-flight dma issue has
heen fixed.

Signed-off-by: Baoquan He <bhe@redhat.com>
---
 drivers/iommu/amd_iommu_init.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/iommu/amd_iommu_init.c b/drivers/iommu/amd_iommu_init.c
index cada2e302761..5015d61c1dcf 100644
--- a/drivers/iommu/amd_iommu_init.c
+++ b/drivers/iommu/amd_iommu_init.c
@@ -2502,7 +2502,8 @@ static int __init early_amd_iommu_init(void)
 		goto out;
 
 	/* Disable any previously enabled IOMMUs */
-	disable_iommus();
+	if (amd_iommu_disabled)
+		disable_iommus();
 
 	if (amd_iommu_irq_remap)
 		amd_iommu_irq_remap = check_ioapic_information();
-- 
2.5.5

      parent reply	other threads:[~2017-08-01 11:37 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-01 11:37 [PATCH v9 00/13] Fix the on-flight DMA issue on system with amd iommu Baoquan He
2017-08-01 11:37 ` [PATCH v9 01/13] iommu/amd: Detect pre enabled translation Baoquan He
2017-08-01 11:37 ` [PATCH v9 02/13] iommu/amd: add several helper functions Baoquan He
2017-08-01 11:37 ` [PATCH v9 03/13] Revert "iommu/amd: Suppress IO_PAGE_FAULTs in kdump kernel" Baoquan He
2017-08-01 11:37 ` [PATCH v9 04/13] iommu/amd: Define bit fields for DTE particularly Baoquan He
2017-08-01 11:37 ` [PATCH v9 06/13] iommu/amd: copy old trans table from old kernel Baoquan He
2017-08-04 12:21   ` Joerg Roedel
2017-08-04 13:09     ` Baoquan He
2017-08-01 11:37 ` [PATCH v9 07/13] iommu/amd: Do sanity check for address translation and irq remap of old dev table entry Baoquan He
     [not found] ` <1501587449-9817-1-git-send-email-bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-08-01 11:37   ` [PATCH v9 05/13] iommu/amd: Add function copy_dev_tables() Baoquan He
2017-08-04 12:09     ` Joerg Roedel
2017-08-04 12:21       ` Baoquan He
2017-08-04 12:30       ` Baoquan He
2017-08-04 12:51         ` Joerg Roedel
     [not found]           ` <20170804125159.GY3431-l3A5Bk7waGM@public.gmane.org>
2017-08-04 13:00             ` Baoquan He
2017-08-01 11:37   ` [PATCH v9 08/13] iommu: Add is_attach_deferred call-back to iommu-ops Baoquan He
2017-08-01 11:37 ` [PATCH v9 09/13] iommu/amd: Use is_attach_deferred call-back Baoquan He
2017-08-01 11:37 ` [PATCH v9 10/13] iommu/amd: Allocate memory below 4G for dev table if translation pre-enabled Baoquan He
2017-08-04 12:25   ` Joerg Roedel
     [not found]     ` <20170804122524.GV3431-l3A5Bk7waGM@public.gmane.org>
2017-08-04 13:01       ` Baoquan He
2017-08-01 11:37 ` [PATCH v9 11/13] iommu/amd: Don't copy GCR3 table root pointer Baoquan He
2017-08-04 12:27   ` Joerg Roedel
2017-08-01 11:37 ` [PATCH v9 12/13] iommu/amd: Clear out the GV flag when handle deferred domain attach Baoquan He
2017-08-04 12:30   ` Joerg Roedel
2017-08-04 13:13     ` Baoquan He
2017-08-04 13:18       ` Joerg Roedel
2017-08-01 11:37 ` Baoquan He [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1501587449-9817-14-git-send-email-bhe@redhat.com \
    --to=bhe@redhat.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jroedel@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).