From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v6 1/5] iommu/vt-d: Add debugfs support for Intel IOMMU internals Date: Wed, 10 Jan 2018 15:32:46 +0200 Message-ID: <1515591166.7000.860.camel@linux.intel.com> References: <1515556102-34150-1-git-send-email-sohil.mehta@intel.com> <1515556102-34150-2-git-send-email-sohil.mehta@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1515556102-34150-2-git-send-email-sohil.mehta-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Sohil Mehta , Joerg Roedel , Alex Williamson Cc: Ravi V Shankar , Fenghua Yu , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, David Woodhouse , Gayatri Kammela List-Id: iommu@lists.linux-foundation.org On Tue, 2018-01-09 at 19:48 -0800, Sohil Mehta wrote: > From: Gayatri Kammela > > Enable Intel IOMMU debug to export Intel IOMMU internals in debugfs > +config INTEL_IOMMU_DEBUG > + bool "Export Intel IOMMU internals in DebugFS" > + depends on INTEL_IOMMU && DEBUG_FS > + default n I thought I commented on this... Please, remove. "n" is default default, so no need to duplicate it. > + help > + IOMMU internal states such as context, PASID tables can be > seen via > + debugfs. Select this option if you want to export these > internals. > + > + Say Y if you need this. Also I lost a track how this option is being used here. It looks like this part is not related to the patch itself. -- Andy Shevchenko Intel Finland Oy