From: "Mehta, Sohil" <sohil.mehta-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: "gary.hook-5C7GfCeVMHo@public.gmane.org"
<gary.hook-5C7GfCeVMHo@public.gmane.org>,
"iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org"
<iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
Cc: "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v3 1/2] iommu - Enable debugfs exposure of the IOMMU
Date: Fri, 13 Apr 2018 23:55:13 +0000 [thread overview]
Message-ID: <1523663790.2747.4.camel@intel.com> (raw)
In-Reply-To: <152302066417.47565.4017200105445420643.stgit-tq90VzyE+wXkLsZ8J5Uweg@public.gmane.org>
On Fri, 2018-04-06 at 08:17 -0500, Gary R Hook wrote:
>
>
> +struct dentry *iommu_debugfs_setup(void)
> +{
> + if (!debugfs_initialized())
This check is probably not needed.
> + return NULL;
> +
> + if (!iommu_debugfs_dir)
> + iommu_debugfs_dir = debugfs_create_dir("iommu",
> NULL);
> +
> + if (iommu_debugfs_dir)
> + pr_warn("WARNING: IOMMU DEBUGFS SUPPORT HAS BEEN
> ENABLED IN THIS KERNEL\n");
> +
As this gets called for each IOMMU, do you want to use pr_warn_once?
> + return iommu_debugfs_dir;
> +}
> +EXPORT_SYMBOL_GPL(iommu_debugfs_setup);
-Sohil
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2018-04-13 23:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-06 13:17 [PATCH v3 0/2] Base enablement of IOMMU debugfs support Gary R Hook
[not found] ` <152302042701.47565.17954813724758433858.stgit-tq90VzyE+wXkLsZ8J5Uweg@public.gmane.org>
2018-04-06 13:17 ` [PATCH v3 1/2] iommu - Enable debugfs exposure of the IOMMU Gary R Hook
[not found] ` <152302066417.47565.4017200105445420643.stgit-tq90VzyE+wXkLsZ8J5Uweg@public.gmane.org>
2018-04-13 23:55 ` Mehta, Sohil [this message]
[not found] ` <1523663790.2747.4.camel-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2018-04-17 17:36 ` Hook, Gary
[not found] ` <10e422dd-a3ca-8ecb-50fa-e7f131a55a12-5C7GfCeVMHo@public.gmane.org>
2018-04-17 17:55 ` Robin Murphy
2018-04-17 18:06 ` Hook, Gary
2018-04-17 17:46 ` Hook, Gary
[not found] ` <9123cd44-e01f-bff6-8441-792acbde10bc-5C7GfCeVMHo@public.gmane.org>
2018-04-17 18:13 ` Robin Murphy
2018-04-06 13:17 ` [PATCH v3 2/2] iommu/amd: Add basic debugfs infrastructure for AMD IOMMU Gary R Hook
[not found] ` <152302067362.47565.628887796165116844.stgit-tq90VzyE+wXkLsZ8J5Uweg@public.gmane.org>
2018-04-14 0:08 ` Mehta, Sohil
2018-04-17 17:38 ` Hook, Gary
[not found] ` <efa2b7a3-04a7-20b1-3651-89ebafa85c27-5C7GfCeVMHo@public.gmane.org>
2018-04-18 5:58 ` Yang, Shunyong
[not found] ` <1524031122.4031.5.camel-PT9Dzx9SjPiXmMXjJBpWqg@public.gmane.org>
2018-04-18 7:27 ` Mehta, Sohil
2018-04-18 8:31 ` Yang, Shunyong
2018-04-18 20:16 ` Mehta, Sohil
[not found] ` <1524082659.2747.37.camel-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2018-04-18 20:51 ` Hook, Gary
2018-04-19 1:52 ` Yang, Shunyong
2018-04-30 19:57 ` Gary R Hook
2018-04-17 0:52 ` Mehta, Sohil
[not found] ` <1523926423.2747.19.camel-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2018-04-17 17:42 ` Hook, Gary
2018-04-17 18:05 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1523663790.2747.4.camel@intel.com \
--to=sohil.mehta-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=gary.hook-5C7GfCeVMHo@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).