Re: [PATCH 5/7] arm64: tegra: Add Memory controller DT node on T194

Thierry Reding
2019-08-30T11:19:36Z

[-- Attachment #1.1: Type: text/plain, Size: 1918 bytes --]

On Thu, Aug 29, 2019 at 03:47:05PM -0700, Krishna Reddy wrote:
> Add Memory controller DT node on T194 and enable it.
> This patch is a prerequisite for SMMU enable on T194.
>
> Signed-off-by: Krishna Reddy <vdumpa@nvidia.com>
> ---
> arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi | 4 ++++
> arch/arm64/boot/dts/nvidia/tegra194.dtsi | 7 +++++++
> 2 files changed, 11 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi b/arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi
> index 62e07e11..4b3441b 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi
> @@ -47,6 +47,10 @@
> };
> };
>
> + memory-controller@2c00000 {
> + status = "okay";
> + };
> +
> serial@3110000 {
> status = "okay";
> };
> diff --git a/arch/arm64/boot/dts/nvidia/tegra194.dtsi b/arch/arm64/boot/dts/nvidia/tegra194.dtsi
> index adebbbf..d906958 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra194.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra194.dtsi
> @@ -6,6 +6,7 @@
> #include <dt-bindings/reset/tegra194-reset.h>
> #include <dt-bindings/power/tegra194-powergate.h>
> #include <dt-bindings/thermal/tegra194-bpmp-thermal.h>
> +#include <dt-bindings/memory/tegra186-mc.h>
>
> / {
> compatible = "nvidia,tegra194";
> @@ -130,6 +131,12 @@
> };
> };
>
> + memory-controller@2c00000 {
> + compatible = "nvidia,tegra186-mc";

I think we need to make this "nvidia,tegra194-mc" and then enhance the
Tegra186 driver to match on that compatible string.

Nothing to worry about just yet and I can make that change when
applying.

Thierry

> + reg = <0x02c00000 0xb0000>;
> + status = "disabled";
> + };
> +
> uarta: serial@3100000 {
> compatible = "nvidia,tegra194-uart", "nvidia,tegra20-uart";
> reg = <0x03100000 0x40>;
> --
> 2.1.4
>

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 156 bytes --]