[PATCH v1 2/3] iommu: Fix an issue in iommu_page_response() flags check

Yi Sun
2020-10-28T01:57:54Z

From: Jacob Pan <jacob.jun.pan@linux.intel.com>

original code fails when LAST_PAGE is set in flags.

Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
Signed-off-by: Liu Yi L <yi.l.liu@intel.com>
Signed-off-by: Yi Sun <yi.y.sun@linux.intel.com>
---
drivers/iommu/iommu.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
index 8c470f4..053cec3 100644
--- a/drivers/iommu/iommu.c
+++ b/drivers/iommu/iommu.c
@@ -1200,9 +1200,11 @@ int iommu_page_response(struct device *dev,
return -EINVAL;

if (msg->version != IOMMU_PAGE_RESP_VERSION_1 ||
- msg->flags & ~IOMMU_PAGE_RESP_PASID_VALID)
+ !(msg->flags & IOMMU_PAGE_RESP_PASID_VALID)) {
+ dev_warn_ratelimited(dev, "%s:Invalid ver %x: flags %x\n",
+ __func__, msg->version, msg->flags);
return -EINVAL;
-
+ }
/* Only send response if there is a fault report pending */
mutex_lock(&param->fault_param->lock);
if (list_empty(&param->fault_param->faults)) {
--
2.7.4