From: Ashish Mhetre via iommu <iommu@lists.linux-foundation.org>
To: <amhetre@nvidia.com>, <robin.murphy@arm.com>, <will@kernel.org>,
<vdumpa@nvidia.com>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: [Patch V3 0/2] iommu/arm-smmu: Fix races in iommu domain/group creation
Date: Tue, 10 Aug 2021 10:13:59 +0530 [thread overview]
Message-ID: <1628570641-9127-1-git-send-email-amhetre@nvidia.com> (raw)
When two devices with same SID are getting probed concurrently through
iommu_probe_device(), the iommu_group and iommu_domain are allocated more
than once because they are not protected for concurrency. This is leading
to context faults when one device is accessing IOVA from other device.
Fix this by protecting iommu_domain and iommu_group creation with mutexes.
Changes in v3:
* Updated commit messages.
* Added Signed-off-by in patch 2.
Ashish Mhetre (1):
iommu: Fix race condition during default domain allocation
Krishna Reddy (1):
iommu/arm-smmu: Fix race condition during iommu_group creation
drivers/iommu/arm/arm-smmu/arm-smmu.c | 6 +++++-
drivers/iommu/iommu.c | 2 ++
2 files changed, 7 insertions(+), 1 deletion(-)
--
2.7.4
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next reply other threads:[~2021-08-10 4:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-10 4:43 Ashish Mhetre via iommu [this message]
2021-08-10 4:44 ` [Patch V3 1/2] iommu: Fix race condition during default domain allocation Ashish Mhetre via iommu
2021-08-10 4:44 ` [Patch V3 2/2] iommu/arm-smmu: Fix race condition during iommu_group creation Ashish Mhetre via iommu
2021-08-10 20:25 ` [Patch V3 0/2] iommu/arm-smmu: Fix races in iommu domain/group creation Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1628570641-9127-1-git-send-email-amhetre@nvidia.com \
--to=iommu@lists.linux-foundation.org \
--cc=amhetre@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=vdumpa@nvidia.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox