From: John Garry <john.garry@huawei.com>
To: <robin.murphy@arm.com>, <joro@8bytes.org>, <will@kernel.org>
Cc: <iommu@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
<linuxarm@huawei.com>, <jsnitsel@redhat.com>,
<haifeng.zhao@linux.intel.com>,
John Garry <john.garry@huawei.com>
Subject: [PATCH v3 3/3] iova: Remove iovad->rcaches check in iova_rcache_get()
Date: Wed, 7 Sep 2022 21:02:34 +0800 [thread overview]
Message-ID: <1662555754-142760-4-git-send-email-john.garry@huawei.com> (raw)
In-Reply-To: <1662555754-142760-1-git-send-email-john.garry@huawei.com>
The iovad->rcaches check in iova_rcache_get() is pretty much useless
without the same check in iova_rcache_insert().
Instead of adding this symmetric check to fathpath iova_rcache_insert(),
drop the check in iova_rcache_get() in favour of making the IOVA domain
rcache init more robust to failure in future.
Signed-off-by: John Garry <john.garry@huawei.com>
---
drivers/iommu/iova.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/iova.c b/drivers/iommu/iova.c
index 8aece052ce72..a44ad92fc5eb 100644
--- a/drivers/iommu/iova.c
+++ b/drivers/iommu/iova.c
@@ -875,7 +875,7 @@ static unsigned long iova_rcache_get(struct iova_domain *iovad,
{
unsigned int log_size = order_base_2(size);
- if (log_size >= IOVA_RANGE_CACHE_MAX_SIZE || !iovad->rcaches)
+ if (log_size >= IOVA_RANGE_CACHE_MAX_SIZE)
return 0;
return __iova_rcache_get(&iovad->rcaches[log_size], limit_pfn - size);
--
2.25.1
next prev parent reply other threads:[~2022-09-07 13:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 13:02 [PATCH v3 0/3] iova: Some misc changes John Garry
2022-09-07 13:02 ` [PATCH v3 1/3] iova: Remove some magazine pointer NULL checks John Garry
2022-09-07 13:02 ` [PATCH v3 2/3] iova: Remove magazine BUG_ON() checks John Garry
2022-09-07 13:02 ` John Garry [this message]
2022-09-07 13:22 ` [PATCH v3 3/3] iova: Remove iovad->rcaches check in iova_rcache_get() Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1662555754-142760-4-git-send-email-john.garry@huawei.com \
--to=john.garry@huawei.com \
--cc=haifeng.zhao@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=jsnitsel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox