From: wangwudi <wangwudi@hisilicon.com>
To: <linux-arm-kernel@lists.infradead.org>, <iommu@lists.linux.dev>,
<linux-kernel@vger.kernel.org>
Cc: Rui Zhu <zhurui3@huawei.com>, Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Joerg Roedel <joro@8bytes.org>,
Lu Baolu <baolu.lu@linux.intel.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Yicong Yang <yangyicong@hisilicon.com>,
Tomas Krcka <krckatom@amazon.de>,
Jean-Philippe Brucker <jean-philippe@linaro.org>,
Nicolin Chen <nicolinc@nvidia.com>
Subject: [PATCH 1/1] Revert "iommu/arm-smmu-v3: Set TTL invalidation hint better"
Date: Mon, 31 Jul 2023 14:21:22 +0800 [thread overview]
Message-ID: <1690784482-30028-1-git-send-email-wangwudi@hisilicon.com> (raw)
From: Rui Zhu <zhurui3@huawei.com>
This reverts commit 6833b8f2e19945a41e4d5efd8c6d9f4cae9a5b7d.
This constraint violates the protocol. When tg is not 0 but ttl, scale,
and num are 0, the hardware reports the CERROR_IL gerror. In the
protocol, leaf is not a prerequisite for TTL.
Cc: Will Deacon <will@kernel.org>
Cc: Robin Murphy <robin.murphy@arm.com>
Cc: Joerg Roedel <joro@8bytes.org>
Cc: Lu Baolu <baolu.lu@linux.intel.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Yicong Yang <yangyicong@hisilicon.com>
Cc: Tomas Krcka <krckatom@amazon.de>
Cc: Jean-Philippe Brucker <jean-philippe@linaro.org>
Cc: Nicolin Chen <nicolinc@nvidia.com>
Cc: Rui Zhu <zhurui3@huawei.com>
Signed-off-by: Rui Zhu <zhurui3@huawei.com>
---
drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
index 9b0dc3505601..098e84cfa82f 100644
--- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
+++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
@@ -1898,13 +1898,8 @@ static void __arm_smmu_tlb_inv_range(struct arm_smmu_cmdq_ent *cmd,
/* Convert page size of 12,14,16 (log2) to 1,2,3 */
cmd->tlbi.tg = (tg - 10) / 2;
- /*
- * Determine what level the granule is at. For non-leaf, io-pgtable
- * assumes .tlb_flush_walk can invalidate multiple levels at once,
- * so ignore the nominal last-level granule and leave TTL=0.
- */
- if (cmd->tlbi.leaf)
- cmd->tlbi.ttl = 4 - ((ilog2(granule) - 3) / (tg - 3));
+ /* Determine what level the granule is at */
+ cmd->tlbi.ttl = 4 - ((ilog2(granule) - 3) / (tg - 3));
num_pages = size >> tg;
}
--
1.8.3.1
next reply other threads:[~2023-07-31 6:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 6:21 wangwudi [this message]
2023-08-01 8:55 ` [PATCH 1/1] Revert "iommu/arm-smmu-v3: Set TTL invalidation hint better" Will Deacon
2023-08-02 10:52 ` zhurui
2023-08-04 9:31 ` [PATCH v2 1/1] iommu/arm-smmu-v3: Fix error case of range command zhurui
2023-08-04 16:52 ` Will Deacon
2023-08-04 18:30 ` Nicolin Chen
2023-08-06 5:28 ` zhurui
2023-08-07 19:20 ` Robin Murphy
2023-08-08 16:24 ` Will Deacon
2023-08-08 16:43 ` Robin Murphy
2023-08-09 9:22 ` zhurui
2023-08-09 11:23 ` Will Deacon
2023-08-09 13:48 ` Robin Murphy
2023-08-18 16:19 ` Robin Murphy
2023-08-18 16:21 ` Will Deacon
2023-08-25 8:12 ` zhurui
2023-09-06 5:05 ` Easwar Hariharan
2023-09-06 12:59 ` Robin Murphy
2023-09-07 9:21 ` Will Deacon
2023-08-08 16:12 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1690784482-30028-1-git-send-email-wangwudi@hisilicon.com \
--to=wangwudi@hisilicon.com \
--cc=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=jean-philippe@linaro.org \
--cc=jgg@ziepe.ca \
--cc=joro@8bytes.org \
--cc=krckatom@amazon.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolinc@nvidia.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
--cc=yangyicong@hisilicon.com \
--cc=zhurui3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox