From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells Subject: Re: [PATCH 1/4] pci: Add PCI_BUS() and PCI_DEVID() interfaces to return bus number and device id Date: Tue, 26 Feb 2013 00:45:40 +0000 Message-ID: <19586.1361839540@warthog.procyon.org.uk> References: <1360623637.2950.63.camel@lorien2> Return-path: In-Reply-To: Sender: linux-pci-owner@vger.kernel.org To: Bjorn Helgaas Cc: dhowells@redhat.com, shuah.khan@hp.com, Joerg Roedel , paulmck@linux.vnet.ibm.com, linasvepstas@gmail.com, davej@redhat.com, tglx@linutronix.de, mtk.manpages@gmail.com, iommu@lists.linux-foundation.org, LKML , linux-pci@vger.kernel.org, shemminger@vyatta.com, jiang.liu@huawei.com, wangyijing@huawei.com, shuahkhan@gmail.com List-Id: iommu@lists.linux-foundation.org Bjorn Helgaas wrote: > David, can you point me at a description of include/uapi ... what is > there and why, and how we should decide what new things go in > include/uapi/linux/pci.h as opposed to include/linux/pci.h? Maybe > there should be something in Documentation/? Probably in CodingStyle, Submitting* or somewhere similar. > I'm guessing it's something to do with being exported to userland, but > I'm not sure the things in this patch (PCI_DEV_ID, PCI_BUS) are really > exportable in the sense of being used for syscalls, etc. As a rule, if it's in uapi/ then it's exported to userspace; if it's not, then it isn't. The old headers where disintegrated along the lines of __KERNEL__ delimited sections by my scripts. David