Re: [PATCH v8 04/12] iommufd/device: Only add reserved_iova in non-pasid path

[Yi Liu <yi.l.liu@intel.com>]

On 2025/2/28 23:24, Jason Gunthorpe wrote:
> On Wed, Feb 26, 2025 at 03:40:24AM -0800, Yi Liu wrote:
> 
>> @@ -471,6 +471,7 @@ int iommufd_hw_pagetable_attach(struct iommufd_hw_pagetable *hwpt,
>>   				ioasid_t pasid)
>>   {
>>   	struct iommufd_hwpt_paging *hwpt_paging = find_hwpt_paging(hwpt);
>> +	bool add_reserved = !!(hwpt_paging && pasid == IOMMU_NO_PASID);
> 
> The !! is unncessary. !! is a trick to booleanize a value:
>   - Assiging or casting to bool already implicitly does !!
>   - && is already a boolean operator
> 
>> @@ -590,6 +591,7 @@ iommufd_device_do_replace(struct iommufd_device *idev, ioasid_t pasid,
>>   			  struct iommufd_hw_pagetable *hwpt)
>>   {
>>   	struct iommufd_hwpt_paging *hwpt_paging = find_hwpt_paging(hwpt);
>> +	bool add_reserved = !!(hwpt_paging && pasid == IOMMU_NO_PASID);
> 
> Here too

got it.

> Otherwise
> 
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
> 
> Jason

-- 
Regards,
Yi Liu